Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 18 May 2020 17:25:29 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Changbin Du <changbin.du@gmail.com>
Cc:     Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] function_graph: apply tracing option 'irq-info'
Message-ID: <20200518172529.35ec248e@gandalf.local.home>
In-Reply-To: <20200516160953.155630-1-changbin.du@gmail.com>
References: <20200516160953.155630-1-changbin.du@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 17 May 2020 00:09:53 +0800
Changbin Du <changbin.du@gmail.com> wrote:

> The tracing option 'irq-info' is only used by function tracer by far. This
> patch makes it also against function graph tracer. Then the two tracers
> have consistent behavior of this option.
> 
> Signed-off-by: Changbin Du <changbin.du@gmail.com>
> ---

Sorry, the function graph tracer is unique, and yes, you need to enable
latency_format.

Note, irq_info is meaning less with the function_graph tracer, as it
doesn't change the latency_format with or without it.

This patch basically just makes the latency_format default for the
function_graph tracer, and changes default settings for no real advantage.
It will cause regressions.

-- Steve