Received: by 2002:a17:90a:bc8d:0:0:0:0 with SMTP id x13csp1521682pjr; Mon, 18 May 2020 15:22:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5bSK9L0qt6tQyeh7ADhk8hK0UD5aGGRF/UcUvJKZz+BrJfmoS7ZoJSkHtg9j8Fm2fq5cf X-Received: by 2002:aa7:db45:: with SMTP id n5mr9419627edt.147.1589840524442; Mon, 18 May 2020 15:22:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589840524; cv=none; d=google.com; s=arc-20160816; b=JRZ5tMZKGSxXM8gGT80iOyMRZIczwEndRdGSndwywRCxLyi12OEkGzpSe9fVGc4UIo A+Gk7ZaCU3MTRgajrNP9cHoD2/9/LYglCq9AEe677dNlGhqaYUsH+bIqerkkrzrKFtux hgw8w/2/kM74LfafStu6MI3+yOyueJGyEqSpcx1W2IhUiPUegDUOwa+d9YzjNkckLu3q CtO3dqrQXqVBMoYNmvYbm1Ip8yoa4XrFzQR0BZzai6manWEC2HGQswRJcuA9FtHC7XK0 u4aLhza8OzIy6zuyH2mE75yXM+lfa5ztBFdpbCLRpRyPC8vXTiupdPJptTnmoqNu8e5Q XZKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=2CtSoHG+4gCaTs00WL2Ih5aoT28r9TyXyiDxDHcfGHk=; b=ETqtMR2AmihCvf3fTjOUorgAi8fJO2G7zS3FtgZ1LH6UQY+mbe3ZCnhtR0Vs0VfiSs eQpW0+QaRAXFhCB67OcyOVznLXivkb8CzhLjyZpPlV5k9HDjqf4VNtO2TcFW4xkFjmc4 /2dzaNFSKA1Zslpozsixq17BbExf/8aUjGhh47MJbkCPzIxocdF7tG8OcAIUmF+h+HKg /h/Tx1qURLP3bBVcaNLjr+ktyTULS6m1IFyo+o5SoQIBWI77jyBVHxKwOG/bHcADlr/C 1t0T0OItJejC21BbeV7Lsmmou2uYiq2afkCcb99cJ9rkwv8pESUV476iZ9O4uqiwp2B/ XtDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d6si7432634edy.66.2020.05.18.15.21.42; Mon, 18 May 2020 15:22:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728294AbgERWUS (ORCPT + 99 others); Mon, 18 May 2020 18:20:18 -0400 Received: from mga01.intel.com ([192.55.52.88]:47013 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726386AbgERWUS (ORCPT ); Mon, 18 May 2020 18:20:18 -0400 IronPort-SDR: nPtcy3ktJ2Aa5zGV7ptvVTd1UTnMi7Hrg/UVpVlvIkvekMpoaYEnStfvwwCu+nqE5xqg9Afcvu MfWRPWqXxUDg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2020 15:20:18 -0700 IronPort-SDR: bunCAUpkQe5rEtfhlNJhPWAzLxi8Vq+VFArHQiuw64K4VzT++yLn9vczgTv1L+qSPLrskSpF0b V0DPyg0vOPhg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,407,1583222400"; d="scan'208";a="267675369" Received: from ranerica-svr.sc.intel.com ([172.25.110.23]) by orsmga006.jf.intel.com with ESMTP; 18 May 2020 15:20:17 -0700 Date: Mon, 18 May 2020 15:20:37 -0700 From: Ricardo Neri To: Giovanni Gherdovich Cc: Peter Zijlstra , Srinivas Pandruvada , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Len Brown , "Rafael J . Wysocki" , x86@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Torvalds Subject: Re: [PATCH 1/2] x86, sched: Prevent divisions by zero in frequency invariant accounting Message-ID: <20200518222037.GA14829@ranerica-svr.sc.intel.com> References: <20200428132450.24901-1-ggherdovich@suse.cz> <20200428132450.24901-2-ggherdovich@suse.cz> <20200501133042.GE3762@hirez.programming.kicks-ass.net> <1588429500.8505.29.camel@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1588429500.8505.29.camel@suse.cz> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 02, 2020 at 04:25:00PM +0200, Giovanni Gherdovich wrote: > > > > I've changed the patch like so.. OK? > > > > (ok, perhaps I went a little overboard with the paranoia ;-) > > Right, I wasn't really checking for overflow, only for when the product > "mcnt * arch_max_freq_ratio" becomes zero. > > Thanks for your edit (I took note of the macros check_*_overflow, didn't know > them). I fully subscribe to the paranoid approach. > > I understand you've already edited the patches in your tree, so I am not > resending, just confirming my > > Signed-off-by: Giovanni Gherdovich Hi, have these changes been merged? I still don't see them in the tip or Linus' tree. Thanks and BR, Ricardo