Received: by 2002:a17:90a:bc8d:0:0:0:0 with SMTP id x13csp1522010pjr; Mon, 18 May 2020 15:22:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwSJd2TPrt+f/ZnB0Go/itkVHwhfVGd/4IZg3thIdOH3SvRTRo4nIf62pmkhOrK/JUAMd0/ X-Received: by 2002:a17:906:8304:: with SMTP id j4mr16910459ejx.200.1589840556683; Mon, 18 May 2020 15:22:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589840556; cv=none; d=google.com; s=arc-20160816; b=ymJnqjhT06F7zHlcPLEzEYw/2vlB8p0N742coJBUtRpG2i0NPvfNWL8LoJX4hIN1zW feVBbfAGRrEpYi2xehGenHI6Ahy+9qSxPMj4t/pcFdtyU9310sN7FkoyQfFv7gRKjx7f natLhjsUMRTjQ9J6FURZVTToO07RDOEMAjYHtBIDAITyvl6czMM7oJghz/yZdiXgOoZw u5Rq/DfRzGkNfJXkGH/X/E0WKH3YgGpkVHdI+qldx1cx60qFwT3+/ANkzRtPREi3G4Wk kV/9S+VuNaZ40DiF9gjFOSrzcen2NdINWykh7WrpbeEdjvfkfteGN7DoXS5VxK4w/r57 /2wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=vU1mm24jQYRvRte5d1/xeYB4j+j9KoHAqlrudWm0qg4=; b=CaVe4lrEvkvVj5j8716grcyfBmQIfGzP9vqiicXZSZRxqhiatIrGPh1M39dGKbk335 w1LB2ccRyl1G8P62HHhH+EzUEd/Yuc3aAXYb6aiGBvwblXsSglFhpPtWIQRcoSgyNE1M qHqr6kb6PZuPFRi9Wn84CDXxtbVxWSCF7pn6FqQILdmgbpgr9CFf3VSm8PDSUmjXb8nR Mk9XcO1fR8qR0WLUQnuV35eYRfRR9Jxy3wp6XMKAOU6JXJkppzSClgeTTTy3hL1v9XsZ 8BtU6zcIU+ef+MSj4dM9XY1rRKtz68DgyNRxkTzL6ofzWGh3z8s8+yqN3Jgcdv2e7EaA 0jSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zZ+klVAa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lr24si6989169ejb.383.2020.05.18.15.22.13; Mon, 18 May 2020 15:22:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zZ+klVAa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728467AbgERWSb (ORCPT + 99 others); Mon, 18 May 2020 18:18:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:33760 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726640AbgERWSa (ORCPT ); Mon, 18 May 2020 18:18:30 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D7BC62081A; Mon, 18 May 2020 22:18:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589840309; bh=GAsP72OzLRqNeGGIYQczDNH78GgALiPWljn3TChp7vo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zZ+klVAaZtV27MGlVb0LzirdC6IcRNdxtR8vdL8+p1v703lmi5J9HVBsa59wZfYS2 rcHhIFOwmI6Yc/w9iEWdmxMN/U7GWNm4qd9W6owTNY+8aCiuJZFmriA8jGFyro1lnf B2QLoucZDhxzU0xGGj8zNn76nXG71emZmJGgdURs= Date: Mon, 18 May 2020 15:18:28 -0700 From: Andrew Morton To: Joerg Roedel Cc: Joerg Roedel , x86@kernel.org, hpa@zytor.com, Dave Hansen , Andy Lutomirski , Peter Zijlstra , rjw@rjwysocki.net, Arnd Bergmann , Steven Rostedt , Vlastimil Babka , Michal Hocko , Matthew Wilcox , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig Subject: Re: [PATCH v3 2/7] mm/vmalloc: Track which page-table levels were modified Message-Id: <20200518151828.ad3c714a29209b359e326ec4@linux-foundation.org> In-Reply-To: <20200516125641.GK8135@suse.de> References: <20200515140023.25469-1-joro@8bytes.org> <20200515140023.25469-3-joro@8bytes.org> <20200515130142.4ca90ee590e9d8ab88497676@linux-foundation.org> <20200516125641.GK8135@suse.de> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 16 May 2020 14:56:41 +0200 Joerg Roedel wrote: > Hi Andrew, > > On Fri, May 15, 2020 at 01:01:42PM -0700, Andrew Morton wrote: > > On Fri, 15 May 2020 16:00:18 +0200 Joerg Roedel wrote: > > Lots of collisions here with Christoph's "decruft the vmalloc API" series > > (http://lkml.kernel.org/r/20200414131348.444715-1-hch@lst.de). > > > > I attempted to fix things up. > > > > unmap_kernel_range_noflush() needed to be redone. > > > > map_kernel_range_noflush() might need the arch_sync_kernel_mappings() call? > > Yes, map_kernel_range_noflush() needs the arch_sync_kernel_mappings() > call as well. > This? --- a/mm/vmalloc.c~mm-vmalloc-track-which-page-table-levels-were-modified-fix +++ a/mm/vmalloc.c @@ -309,6 +309,9 @@ int map_kernel_range_noflush(unsigned lo return err; } while (pgd++, addr = next, addr != end); + if (mask & ARCH_PAGE_TABLE_SYNC_MASK) + arch_sync_kernel_mappings(start, end); + return 0; } It would be nice to get all this (ie, linux-next) retested before we send it upstream, please.