Received: by 2002:a17:90a:bc8d:0:0:0:0 with SMTP id x13csp1573406pjr; Mon, 18 May 2020 16:46:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyQlQLdNfnV2X7jif8zCA5apptO9MC9DUqMAAsIx7x74EuCd/zubjRXQ87ZTsh4Kerieanl X-Received: by 2002:a50:d785:: with SMTP id w5mr15254799edi.212.1589845587017; Mon, 18 May 2020 16:46:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589845587; cv=none; d=google.com; s=arc-20160816; b=BqndnI4PSEhHiMSR982R4SDzhF1pyLibO13yiO42H4wHbJGJNkhD+ZEA1d4958kOnt oXb1V5S4J6nZfRxZx9pZ5e3kYQh3pW9Fwdnu+cGZBWJb+iHgDNP5XbSYZaBdoYbpMbU9 xBf+wi9jPlDKbtF3nmTqnIwd7ImMypaM93QukbCDBNU84ZAkYklWiihIPC0r0ookow96 SM069WpeIZnVBW3//EiJDT9CuUlqo+CujMSAaSFSwL2yaSWa0InRHeTDfmXzGm6Q9vL3 NEvA5vumjAduFwMwyw1fBhsMPemg4GlzB/QfZrTBGsHlNYI7hxnFSKNjQ1h/WtdsU69S yspQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=oHGDX6vQnN/c4yFrGv0DC1HQssvToxdYsI1YpvI2zhQ=; b=IsVMDX0ltgjD2NM7PwBT7x0BgrvHg0fJwXKyMvKwL3fc9HPt3dYArxwyu7GiOfkIL3 fYzyUJrO7y8MZmgpDJKoITFa+HWnhkHfVPKUt13JqYLjvW9ozex21cAWiq1LfFLu4uX8 YbNT7r03GZWMSn1fH1MyK0FuIc7Ga2p2DMyZNAxdPNwRxMG7KCKXQd4IK5UU0QkJLOTV afaAEwc9jlWpiHo3pT0l/Nj/R+RRb67ulyOZ1mgV9PU+fNQIPkwZF/aLqgupE9ZX3AXR WiC+xcW1y3w0LmtGraRS5n86vwnjzny6GVpZOKs/v5jLhwXHUdtJR2mlGO5q4BSYCuUy 0HBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Cw+kU7K7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jx4si7046150ejb.216.2020.05.18.16.46.04; Mon, 18 May 2020 16:46:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Cw+kU7K7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733109AbgERSGH (ORCPT + 99 others); Mon, 18 May 2020 14:06:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:53924 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733098AbgERSGD (ORCPT ); Mon, 18 May 2020 14:06:03 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1FE5220853; Mon, 18 May 2020 18:06:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589825162; bh=rMY9VnLpl8TAjaYJ3H7+fGfo4xlYfKw+RZr2xkmtW38=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Cw+kU7K7XRtZTlRiu6cZdkJ2A6wkwEreeUUOCiojMacZjvGj/mDphKkIOEmqMoe3r SSRGLThidrLTGV2Wox71/ruriJG2aNe+bF7BnH0qrzUgDUoR6hMnP55dtP1rchOlQ7 Vcay5EzrD5eSjKbrxa2JE7EPWm5a9Coj9U0s+TAw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Imre Deak , =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , Rodrigo Vivi Subject: [PATCH 5.6 153/194] drm/i915/tgl+: Fix interrupt handling for DP AUX transactions Date: Mon, 18 May 2020 19:37:23 +0200 Message-Id: <20200518173543.985344600@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200518173531.455604187@linuxfoundation.org> References: <20200518173531.455604187@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Imre Deak commit 4457a9db2bdec2360ddb15242341696108167886 upstream. Unmask/enable AUX interrupts on all ports on TGL+. So far the interrupts worked only on port A, which meant each transaction on other ports took 10ms. Cc: # v5.4+ Signed-off-by: Imre Deak Reviewed-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20200504075828.20348-1-imre.deak@intel.com (cherry picked from commit 054318c7e35f1d7d06b216143fff5f32405047ee) Signed-off-by: Rodrigo Vivi Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/i915/i915_irq.c | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -3324,7 +3324,7 @@ static void gen8_de_irq_postinstall(stru u32 de_pipe_masked = gen8_de_pipe_fault_mask(dev_priv) | GEN8_PIPE_CDCLK_CRC_DONE; u32 de_pipe_enables; - u32 de_port_masked = GEN8_AUX_CHANNEL_A; + u32 de_port_masked = gen8_de_port_aux_mask(dev_priv); u32 de_port_enables; u32 de_misc_masked = GEN8_DE_EDP_PSR; enum pipe pipe; @@ -3332,18 +3332,8 @@ static void gen8_de_irq_postinstall(stru if (INTEL_GEN(dev_priv) <= 10) de_misc_masked |= GEN8_DE_MISC_GSE; - if (INTEL_GEN(dev_priv) >= 9) { - de_port_masked |= GEN9_AUX_CHANNEL_B | GEN9_AUX_CHANNEL_C | - GEN9_AUX_CHANNEL_D; - if (IS_GEN9_LP(dev_priv)) - de_port_masked |= BXT_DE_PORT_GMBUS; - } - - if (INTEL_GEN(dev_priv) >= 11) - de_port_masked |= ICL_AUX_CHANNEL_E; - - if (IS_CNL_WITH_PORT_F(dev_priv) || INTEL_GEN(dev_priv) >= 11) - de_port_masked |= CNL_AUX_CHANNEL_F; + if (IS_GEN9_LP(dev_priv)) + de_port_masked |= BXT_DE_PORT_GMBUS; de_pipe_enables = de_pipe_masked | GEN8_PIPE_VBLANK | GEN8_PIPE_FIFO_UNDERRUN;