Received: by 2002:a17:90a:bc8d:0:0:0:0 with SMTP id x13csp1574067pjr; Mon, 18 May 2020 16:47:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw45JzKL4+bjMfKa9mfc6YI1N0+3RyIRTuAFX7Falx7d/JY59NoaIH5fy+JyFcfFC3T+iQE X-Received: by 2002:a17:907:9484:: with SMTP id dm4mr7450569ejc.56.1589845655369; Mon, 18 May 2020 16:47:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589845655; cv=none; d=google.com; s=arc-20160816; b=bfvLDtFiKLtYlm7GebhTRo9ksdzZPTng/if1w2nrtT7EJXSky98hYwQoyNVFgEFDZa i52NOUbQnx0oaMFiQqwuDbz2Ol1gFU0/QlYH8NZIoYr9nUY6Qj0Le8Qp/sDs3Ay8s+nd n91UjWXD0Dw33VjXR/HTKwSlI41Yoa5mgxM8Oqj/9xxwRWYW9u/o81RDzpW+X5byuxKV 0Tk0fj5H7Jb7w34L5jEUQ3N8TnvDGyiTTCAC9xaMhDiPKkgpxSRDteumHEHqCQW8O/yq QbNEK9cjw5TrzMToe9Wuf5hNALSm/odMQd5Xv44CZm1BlHaYCe/vA7oo3Ky1ZVAcvIzz ioiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=9ueO89sfVmu/Ap3XUYJF0X9A6TL47ALEJ3bEnUkGPhc=; b=Gi+ESsdQ5gNlAJVDI7wEwJ7NDFAlK0VlRDKKUkBxoXzeq93FHaXCQ6GtrX7jk2ae30 /czZnLnFPN6YGeDAI21EKHl5ABfQwoYA2bgsrSCI2MJjAEzeu2hpna4mMQouTOnK2JPD rZF2vtGfF+QK+VYwG+P9cr0+cfHPfG84RRjyQK0b+axoi5LIJbwuEjYFw3hjLKogWGYy 1XCA9giu/2o9RQDzNMxN0t03KsGgszOXskhAo99azpNR0bXxeD+Vt0DFXaOQXIxEMff4 6Adb2RYM+guRtYwlnkuV5nPvb9Tv0CCpVQANu/SEBxIqhHV51HnAHyLnAZOZXbhUduOK v6vw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JckdDQRK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p30si7943203edd.583.2020.05.18.16.47.12; Mon, 18 May 2020 16:47:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JckdDQRK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732611AbgERS37 (ORCPT + 99 others); Mon, 18 May 2020 14:29:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:37618 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728478AbgERRlU (ORCPT ); Mon, 18 May 2020 13:41:20 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6E03420715; Mon, 18 May 2020 17:41:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589823679; bh=+YDyGxiPU6HgZ0QqhhHYusz2iCtZUh4TaMWN612TJMw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JckdDQRK0XOTiQLh0lw7zs+lB9Rg7zV49bx/07PuUZHq8Rl1mowMMFD8uHKjQ+43s bCiQQOZr4xxS9hJ16iuUxmPeUpP1/cBa4uHagVBv91DIUpRRBrorqP4sPUh5JXPNbp KEOMABYNK4wckbr7UT0b/6TcCNERwX9b9IiB1fN8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Felipe Balbi Subject: [PATCH 4.4 79/86] usb: gadget: net2272: Fix a memory leak in an error handling path in net2272_plat_probe() Date: Mon, 18 May 2020 19:36:50 +0200 Message-Id: <20200518173506.597367557@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200518173450.254571947@linuxfoundation.org> References: <20200518173450.254571947@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET commit ccaef7e6e354fb65758eaddd3eae8065a8b3e295 upstream. 'dev' is allocated in 'net2272_probe_init()'. It must be freed in the error handling path, as already done in the remove function (i.e. 'net2272_plat_remove()') Fixes: 90fccb529d24 ("usb: gadget: Gadget directory cleanup - group UDC drivers") Signed-off-by: Christophe JAILLET Signed-off-by: Felipe Balbi Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/udc/net2272.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/usb/gadget/udc/net2272.c +++ b/drivers/usb/gadget/udc/net2272.c @@ -2670,6 +2670,8 @@ net2272_plat_probe(struct platform_devic err_req: release_mem_region(base, len); err: + kfree(dev); + return ret; }