Received: by 2002:a17:90a:bc8d:0:0:0:0 with SMTP id x13csp1574249pjr; Mon, 18 May 2020 16:47:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwu+EivuZWF5Z1+SiRlpHyUz1JubZ/X5EjbvHQEs0zSFPd6TtRdWJuOQcm+66fjaPKN0rfM X-Received: by 2002:a17:906:6055:: with SMTP id p21mr17371009ejj.316.1589845675727; Mon, 18 May 2020 16:47:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589845675; cv=none; d=google.com; s=arc-20160816; b=AjXx4NgMduea9oeAM3QiPIv+vjt5FKG6vp/UYb9HWk7mtnNDpXoMZpMqYK8k5jAvDw iCJz5sl1fT9EfL83ptpskZ2x47iK0DZ4XQIZPheR5PRjtVh3g+0q9/gP+faENIHs5ueN wpIg9D+okydh+6hexfiW80CtXoX5KR0TZiwCWKCx2bMcePKdQTeqb+IbrkF/HiQKcKro d2WZdkCHv5Z5t1BsISwcvhSZB3/EU3+EdUJuHtYcMjF57DXSZr+wIiZL92+gGbE2+0GA k+oyilzDQjCOcRyjBFGQkYZvRK8YKTps6ka+KLUHjbUFdIDPlnrcA0WeNtI9+XmKEbUq B8HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=SzIhRiOMXWZhgr6VdLsBALPdk3mIXuPrAK1lveZ+MHs=; b=Fezbohq87yEY7eFB4YyPSSn5g4CI/1aY/U1YGq0dDzlr+Zu3xcZsEm8mYPOIT0HNeE xM07XrGlMh/Bl7dglT+/bfvilKmiuVpq5wibDHWex56SN4pFkwtd93J+Hj4SfA+3LYmz 5i70iIuuS+Ufcx2/0TAx5SU4AfDZ4Fm/kD2MUKTd5eaaHlhRoZCrZAuYY5RyRRbT/9Rt S9PwyQv9S8FkEXGG9KzUaPpG4mA4xcPjLBPSmI5sfCaXelMNLx6m8/FFz/yD9WYPddex Lqtz7SFdHDzPkhXYYUATKAkGTkXJ6yElgUj2Fo2OtuAOS0ufTIA7hVNIa+ygOgE19csA M1aQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lLAs9wpX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u6si7093335edx.460.2020.05.18.16.47.32; Mon, 18 May 2020 16:47:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lLAs9wpX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387472AbgERSID (ORCPT + 99 others); Mon, 18 May 2020 14:08:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:57288 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387453AbgERSIA (ORCPT ); Mon, 18 May 2020 14:08:00 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 208B920715; Mon, 18 May 2020 18:07:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589825279; bh=d8DyXlhOtVWzpRokN+kIiZrMvEAeG1gd9dcu5S7jx6s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lLAs9wpX7T5zKTnFSKpCKEakq0xXIjk03vtSFTUqPyczNAryCBhIHM0rawcNGnL6Z ZktgurtFAYVo0aoIMtvPuTueCaRyMrxqzDTv9e6EzAcYDiiapUeqywqzEXxzXm9lY7 trI83ZQfoEnua6mF1rDrMZu128dVy1VEXdCO4JfQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kai-Heng Feng , Takashi Iwai Subject: [PATCH 5.6 170/194] Revert "ALSA: hda/realtek: Fix pop noise on ALC225" Date: Mon, 18 May 2020 19:37:40 +0200 Message-Id: <20200518173545.879529795@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200518173531.455604187@linuxfoundation.org> References: <20200518173531.455604187@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kai-Heng Feng commit f41224efcf8aafe80ea47ac870c5e32f3209ffc8 upstream. This reverts commit 3b36b13d5e69d6f51ff1c55d1b404a74646c9757. Enable power save node breaks some systems with ACL225. Revert the patch and use a platform specific quirk for the original issue isntead. Fixes: 3b36b13d5e69 ("ALSA: hda/realtek: Fix pop noise on ALC225") BugLink: https://bugs.launchpad.net/bugs/1875916 Signed-off-by: Kai-Heng Feng Link: https://lore.kernel.org/r/20200503152449.22761-1-kai.heng.feng@canonical.com Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/patch_realtek.c | 2 -- 1 file changed, 2 deletions(-) --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8121,8 +8121,6 @@ static int patch_alc269(struct hda_codec spec->gen.mixer_nid = 0; break; case 0x10ec0225: - codec->power_save_node = 1; - /* fall through */ case 0x10ec0295: case 0x10ec0299: spec->codec_variant = ALC269_TYPE_ALC225;