Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp3089583ybk; Mon, 18 May 2020 17:41:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwSsl9ESmPuQZ1Qxm5/HTrxi0c0rv5MjtepTYG/5HldaWs65x4waTgBkV4BSt+uh4bq0Vzm X-Received: by 2002:aa7:d8c2:: with SMTP id k2mr7333351eds.145.1589848914150; Mon, 18 May 2020 17:41:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589848914; cv=none; d=google.com; s=arc-20160816; b=bMoBIuvLuoh8eGk3DcPpk4afGO5dHLIeTw3h6lgw+f4OT1mjRkKRAMixsjMODtkv0z o9xwWGPyUXDQAImthaJmy7FLJkkIJrVam8GfPElEMr5eq5bJGK8Lzygi/jA2ydQFeAV9 Udf2g9Wr8v4iQHtP5aiWKZCfAlvr5lZvRpF0k4thdxJ7e/bOEdN6oL+q2jEI6YnGg/C3 TfEVheI/YWuRN4EnBnZL4TCJJLj1aLhHFCLFRu9oiMh7kf+3hWkLmBMHGaJmVgWfwb7f Nhqur4tszPuoOqiM+z4i6Tbhof8ITB5UP3SJGRQ6GAjLsURkp7kxDi2Z8pNFYpLfFjFu Vkfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:to:subject:ironport-sdr :ironport-sdr; bh=SNWx5T+4MyagMK3ool2mZe2arX1cd9gAJKOf7Il7NKE=; b=ejP8VKUNFx0Mdguk8dI8U6G6m9/rmh/3FJ55Uc56fL9YSs1jdjHy/VFvIuIm1GipLH 4lZQIFyGglqNOtrkE8QQhymCFr86g8pzHT6TbGZ5pTlhFP9cpXFljAtSck4tRdjXujTe albfxCqRC+QFYPFkkw6SjhWvMbC4USLun12HrtA3twncxgPbNxLXD9NeumUI97hFMzbX oT5YifgPJlSWkw0u2ZiurURYR3NrQIEcGnF6iQXrONDfCqMk1Pt9rT3qIxbYzdArndiE gTwvu9xUFuZkncS03JkUpwD65HbVSTGTiVw11bb93T175bc/3mwD9F1f90BYfGawXYbF cWuA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id df5si7557889edb.44.2020.05.18.17.41.31; Mon, 18 May 2020 17:41:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728111AbgESAiU (ORCPT + 99 others); Mon, 18 May 2020 20:38:20 -0400 Received: from mga14.intel.com ([192.55.52.115]:25755 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726696AbgESAiU (ORCPT ); Mon, 18 May 2020 20:38:20 -0400 IronPort-SDR: xYBZKhwRkVlfoTfBolAbVVasjbMSQAaBZiqZFGTn5Q3YcaDdnCucIftved0ORjSKveEinvq77Z 0h0BwQsTQh6g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2020 17:38:18 -0700 IronPort-SDR: 0m0QWa4Q9XSSip/OmAQy9pnmaXPKrgmUmvkL2wcHpRqrYy0L2j7DISG5vjRANVBDC+Fbpn/tfk u/jsRRxhclPQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,408,1583222400"; d="scan'208";a="267708785" Received: from cmikhael-mobl.amr.corp.intel.com (HELO [10.255.1.49]) ([10.255.1.49]) by orsmga006.jf.intel.com with ESMTP; 18 May 2020 17:38:13 -0700 Subject: Re: [PATCH v10 01/26] Documentation/x86: Add CET description To: Yu-cheng Yu , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang References: <20200429220732.31602-1-yu-cheng.yu@intel.com> <20200429220732.31602-2-yu-cheng.yu@intel.com> <5cc163ff9058d1b27778e5f0a016c88a3b1a1598.camel@intel.com> <44c055342bda4fb4730703f987ae35195d1d0c38.camel@intel.com> <32235ffc-6e6c-fb3d-80c4-a0478e2d0e0f@intel.com> <631f071c-c755-a818-6a97-b333eb1fe21c@intel.com> <0f751be6d25364c25ee4bddc425b61e626dcd942.camel@intel.com> <075c5757d6c4d3813f7ae45288b765d76de8b6fc.camel@intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <2eb98637-bd2d-dda6-7729-f06ea84256ca@intel.com> Date: Mon, 18 May 2020 17:38:13 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <075c5757d6c4d3813f7ae45288b765d76de8b6fc.camel@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/18/20 4:47 PM, Yu-cheng Yu wrote: > On Fri, 2020-05-15 at 19:53 -0700, Yu-cheng Yu wrote: >> On Fri, 2020-05-15 at 16:56 -0700, Dave Hansen wrote: >>> On 5/15/20 4:29 PM, Yu-cheng Yu wrote: >>>> [...] >>>> I have run them with CET enabled. All of them pass, except for the following: >>>> Sigreturn from 64-bit to 32-bit fails, because shadow stack is at a 64-bit >>>> address. This is understandable. >>> [...] >>> One a separate topic: You ran the selftests and one failed. This is a >>> *MASSIVE* warning sign. It should minimally be described in your cover >>> letter, and accompanied by a fix to the test case. It is absolutely >>> unacceptable to introduce a kernel feature that causes a test to fail. >>> You must either fix your kernel feature or you fix the test. >>> >>> This code can not be accepted until this selftests issue is rectified. > The x86/sigreturn test constructs 32-bit ldt entries, and does sigreturn from > 64-bit to 32-bit context. We do not have a way to construct a static 32-bit > shadow stack. Why? What's the limiting factor? Hardware architecture? Something in the kernel? > Why do we want that? I think we can simply run the test with CET > disabled. The sadistic parts of selftests/x86 come from real bugs. Either bugs where the kernel fell over, or where behavior changed that broke apps. I'd suggest doing some research on where that particular test case came from. Find the author of the test, look at the changelogs. If this is something that a real app does, this is a problem. If it's a sadistic test that Andy L added because it was an attack vector against the entry code, it's a different story. I don't personally know the background, but the changelogs can help you find the person that does.