Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp3099413ybk;
        Mon, 18 May 2020 18:01:18 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJyhW7u0IxFQ15ArMBWZp1NemMOtAXz9ZiihgxCflJ4AYFpbCPeBJ5DTEagDluWyx2jpgMuC
X-Received: by 2002:a17:907:20d9:: with SMTP id qq25mr10574559ejb.202.1589850078502;
        Mon, 18 May 2020 18:01:18 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1589850078; cv=none;
        d=google.com; s=arc-20160816;
        b=k+ybNVCAFaCbP/00dXtkkY0j/kE9dFqTi4Ly7ndJ9fd4eGFd5v6E9uKGjQ3jD+bX/0
         0vRo+yswlmah2+lzXo+YYUJupspn0kJHsz4NTYEG5PAZLSvsc5N1NPD46l9syW92Ahqu
         myfsF5RWjQFuKvmSW9itNZCQHPi5Iy1CoaduADQJdNIEr4UR+jVJRhhhB3N5/AewoPWK
         MJaMuPw/QwL8OXzBtdWK6/yRj9xBwa/Ln3py9LvXkX8TwXGDxBNXX/u+qsgTy5Blmlow
         rAex3b/WTEsjwxg3oyjoWYrIvQgBAMlNWdynMoXApFGpZZGLxbtRFDUeGqgBLJCqmiFW
         1JaQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:date:cc:to:from:subject:message-id
         :dkim-signature;
        bh=F5KnvpeYoc+dj4HbP6AN5NHLZk/zjKPq5eDkZkfZmD4=;
        b=LjTW6emkImtsur3/b8xcml6qgvLnlKlTr7Suisb8YbklSJaOVV2B8yMc2u5tcLmgof
         McQuEQMDh62hKWSshpkwT39vHpXGFBG7YjC0ngid9GH2A4lbOlOm57NDocdL57dyOUbp
         a5JH7U+ROjqSFS9BYGYUgFMEnSXRCAF5GTGZ11OSmKAJdxetezLGI2EmIAqEVtUIe2Ye
         mlkn2k55WGolmMUjuiDrWfiyPxumfuYYMa7s2p6x/3UxHvGfB3f5tEXSr0Mw46T0ojW8
         oIPi0ZWiuLna1IU4Lyy12AXU/LvtcSd6rdgwY0zwbqLa4KvaJyEVzTgw75oqLcrTF4yD
         VJTA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@ozlabs.org header.s=201707 header.b=iIVVHUQA;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ozlabs.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id v12si7354600ejj.109.2020.05.18.18.00.55;
        Mon, 18 May 2020 18:01:18 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@ozlabs.org header.s=201707 header.b=iIVVHUQA;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ozlabs.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727777AbgESA7a (ORCPT <rfc822;gasparwang.pro@gmail.com>
        + 99 others); Mon, 18 May 2020 20:59:30 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43456 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726696AbgESA73 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 18 May 2020 20:59:29 -0400
Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79387C061A0C;
        Mon, 18 May 2020 17:59:29 -0700 (PDT)
Received: from authenticated.ozlabs.org (localhost [127.0.0.1])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.ozlabs.org (Postfix) with ESMTPSA id 49QyFn2C35z9sT3;
        Tue, 19 May 2020 10:59:25 +1000 (AEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707;
        t=1589849966; bh=8/+JurzWor9GOkMEO6UBnJlAsXzwZLYg4x/TZn37qos=;
        h=Subject:From:To:Cc:Date:In-Reply-To:References:From;
        b=iIVVHUQASagv59C+VIQOnQtpogsxpFdYvze4yvfpBcmwuNCyaevLKzU9l2sIp0ilw
         +DYckKCW1ryryi5bRywI8FSOStoP5rWY1J9s9Ts4y7BqkJlZoDorFB3x2KPXE9Es3b
         0JxJQXpDh8S/Ce+oL/DjZ2jkta34Dv6kCHqqix+yWfD8flS0vD8QQDt0ikHXmU6NNj
         gzOyPPDAvx0aRDJZpE5PwnF3W5N1fpOW1oOpAuzeKOBJbh3muK4kjcFquhKXzsmGuK
         Xfs/D5kHCefQ26xWcxTgb0a+WrZzXmdb5tssO2YA/U15uSeIf2Q222xIsAAGrZrDY8
         0uT1DOQn/49bg==
Message-ID: <f23cf92ee3639e0112e67051009651a88dd0b53b.camel@ozlabs.org>
Subject: Re: [PATCH] net: bmac: Fix stack corruption panic in bmac_probe()
From:   Jeremy Kerr <jk@ozlabs.org>
To:     userm57@yahoo.com, Finn Thain <fthain@telegraphics.com.au>,
        "David S. Miller" <davem@davemloft.net>
Cc:     Paul Mackerras <paulus@samba.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date:   Tue, 19 May 2020 08:59:24 +0800
In-Reply-To: <05aa357d-4b9c-4038-c0f4-1bfea613c6e4@yahoo.com>
References: <769e9041942802d0e9ff272c12ee359a04b84a90.1589761211.git.fthain@telegraphics.com.au>
         <43d5717e7157fd300fd5bf893e517bbdf65c36f4.camel@ozlabs.org>
         <05aa357d-4b9c-4038-c0f4-1bfea613c6e4@yahoo.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Stan,

> The new kernel compiled and booted with no errors, with these
> STACKPROTECTOR options in .config (the last two revealed the bug):
> 
> CONFIG_HAVE_STACKPROTECTOR=y
> CONFIG_CC_HAS_STACKPROTECTOR_NONE=y
> CONFIG_STACKPROTECTOR=y
> CONFIG_STACKPROTECTOR_STRONG=y

Brilliant, thanks for testing. I'll send a standalone patch to netdev.

Cheers,


Jeremy