Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp3108065ybk; Mon, 18 May 2020 18:15:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyyp5cC9fhYy6LmCFtcquksE7YtJ8X2fQT8WHrfTq8hCLaStysT85pQqdbMcsAgb/uwryY1 X-Received: by 2002:a50:b286:: with SMTP id p6mr16201351edd.350.1589850939227; Mon, 18 May 2020 18:15:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589850939; cv=none; d=google.com; s=arc-20160816; b=mXbtpv/V7ufzOwElkmJs8OhSK74ztBeSNNnWyuB52Yonf/Tm8m/LDTeKib/fz5ZQ2w 1kWLoK482YNfwCqOMZ0pJ6f6I3NzgUs8pqq6yHlRhtw95CRoImnnsLyf0F2oifxwku2Q uppbyf/jaeH76UeM9lFggYssN7aYtZooC8qdbVbsyeqyle1UGU+OWRotHRLC5CvSMtHU qo2OuPAiXuTQw5Bx1RQzCiap0scGCED4Oq/g4cpAQFCNK8XTJd+qlSfmk7+N6by34d10 ++gUyFTZFuZpM9ZlueuSM82HyCTRSojP3CuneN+InDJwYeioTdudwyjqVFFG/DrJSwEK 64rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=Bv7V1JXvULne3uWlxbZYNnqdATFaPW3Bx4exLwj8sGo=; b=j7p22vAAzoa6BwnhPSRA81MfYipVxQDLOGocTblbFxUMa7bitSejaxw8iigZW0R32y izy+MD/MDaX2pSho8VWcLp9SawHiw58/ITWLhdIQvnwiW6uqvx/V/qmQxQtTH+9aCrX0 eWn/ZOhqbf5ZTjfslXjTsUt8+IZG1kvJ44r74as7nQUKWx38ztERWwqT151HoGZk2A72 Buc+OGGphPb5KLEAXyHMihgwNocEIEyNHlQzQqpAGDAZ31r/uvNEo+D6BNggoqQqYWyZ ZV12NsNC5amswArA3hsjhO3GW48zok/W8IbjFdECVdOw81aQlKNM7JD1hZNU9H4r/LFK zB/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 11si3426046edv.42.2020.05.18.18.15.16; Mon, 18 May 2020 18:15:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728085AbgESBNz (ORCPT + 99 others); Mon, 18 May 2020 21:13:55 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:56486 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726628AbgESBNz (ORCPT ); Mon, 18 May 2020 21:13:55 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id D4B96CBE31790CD136B6; Tue, 19 May 2020 09:13:48 +0800 (CST) Received: from [127.0.0.1] (10.67.102.197) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Tue, 19 May 2020 09:13:42 +0800 Subject: Re: [PATCH v3 0/4] cleaning up the sysctls table (hung_task watchdog) To: Luis Chamberlain CC: , , , , , , , , , , , , , , , References: <1589774397-42485-1-git-send-email-nixiaoming@huawei.com> <20200518171602.GK11244@42.do-not-panic.com> From: Xiaoming Ni Message-ID: Date: Tue, 19 May 2020 09:13:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20200518171602.GK11244@42.do-not-panic.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.102.197] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/5/19 1:16, Luis Chamberlain wrote: > On Mon, May 18, 2020 at 11:59:53AM +0800, Xiaoming Ni wrote: >> Kernel/sysctl.c contains more than 190 interface files, and there are a >> large number of config macro controls. When modifying the sysctl >> interface directly in kernel/sysctl.c, conflicts are very easy to occur. >> E.g: https://lkml.org/lkml/2020/5/10/413. > > FWIW un the future please avoid using lkmk.org and instead use > https://lkml.kernel.org/r/ for references. > >> Use register_sysctl() to register the sysctl interface to avoid >> merge conflicts when different features modify sysctl.c at the same time. >> >> So consider cleaning up the sysctls table, details are in: >> https://kernelnewbies.org/KernelProjects/proc >> https://lkml.org/lkml/2020/5/13/990 >> >> The current patch set extracts register_sysctl_init and some sysctl_vals >> variables, and clears the interface of hung_task and watchdog in sysctl.c. >> >> The current patch set is based on commit b9bbe6ed63b2b9 ("Linux 5.7-rc6"), >> which conflicts with the latest branch of linux-next: >> 9b4caf6941fc41d ("kernel / hung_task.c: introduce sysctl to print >> all traces when a hung task is detected") >> >> Should I modify to make patch based on the "linux-next" branch to avoid >> conflicts, or other branches? > > If you can do that, that would be appreciated. I have a sysctl fs cleanup > stuff, so I can take your patches, and put my work ont op of yours and > then send this to Andrew once done. > > Luis > Ok, I will redo the v4 version based on the linux-next branch as soon as possible I want to continue to participate in the subsequent sysctl cleanup, how to push the subsequent cleanup patch to your series, and minimize conflict Thanks Xiaoming Ni