Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp3168344ybk; Mon, 18 May 2020 20:19:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzseX8lzIV3+SogRmK5QHMohk+osXKCwQLjwn/5gE5kav/e+8q1tFzvwnMkjbf/gIGp/jJ1 X-Received: by 2002:a50:8d57:: with SMTP id t23mr16727180edt.168.1589858371001; Mon, 18 May 2020 20:19:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589858370; cv=none; d=google.com; s=arc-20160816; b=rDSKZJCJ5Ra+1CFWrwo6Sz9ewb1+XDeSeJ0ntlmUJ22NsSdIWORcWgmoIl8uXKeLXm CBiU2AzNRlnMLK5noIFDjqAlflL1LHCRY0AhX9udYI+uuysebPVPA39oOVirBZ6oyurj qFVCOx43h+1L7OIvyDJw8gaEDldXpmLhejM0CnDHTfU93ymhuSBfnGu+m/75bnJ1w4L0 1NBhQqufv9WOl4MbbTsj1uJN9ofxJ+E/iEZhHpaTaGrQqKjiyyXOcc+ZzWBBtqIflJGb vW3DBVZrJzh2OO3wS+GOsGpjxYGMyJLJ2c7XL3Elj/xzzKiKtaI+WLHMTqmuMND8QNFd 5asQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=mm8oKvJmrqKP4DxkkDs9rs2bKDOHipdqaHmFZkXMGWE=; b=Xd6EB5CC7DFb8d3uw4UMamzwjOdeccProEaPQ5Q06v3PUd8lfoOIcpqrT4kvUFyu60 MpCbDQG9vncGq+8fV4PTxtmQq9gsLcFRXJ05C6/QBbl+MzJxEcfAA0UaXte93bT3BnzE Z/zvnAPLKOZrzYiVUib3F/bRX4Hv/hqwC6zhDhtxFMbEQrlg5NfCLxNgzv9hID+m8TyY f7uhnnU+AUw+Wbw6bo++XytPeDmamLR/uduQ9E2WibtrsSen/AXW9OoI2roVSCjpmOo5 lQSuQmOixdjsorxATlig/gtdpOQWerDBhEbAZbvZlq1pYitU5BOGzpToYBU7aTZk+r1+ 1y/w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u13si7125102ejg.291.2020.05.18.20.19.07; Mon, 18 May 2020 20:19:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726821AbgESDRn (ORCPT + 99 others); Mon, 18 May 2020 23:17:43 -0400 Received: from mga14.intel.com ([192.55.52.115]:30695 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726407AbgESDRn (ORCPT ); Mon, 18 May 2020 23:17:43 -0400 IronPort-SDR: G4E1zqAl3h2vOcSkHkdf7rhr9BSiCFXNHMl3WOqt0vpf1mPKHNO9URT/UWzY8gW0zpdUvcmyE5 rmr6Pq4d+nhw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2020 20:17:42 -0700 IronPort-SDR: nN+30u534C5x/E+ZsUfd0cyKu0tepiTkuKjyZkLIrR2mbR35brhx0CUlf5qxAkGWvJTUFWr1B3 ul4cIaeKgUWQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,408,1583222400"; d="scan'208";a="264165179" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.21]) by orsmga003.jf.intel.com with ESMTP; 18 May 2020 20:17:42 -0700 Received: by tassilo.localdomain (Postfix, from userid 1000) id 429FA301B7F; Mon, 18 May 2020 20:17:42 -0700 (PDT) Date: Mon, 18 May 2020 20:17:42 -0700 From: Andi Kleen To: Bob Haarman Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Fangrui Song , Sami Tolvanen , stable@vger.kernel.org, Nathan Chancellor , Alistair Delva , Nick Desaulniers , x86@kernel.org, "H. Peter Anvin" , Masami Hiramatsu , Josh Poimboeuf , Vincenzo Frascino , Kyung Min Park , afzal mohammed , Peter Zijlstra , Kees Cook , Heiko Carstens , Dave Hansen , Baoquan He , Thomas Lendacky , Ross Zwisler , Arvind Sankar , Dmitry Safonov <0x7f454c46@gmail.com>, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] x86_64: fix jiffies ODR violation Message-ID: <20200519031742.GB499505@tassilo.jf.intel.com> References: <20200515180544.59824-1-inglorion@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200515180544.59824-1-inglorion@google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Instead, we can avoid the ODR violation by matching other arch's by > defining jiffies only by linker script. For -fno-semantic-interposition > + Full LTO, there is no longer a global definition of jiffies for the > compiler to produce a local symbol which the linker script won't ensure > aliases to jiffies_64. I guess it was an historical accident. Reviewed-by: Andi Kleen