Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp3175603ybk; Mon, 18 May 2020 20:33:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJykzKb1cWHLjj4c46mtOw+Y3CmOs0sZHzc04kkrerRYLuXlflWpqF2DfwaHP8vEDEqFjHpV X-Received: by 2002:a50:b082:: with SMTP id j2mr10267918edd.201.1589859199496; Mon, 18 May 2020 20:33:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589859199; cv=none; d=google.com; s=arc-20160816; b=DR72fxByPeRDC48e4U46xZYITn6e+bkrGT1GT8kWZ0NbpaRzXfxKNMXveqB6veTtYI ymJI3Ca78J4DmA6xZSbaHMjhTECHEVcmFUDl5PbHzLYqfHtbAOtoF3ek2E7C8x/B1wtk tOH+89vur26Q+m3r3iXbe8T+I/IZ9ZEHstdmR3qAnvkPJIVYNlI5cUd+PZ6E5C4VQWgU hEKdgJalL2/MlPuo7v8varnyQegwswgky50EuWCeZ4XG0722870NKUjTGlkWxoo25EQt PDEoYKuQG3ezkPg6Y46ip3UkbaHV3rlU5ASE3VgbBvneTRg1zPT+7+lVp39OYXPZSZ8t hxdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=bXNtBD7OQ1HcBWaUVd7Skg9PfLvp6zTzsTbu2V/e6Kc=; b=NBW452I6pthottyxldHq52aMwQ9/P2PRFaU3AQ+wHSAsdtT26tMOHxF+7408k2DIIe WOv1n8E6eG0ngaOeTXXex7d/VhdMYKsAAEArX2Q+9GRSniFcZ2INBZ+4iCVCvFs8ktZ0 yPgAhlY8OykWEQKsptPgPz5D+CMGRt33HfxIrHbmt/j7XU/u/HJgxdKYMIi3NhIIDNe+ +TVevmbnoJwDMN+sWNiyGMpwCiT0/UoOYGD2aMb6tglEsyg+8a5BfI+/DS+vbHZlS/eM PH34aHvcyrm2aY2PSXfBQMhJxXYR3dSiq06/4D+y4qAPWf46mc/qHaopliMEWfjRKncK atmA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d31si2869579edd.95.2020.05.18.20.32.57; Mon, 18 May 2020 20:33:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728290AbgESDb1 (ORCPT + 99 others); Mon, 18 May 2020 23:31:27 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:4861 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728258AbgESDbY (ORCPT ); Mon, 18 May 2020 23:31:24 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id D25ACEF918C424D665AA; Tue, 19 May 2020 11:31:19 +0800 (CST) Received: from use12-sp2.huawei.com (10.67.189.174) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.487.0; Tue, 19 May 2020 11:31:13 +0800 From: Xiaoming Ni To: , , , , , , , , , , , , , , , , , , , , , CC: , Subject: [PATCH v4 0/4] cleaning up the sysctls table (hung_task watchdog) Date: Tue, 19 May 2020 11:31:07 +0800 Message-ID: <1589859071-25898-1-git-send-email-nixiaoming@huawei.com> X-Mailer: git-send-email 1.8.5.6 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.189.174] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kernel/sysctl.c contains more than 190 interface files, and there are a large number of config macro controls. When modifying the sysctl interface directly in kernel/sysctl.c, conflicts are very easy to occur. E.g: https://lore.kernel.org/lkml/99095805-8cbe-d140-e2f1-0c5a3e84d7e7@huawei.com/ Use register_sysctl() to register the sysctl interface to avoid merge conflicts when different features modify sysctl.c at the same time. So consider cleaning up the sysctls table, details are in: https://kernelnewbies.org/KernelProjects/proc https://lore.kernel.org/lkml/20200513141421.GP11244@42.do-not-panic.com/#t The current patch set extracts register_sysctl_init and some sysctl_vals variables, and clears the interface of hung_task and watchdog in sysctl.c. The current patch set is based on linux-next, commit 72bc15d0018ebfbc9 ("Add linux-next specific files for 20200518"). changes in v4: Handle the conflict with the commit d4ee116819ed714f ("kernel/hung_task.c: introduce sysctl to print all traces when a hung task is detected"), move the sysctl interface hung_task_all_cpu_backtrace to hung_task.c. V3: https://lore.kernel.org/lkml/1589774397-42485-1-git-send-email-nixiaoming@huawei.com/ base on commit b9bbe6ed63b2b9 ("Linux 5.7-rc6") changes in v3: 1. make hung_task_timeout_max to be const 2. fix build warning: kernel/watchdog.c:779:14: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] .extra2 = &sixty, ^ V2: https://lore.kernel.org/lkml/1589619315-65827-1-git-send-email-nixiaoming@huawei.com/ changes in v2: 1. Adjusted the order of patches, first do public function extraction, then do feature code movement 2. Move hung_task sysctl to hung_task.c instead of adding new file 3. Extract multiple common variables instead of only neg_one, and keep the order of member values in sysctl_vals 4. Add const modification to the variable sixty in watchdog sysctl V1: https://lore.kernel.org/lkml/1589517224-123928-1-git-send-email-nixiaoming@huawei.com/ Xiaoming Ni (4): sysctl: Add register_sysctl_init() interface sysctl: Move some boundary constants form sysctl.c to sysctl_vals hung_task: Move hung_task sysctl interface to hung_task.c watchdog: move watchdog sysctl interface to watchdog.c fs/proc/proc_sysctl.c | 2 +- include/linux/sched/sysctl.h | 14 +-- include/linux/sysctl.h | 13 ++- kernel/hung_task.c | 77 +++++++++++++++- kernel/sysctl.c | 214 +++++++------------------------------------ kernel/watchdog.c | 101 ++++++++++++++++++++ 6 files changed, 224 insertions(+), 197 deletions(-) -- 1.8.5.6