Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp3270056ybk; Mon, 18 May 2020 23:51:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJysAjUjeZ0/92mlr2JUm+hDQDtcg0Hh9C9X+MaavocKVqhLz8M8l4fyinO7AqORCGaSzTxC X-Received: by 2002:a17:906:f85:: with SMTP id q5mr11592929ejj.344.1589871108959; Mon, 18 May 2020 23:51:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589871108; cv=none; d=google.com; s=arc-20160816; b=GeF85z5vhCPBZnZMzgQqsE+Gs+1bnlaPirwoGE1GfTW+YOg37bKkPGijKPTb63p/JK 3KExefRMK7wJvm/nKJ8s4oOnEVksCh8gW5nabM5Is8zl8SjZKx4dxWKH7hOu1XpcGIGP fKQvWvp3+1kPBUFFaHnkn2fTPu5EZ+aTG3oruSmT6qyBQ04nd5IXL9guuD6HUrKLGQ/T n5dl7OwohuqSWtX9O70UEy4Y7SUwFuhyTzhbSlQNUUfT4h4bqaowBPYMu7U96Q73SZAu WfsFagkeQkx4lk1bHHv9LEmJz05LbKoFDFqT7MapCNwm+SONE3RdiqmyQcZPnsmizgaK gN1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature:dkim-filter; bh=pQ3wORf2jqZ8g7HnW11X9V+drcvq8Y92kOSzANz/7lE=; b=0JbTs7nVPIGElgqEffPL63A99dGPVuBRUEn2l4oAafkff/OpiaF73mi/11GOpq1xQY HizrSJFY1nPBXunpSPv3L+Bm0HgmmnpNhZ0U/KzHihBpg9AxXCGpHZwgRWkS16wuT0Ro zgRNMAoLuEfqkaNrjjQzPL3MdHk4S1b/UNugxxbDBIqWuW5GnKiptKoXRshNbQ7lvzSF Styvym/IO0Tqz9hNzZyNN0T35u/v8rjpR2zP7vs2tih88KREl6Pz4jTesTRnns0DK08w nc0HGQYdjmKv7nIat2Dqoi8+NIoZrFCemhF7TqsgX7OgzFowQ5+B1PpN9PqW9WSHJBzU ptNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@perex.cz header.s=default header.b=UUFWnT71; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=perex.cz Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l4si8018249ejr.97.2020.05.18.23.51.25; Mon, 18 May 2020 23:51:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@perex.cz header.s=default header.b=UUFWnT71; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=perex.cz Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728390AbgESGrX (ORCPT + 99 others); Tue, 19 May 2020 02:47:23 -0400 Received: from mail1.perex.cz ([77.48.224.245]:41904 "EHLO mail1.perex.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727077AbgESGrW (ORCPT ); Tue, 19 May 2020 02:47:22 -0400 Received: from mail1.perex.cz (localhost [127.0.0.1]) by smtp1.perex.cz (Perex's E-mail Delivery System) with ESMTP id CDFD4A003F; Tue, 19 May 2020 08:47:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.perex.cz CDFD4A003F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=perex.cz; s=default; t=1589870840; bh=pQ3wORf2jqZ8g7HnW11X9V+drcvq8Y92kOSzANz/7lE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=UUFWnT71rm2ZlIIi7q0jNjd4TbRrAyPj0W4xsI3tetb06R7jeZFyaYvzgfPle9BC6 JYIaqJpXXJ9HgcN8sW9IvvvRIfJ/AyKatNPvUaaonpo+nDbabgIWwYy+tFWuxIzSm9 KKsEJxDDOPBg2cU1xyAmr95m/Bz0FJmSr0pz2yv4= Received: from p50.perex-int.cz (unknown [192.168.100.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: perex) by mail1.perex.cz (Perex's E-mail Delivery System) with ESMTPSA; Tue, 19 May 2020 08:47:02 +0200 (CEST) Subject: Re: [PATCH v2 0/5] soundwire: bus_type: add sdw_master_device support To: Bard Liao , alsa-devel@alsa-project.org, vkoul@kernel.org Cc: pierre-louis.bossart@linux.intel.com, vinod.koul@linaro.org, tiwai@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, ranjani.sridharan@linux.intel.com, hui.wang@canonical.com, broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, mengdong.lin@intel.com, slawomir.blauciak@intel.com, sanyog.r.kale@intel.com, rander.wang@linux.intel.com, bard.liao@intel.com References: <20200518174322.31561-1-yung-chuan.liao@linux.intel.com> From: Jaroslav Kysela Message-ID: Date: Tue, 19 May 2020 08:47:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200518174322.31561-1-yung-chuan.liao@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne 18. 05. 20 v 19:43 Bard Liao napsal(a): > This series adds sdw master devices support. > > changes in v2: > - Allocate sdw_master_device dynamically > - Use unique bus id as master id > - Keep checking parent devices > - Enable runtime_pm on Master device > > Bard Liao (2): > soundwire: bus: add unique bus id > soundwire: master: add runtime pm support > > Pierre-Louis Bossart (3): > soundwire: bus: rename sdw_bus_master_add/delete, add arguments > soundwire: bus_type: introduce sdw_slave_type and sdw_master_type > soundwire: bus_type: add sdw_master_device support > > .../driver-api/soundwire/summary.rst | 7 +- > drivers/soundwire/Makefile | 2 +- > drivers/soundwire/bus.c | 47 ++++++++-- > drivers/soundwire/bus.h | 3 + > drivers/soundwire/bus_type.c | 19 ++-- > drivers/soundwire/intel.c | 9 +- > drivers/soundwire/master.c | 88 +++++++++++++++++++ > drivers/soundwire/qcom.c | 7 +- > drivers/soundwire/slave.c | 8 +- > include/linux/soundwire/sdw.h | 24 ++++- > include/linux/soundwire/sdw_type.h | 9 +- > 11 files changed, 191 insertions(+), 32 deletions(-) > create mode 100644 drivers/soundwire/master.c > The code looks really clean now. Thank you for your work. Acked-by: Jaroslav Kysela Jaroslav -- Jaroslav Kysela Linux Sound Maintainer; ALSA Project; Red Hat, Inc.