Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 19 May 2020 09:16:52 +0200
From:   Thibaut Sautereau <thibaut.sautereau@clip-os.org>
To:     Alexander Viro <viro@zeniv.linux.org.uk>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: NULL pointer dereference in coredump code
Message-ID: <20200519071652.GA924@clip-os.org>
References: <20200330083158.GA21845@clip-os.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200330083158.GA21845@clip-os.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Mar 30, 2020 at 10:31:59AM +0200, Thibaut Sautereau wrote:
> I hit a kernel NULL pointer dereference caused by the following call chain:
> 
> do_coredump()
>   file_start_write(cprm.file) # cprm.file is NULL
>     file_inode(file) # NULL ptr deref
> 
> The `ispipe` path is followed in do_coredump(), and:
>     # cat /proc/sys/kernel/core_pattern
>     |/usr/lib/systemd/systemd-coredump %P %u %g %s %t %c %h
> 
> It seems that cprm.file can be NULL after the call to the usermode
> helper, especially when setting CONFIG_STATIC_USERMODEHELPER=y and
> CONFIG_STATIC_USERMODEHELPER_PATH="", which is the case for me.
> 
> One may say it's a strange combination of configuration options but I
> think it should not crash the kernel anyway. As I don't know much about
> coredumps in general and this code, I don't know what's the best way to
> fix this issue in a clean and comprehensive way.
> 
> I attached the patch I used to temporarily work around this issue, if
> that can clarify anything.
> 
> Thanks,

For the record, this had previously been reported [1] and was eventually
fixed by 3740d93e3790 ("coredump: fix crash when umh is disabled").

[1] https://bugzilla.kernel.org/show_bug.cgi?id=199795

-- 
Thibaut Sautereau
CLIP OS developer