Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <cover.1589844108.git.reinette.chatre@intel.com> <a953992d99a1930703cba1362a3005d517c4cb33.1589844108.git.reinette.chatre@intel.com>
In-Reply-To: <a953992d99a1930703cba1362a3005d517c4cb33.1589844108.git.reinette.chatre@intel.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 19 May 2020 11:28:21 +0300
Message-ID: <CAHp75Vc_VA-2UNJh7epe+oQEiU3WBedomLbAVTD_L4_ocvt8Dw@mail.gmail.com>
Subject: Re: [PATCH V5 4/4] x86/resctrl: Use appropriate API for strings
 terminated by newline
To:     Reinette Chatre <reinette.chatre@intel.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Borislav Petkov <bp@alien8.de>,
        Tony Luck <tony.luck@intel.com>, kuo-lang.tseng@intel.com,
        ravi.v.shankar@intel.com, Ingo Molnar <mingo@redhat.com>,
        Babu Moger <babu.moger@amd.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, May 19, 2020 at 2:50 AM Reinette Chatre
<reinette.chatre@intel.com> wrote:

...

> +       ret = sysfs_match_string(rdt_mode_str, buf);
> +       if (ret < 0) {
> +               rdt_last_cmd_puts("Unknown or unsupported mode\n");
> +               ret = -EINVAL;
> +               goto out;
> +       }
> +
> +       user_m = ret;

> +       } else if (user_m == RDT_MODE_PSEUDO_LOCKED) {
>                 rdt_last_cmd_puts("Unknown or unsupported mode\n");
>                 ret = -EINVAL;
> +               goto out;
>         }

Can't we unify latter with a former like

  if (ret == RDT_MODE_PSEUDO_LOCKED)
    ret = -EINVAL;
  if (ret < 0) {
      rdt_last_cmd_puts("Unknown or unsupported mode\n");
      goto out;
  }

?

Or closer to initial like

  if (ret < 0 || ret == RDT_MODE_PSEUDO_LOCKED) {
    rdt_last_cmd_puts("Unknown or unsupported mode\n");
    ret = -EINVAL;
    goto out;
  }

-- 
With Best Regards,
Andy Shevchenko