Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <5a6de40ebbf0587f245fcff2636080977fda9d96.camel@kernel.crashing.org>
Subject: Re: [PATCH] net: bmac: Fix stack corruption panic in bmac_probe()
From:   Benjamin Herrenschmidt <benh@kernel.crashing.org>
To:     Jeremy Kerr <jk@ozlabs.org>, userm57@yahoo.com,
        Finn Thain <fthain@telegraphics.com.au>,
        "David S. Miller" <davem@davemloft.net>
Cc:     Paul Mackerras <paulus@samba.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Tue, 19 May 2020 19:19:25 +1000
In-Reply-To: <f23cf92ee3639e0112e67051009651a88dd0b53b.camel@ozlabs.org>
References: <769e9041942802d0e9ff272c12ee359a04b84a90.1589761211.git.fthain@telegraphics.com.au>
         <43d5717e7157fd300fd5bf893e517bbdf65c36f4.camel@ozlabs.org>
         <05aa357d-4b9c-4038-c0f4-1bfea613c6e4@yahoo.com>
         <f23cf92ee3639e0112e67051009651a88dd0b53b.camel@ozlabs.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 2020-05-19 at 08:59 +0800, Jeremy Kerr wrote:
> Hi Stan,
> 
> > The new kernel compiled and booted with no errors, with these
> > STACKPROTECTOR options in .config (the last two revealed the bug):
> > 
> > CONFIG_HAVE_STACKPROTECTOR=y
> > CONFIG_CC_HAS_STACKPROTECTOR_NONE=y
> > CONFIG_STACKPROTECTOR=y
> > CONFIG_STACKPROTECTOR_STRONG=y
> 
> Brilliant, thanks for testing. I'll send a standalone patch to
> netdev.

Nice catch :-) Lots of people used these machines for years without
noticing :-) .... Granted most people used newer generation stuff with
a gmac instead.

Cheers,
Ben.