Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp3349668ybk; Tue, 19 May 2020 02:24:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwk2cfzKnO3QqhHR2qQsC1a+RDLZoI00q52RmC7UTA7MyciPtb2n1Yr4tV8OE7a5zH7Cc3s X-Received: by 2002:a17:906:2b4f:: with SMTP id b15mr19004997ejg.64.1589880252706; Tue, 19 May 2020 02:24:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589880252; cv=none; d=google.com; s=arc-20160816; b=i6QWvImrGqt+guce4tyEcN+LNzfozzEGcOleOuJMMY10UcPe1Qcf8lfkgj9yBofAcF 4zL9zAC/e1boW9NevukZ7xBEhiY9ncWzrvgOMCCiYkLVGeG+u5CEQwcgiZBAz6IJ8Q0A o6zd9RMYDrJWeBOzK7TMLl6PI1/2shmEVM8hWKL1H32Roxm5fvp+kztte3zvzGNaNz81 6GjV+ovz35D/E+2n0Ehs8ufe7KW+SBdbPLdFNhAuxrLOqeL4fxgMTn1YytSW4WsH7Eb6 /w7zv7zUk1geLSdIISfjKzbCf5sZCcsyfXGcDbEHPBjVU8iCppDApjs2AeU34eDEqf4T NccA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=WUlOZRkHcEPGNUujf2HsZ86UwRtUl0QK1GR0GzdVjyk=; b=ECyb9eYVtEF6GUAwbsI6oTTbewI4InYX68xShA0IC4IeqCcw/hBHenq/UMrGRsVLvH lL9mvxDwbVMg6Shgmd5R35x0DhgEhD2DrUWWnW1tplbkoN4z8FdmKQT1bJ7wIuoK5Zlw LzRUwGJgeyK/tmbT9SWXmomjqe6og5OUvlGR60eg/l1tnwiHoMnPU2BrfxBHoC0TFMA/ r7J/mc3ZrvcFmAsXt6CSGbclK4H9Ew7SG4pTfNWA5Tc0YQm+nb3uPBK95sgZFbEBqJRx J74uny7+tA32IaLrsdwVuPK5S8v+oha/nYA154ZTbFqbbANfKxkfGt8za5vyUjJgtEYG 819g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i60si8371333edd.0.2020.05.19.02.23.49; Tue, 19 May 2020 02:24:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728027AbgESJWN (ORCPT + 99 others); Tue, 19 May 2020 05:22:13 -0400 Received: from mga14.intel.com ([192.55.52.115]:39906 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726358AbgESJWM (ORCPT ); Tue, 19 May 2020 05:22:12 -0400 IronPort-SDR: a+Zo8fZcTo/WVeqQdOd9OmpMIERmZq7unbZhy01Od9lGvy0+rhfpKDG5IsPqr41fDybxBSCCTc Lr0niFdadg6w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2020 02:22:11 -0700 IronPort-SDR: 8j68tHuc1QcJNBPZx5GrAM4yqAJBRFFpuCf4oXE/synt8I1biu4iTX9PLv8aTXqXp5xPWJAWqC APxMp1AlF1Zg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,409,1583222400"; d="scan'208";a="373669435" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001.fm.intel.com with ESMTP; 19 May 2020 02:22:09 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jayRw-007bhX-1i; Tue, 19 May 2020 12:22:12 +0300 Date: Tue, 19 May 2020 12:22:12 +0300 From: Andy Shevchenko To: Jonathan Albrieux Cc: linux-kernel@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Greg Kroah-Hartman , Hartmut Knaack , Jonathan Cameron , Lars-Peter Clausen , Linus Walleij , "open list:IIO SUBSYSTEM AND DRIVERS" , Peter Meerwald-Stadler , Thomas Gleixner Subject: Re: [PATCH v2 0/3] iio: magnetometer: ak8975: Add gpio reset support Message-ID: <20200519092212.GT1634618@smile.fi.intel.com> References: <20200519065749.4624-1-jonathan.albrieux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200519065749.4624-1-jonathan.albrieux@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 19, 2020 at 08:57:40AM +0200, Jonathan Albrieux wrote: > Convert documentation from txt format to yaml. Add documentation about > reset-gpio. Trailing white space (though it doesn't matter here, in cover letter). > Deassert reset on ak8975_power_on, assert reset on ak8975_power_off. > > Without reset's deassertion during ak8975_power_on, driver's probe fails > on ak8975_who_i_am while checking for device identity for AK09911 chip > > AK09911 has an active low reset gpio to handle register's reset. > AK09911 datasheed says that, if not used, reset pin should be connected > to VID. This patch emulates this situation I dunno if it's your first submission to Linux kernel project or other OSS, but here you missed a changelog. Rule of thumb is to provide a summary of the changes done in the history of the evolution of a patch series. -- With Best Regards, Andy Shevchenko