Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 19 May 2020 11:34:33 +0200
From:   Robert Richter <rrichter@marvell.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     "Luck, Tony" <tony.luck@intel.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        James Morse <james.morse@arm.com>,
        Aristeu Rozanski <aris@redhat.com>,
        Matthias Brugger <mbrugger@suse.com>,
        <linux-edac@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 06/10] EDAC/ghes: Remove local variable rdr_mask in
 ghes_edac_dmidecode()
Message-ID: <20200519093433.kl72ejffhecne2zu@rric.localdomain>
References: <20200422115814.22205-1-rrichter@marvell.com>
 <20200422115814.22205-7-rrichter@marvell.com>
 <20200427070802.GA11036@zn.tnic>
 <20200427172408.GA13177@agluck-desk2.amr.corp.intel.com>
 <20200427173402.GH11036@zn.tnic>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200427173402.GH11036@zn.tnic>
User-Agent: NeoMutt/20170113 (1.7.2)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from rric.localdomain (31.208.96.227) by HE1PR0202CA0032.eurprd02.prod.outlook.com (2603:10a6:3:e4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.25 via Frontend Transport; Tue, 19 May 2020 09:34:40 +0000
X-Originating-IP: [31.208.96.227]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 78b71b85-2c5d-40fc-f8ae-08d7fbd7dbf4
X-MS-TrafficTypeDiagnostic: BYAPR18MB2998:
X-Microsoft-Antispam-PRVS: <BYAPR18MB299894066978122061D97CF2D9B90@BYAPR18MB2998.namprd18.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4714;
X-Forefront-PRVS: 040866B734
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 98pCAWinBw5sl8EsNugvF2tGZZmN2fwtQGWdHAwivBE7vGWkvKPC2NSZTkapoi/nqA5bXcnrBcWfccSpeU9nGZNBQJie8YH1M2QHsdDo37E09kZAWMxg/WFMaZycfN6Z0gHLsA4aB109nfuf+FsCQKmoLNbECvpvwoBlNQt5OIdMDrPKjqyXdKQ+hTO2LdiRJeFroDwtfnO4ClSqwXY4VZZNsZ/mKTmZfWUWHYLnrvCQGFLz49JgHY26u2TrIluuYeRrZNHAbDUjbbv1Na1ABMbkBkcBOdJ1SO5wR+nslU09EtvV5SeqPRlcs4SHdDBbTXXplUE3FSu5J0MLchHP7yXyaBvHVYh788+LmrkR+LoRi4G5qfw7sUTZ/L0i2GtMg968/6tcBdCy8++wfk7mC5xnW/K1k04tUfftRQz1rDvYcnBB40+Dlbcnx72VEz/I
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR18MB2661.namprd18.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(376002)(396003)(366004)(136003)(39860400002)(956004)(26005)(16526019)(5660300002)(8936002)(4744005)(54906003)(316002)(66946007)(86362001)(1076003)(66476007)(66556008)(186003)(478600001)(53546011)(6666004)(4326008)(6506007)(55016002)(8676002)(2906002)(6916009)(9686003)(52116002)(7696005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: 3C2MjKm7Ao3gTXYpJXrllnRqjOkR+DqG6HQI4u9CdyEPNlsyW1Wg4vztXbq/lAj+ptfa+o8KUhWcFiB/O1Xt2QJ5w+UDHzNqOLiL2rhEFOE7ffQ7sZZ9+H+IXqbdqEC5JiiTmwfJDnzLeOM2ihGiQNjWKh/einCCCrilUTe9cjPIUMRwQ1yl4N1t//Io+nsHPb1WHtX2wodhCdTjdd8UsDmlnsY4+6i3AUTyZQJj7kfsLkeokt99ams0L4PClawP5NkLBJswhDzQcjdPLDE2igSHiQdjnqR35UuvjR7PVnc25Ome9CZoSNh2/s3BnNnlDc7kPyNyFUQXsc0c8+4ROqtnyAvmFLYaNFZuz6+OcSDUnsVvk4D9xBNf55tOJIjJeSgNmN0ZCxbIV75Jg0w5NlISflLM66H8yFJbpuAc5CtFccibAsDEuxcvJ/EzEM/G+VEsKhxigV1p0KXBnp9haGRz6N1KkZSH5h9ww2id2pw=
X-MS-Exchange-CrossTenant-Network-Message-Id: 78b71b85-2c5d-40fc-f8ae-08d7fbd7dbf4
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2020 09:34:42.6397
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XC07fnFeAI+VW1ABJQXw5FJXtj/gV5vJDPEJxIQu82sg1wUzRiDF+c2hPEtsnsXJ20q3wS8QBFDepPZf7ebCjA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2998
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.676
 definitions=2020-05-19_03:2020-05-19,2020-05-19 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 27.04.20 19:34:02, Borislav Petkov wrote:
> On Mon, Apr 27, 2020 at 10:24:08AM -0700, Luck, Tony wrote:
> > That isn't the same. The previous version checked that BOTH bits
> > 7 and 13 were set. Your version checks for either bit.
> 
> Whoops, I'm confused again. ;-\
> 
> > Looks like the original with the local variable was checking for both
> > bits set.
> 
> Yeah, let's leave it as it is. I prefer the rdr_mask thing.

I am dropping this patch from the series.

Thanks,

-Robert