Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 19 May 2020 11:35:08 +0200
From:   Robert Richter <rrichter@marvell.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Tony Luck <tony.luck@intel.com>,
        James Morse <james.morse@arm.com>,
        Aristeu Rozanski <aris@redhat.com>,
        Matthias Brugger <mbrugger@suse.com>,
        <linux-edac@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 07/10] EDAC/ghes: Cleanup struct ghes_edac_dimm_fill,
 rename it to ghes_dimm_fill
Message-ID: <20200519093508.towjo7ryoecaxb7h@rric.localdomain>
References: <20200422115814.22205-1-rrichter@marvell.com>
 <20200422115814.22205-8-rrichter@marvell.com>
 <20200427135923.GF11036@zn.tnic>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200427135923.GF11036@zn.tnic>
User-Agent: NeoMutt/20170113 (1.7.2)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from rric.localdomain (31.208.96.227) by HE1PR0202CA0023.eurprd02.prod.outlook.com (2603:10a6:3:8c::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.25 via Frontend Transport; Tue, 19 May 2020 09:35:16 +0000
X-Originating-IP: [31.208.96.227]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 054b35ff-920a-45a3-2eed-08d7fbd7f16a
X-MS-TrafficTypeDiagnostic: BYAPR18MB2534:
X-Microsoft-Antispam-PRVS: <BYAPR18MB253490AE9B01D5DDFAA73333D9B90@BYAPR18MB2534.namprd18.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:901;
X-Forefront-PRVS: 040866B734
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: KblXvX+VDJcA/zPqagY/+C5eccXUYJ3EM+1kl/CToJ6Hx06TEY5QwUz7ZaZccOpOP3M+9ZfTn/X9yZraNH+7Ugus39cy4w+iyKpOq1nyVj1DwuuMJWb5JX6V4o8M0g2yRf+/vEqMuodfbv4jv28W1Ap+NeKWbgBDZm6mPN38IjVekc0sejAmx+UJwZnoCoSSZgBLQGaPb12Jqg/GsOKtsXu1HuQctu/e1ksG+nqfSfKUfJI5zFMLiK+gFuZgVoeO7rC4vL3vooszE9EwklWXbr6vlqOxV6N8qsji2ly52Zx5ASIjO7CyCJz4ejpxNoYfrnUP+5HFgs5ffPtBRiieiKthSe9SdpPyj8FAoDlZly5lLBBQpRoYeKewpezw/9GF4mAWotw4Vi9JyKj+bhyZS3wvaD20A0T21n8c6b2mhQZZnZ9skY0RtB/7a8pZoO7W
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR18MB2661.namprd18.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(376002)(366004)(346002)(396003)(39860400002)(54906003)(316002)(956004)(26005)(186003)(16526019)(53546011)(6666004)(6506007)(1076003)(4744005)(66946007)(66556008)(66476007)(2906002)(52116002)(7696005)(86362001)(8936002)(8676002)(4326008)(55016002)(9686003)(6916009)(5660300002)(478600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: G7kYoRMOMUfe56ga9FRDPyE0RXmopcZpTqR7xl32LmmrOohGAt2fMCLvpIm9NIxQmuRxzK2NmuCMd+fbNMucQS1stPGBD55qN7OADOcBPMZ4TMKG5o7HkYoqSZn9GgDJlw00aURqmXuCHcBquYaK2ttCoaPjpKTez2mG2+qXJ0HkPTixBQx7irT0pb++rGIgE0/zjQcPkGLqot4/ZAd6zq8Dl3kVvAiSArVmjA0yh1vxv5O2f98sdmRnZWwUiY+FGwj1Euw/E8ppUNS4JY2nTQJlQk6zXVlbFFL6Y3rng7rytyygcd2LYvqoTriAU9tWq2u7lPW/qTbfwpEruMAm5D8RxaIkDHNycuzlpG9M0NFZGyEB7aa2qbwtJ+cR3irArVAfF6PdRSfd0u2AGz4Vp8qV5X1cqA7WIX1ulDU8s6qOgbGq3q0QOrAcYYiZz36auNAwfFaWeZwJpJz2OfTdCIR5JSsbeiKwWVeUZjQ3So4=
X-MS-Exchange-CrossTenant-Network-Message-Id: 054b35ff-920a-45a3-2eed-08d7fbd7f16a
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2020 09:35:18.8519
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Bk3qcu6VcWbaFNvztM6VJffOd7EXyD+AEe6ueYngf13tpvtv+WfC2CEvTkayfBXHzZMHLULbNBmAOQJCL6BJVg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2534
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.676
 definitions=2020-05-19_03:2020-05-19,2020-05-19 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 27.04.20 16:00:43, Borislav Petkov wrote:
> On Wed, Apr 22, 2020 at 01:58:11PM +0200, Robert Richter wrote:
> > The struct is used to store temporary data for the dmidecode callback.
> > Clean this up a bit:
> > 
> >  1) Rename member count to index since this is what it is used for.
> > 
> >  2) Move code close to ghes_edac_dmidecode() where it is used.
> > 
> >  3) While at it, use edac_get_dimm_by_index().
> > 
> > Signed-off-by: Robert Richter <rrichter@marvell.com>
> > ---
> >  drivers/edac/ghes_edac.c | 24 ++++++++++++------------
> >  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> Ok except the commit title is wrong. And yes, pls keep it "dimm_fill" -
> short and sweet and without yet another "ghes" in the name. :)

Fixed the title.

Thanks,

-Robert