Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp3377976ybk; Tue, 19 May 2020 03:11:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZIMMrswJdkFEzVCuDu26ttbT+25VaEkaBGkgnZSWn+bMYTGoe9f5FWusmcBwE9hw4lOsy X-Received: by 2002:a17:907:438e:: with SMTP id oj22mr18830287ejb.195.1589883113831; Tue, 19 May 2020 03:11:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589883113; cv=none; d=google.com; s=arc-20160816; b=QyNHAiArlC7IJeLJZx3vzU+To4gSXZ2Bcr7HNs81AFNEO4NF/56DBwIKNOhVL1/ZSH cyHN6SHFMWOnQch+VAMT8ao9n7k1m94ID9deLj0E8x7BWb4dVEFGIGDPoYIkUCk+cG/8 RPu2IH4dLcW4ZPbQ+ozlkq2cIKA3ClyUjUzMUoFywwq4YjxHTaCC80StbPG1SqrzwhEK Ek+j/WmD74EBRzrruMX4D+c3SiDR9oOWRVvXd3URCpouj8sCEawY5k48cCtbLFTZFYTM KegbrXfAJObuCvwotWcVjqT0qeAyZb013Vb1UaQbYuYXS2uSLm3x6YxWMn7xezV2Qha/ pjhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=p+4ov6xgHN6MAs/TAnhtH1cAVq0HQIIY5tsUAlOt0Jk=; b=dSaDZeQTxq0QCwm+QUVq5KOnedt61gdAM2oAP1C7pVIM5HSxulKx9r43yZFgt3gqsg HXDZoZOTFTKFIJ6Jd8iHFcjmCNDUHQplpWP+ryxkUeC/Muhu6PzkwYh5HofJgz576y8T aKljVJh152koqMr6bdw+AZV4slZxI4tdlzp8ZKgC6fxbpt0aiJkNHjMabDev8hBbdYKZ ICmn2QLxiAPL9lot1jLYpCaSbnojcT5bsbj2meX6fuGcihDyaJafq5z9zju5DwIuYBd/ 3MtdKz7HZRMT6c6XIcOZ2CQrUeWfOZzvI/sjSBf9tQKzKMmsTFM13274zGi28LvapAwa iQ1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q18si8795857edc.238.2020.05.19.03.11.30; Tue, 19 May 2020 03:11:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728286AbgESKIQ (ORCPT + 99 others); Tue, 19 May 2020 06:08:16 -0400 Received: from mga18.intel.com ([134.134.136.126]:27677 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725911AbgESKIP (ORCPT ); Tue, 19 May 2020 06:08:15 -0400 IronPort-SDR: 39h6fXfKL68fiT/VW7prhj0KD5UGl8/gTx/C1SKpa9RzzTmCztJiM7ROeTprnC4hTogg6L6hyV 4zdnCNfE2EOA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2020 03:08:15 -0700 IronPort-SDR: SjWFqbbimDqnm/TjnWpuDf0o3/YjENl1YCcC2qrTXp05DIM2wcwv1hDb4TRMTYUr8rYBbxnix7 URI5O6Ki7tuQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,409,1583222400"; d="scan'208";a="264257366" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga003.jf.intel.com with ESMTP; 19 May 2020 03:08:12 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jazAV-007c93-I1; Tue, 19 May 2020 13:08:15 +0300 Date: Tue, 19 May 2020 13:08:15 +0300 From: Andy Shevchenko To: Jonathan Albrieux Cc: linux-kernel@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Greg Kroah-Hartman , Hartmut Knaack , Jonathan Cameron , Lars-Peter Clausen , Linus Walleij , "open list:IIO SUBSYSTEM AND DRIVERS" , Peter Meerwald-Stadler , Thomas Gleixner Subject: Re: [PATCH v2 0/3] iio: magnetometer: ak8975: Add gpio reset support Message-ID: <20200519100815.GA1634618@smile.fi.intel.com> References: <20200519065749.4624-1-jonathan.albrieux@gmail.com> <20200519092212.GT1634618@smile.fi.intel.com> <20200519094835.GB10391@ict14-OptiPlex-980> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200519094835.GB10391@ict14-OptiPlex-980> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 19, 2020 at 11:48:35AM +0200, Jonathan Albrieux wrote: > On Tue, May 19, 2020 at 12:22:12PM +0300, Andy Shevchenko wrote: > > On Tue, May 19, 2020 at 08:57:40AM +0200, Jonathan Albrieux wrote: ... > > I dunno if it's your first submission to Linux kernel project or other OSS, > > but here you missed a changelog. Rule of thumb is to provide a summary of > > the changes done in the history of the evolution of a patch series. > > > > Oh thank you and sorry for not having included it. > > Does the changelog needs to be added to all patch files or just on the ones > subject of the changes? Up to you and maintainer of the corresponding subsystem. My common sense tells me that 1) if there is a cover letter, just put a joined changelog there 2) otherwise, put changelog in each patch. I saw in practice all possible variants, i.e. a) cover letter w/o changelog + changelog per patch; b) cover letter w/ changelog + changelog per patch; c) cover letter w/ changelog. I think any of it is fine in general. -- With Best Regards, Andy Shevchenko