Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp3420181ybk; Tue, 19 May 2020 04:20:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzEmov9XsDLRe8ucbAPCHW2nGmcnoMzUi9rBftmErYXSlZY6xq8fG4oOsKKDrk0dgnBSoXV X-Received: by 2002:a17:906:49c7:: with SMTP id w7mr182603ejv.402.1589887214567; Tue, 19 May 2020 04:20:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589887214; cv=none; d=google.com; s=arc-20160816; b=iklhtlRu5k/rJVQ+GYL0bIAk09Gp4uqSYIMdjO+Pw9HvQsLHsVV7xwYrdWpNb5s8QT oFYmMcEuJbalDjLguceEDV2xisYn4Gwy4KvAl4urAPzo6OB+29ntwcdBN3Zq39TtQIDL hCpYjTVI/BwcAkQvrrD664Cku0hUBTYx8gmuCgofrpAnJ4h9ITh8MwDCU7htvfYyTR5f yqG7UlR+3j/MGk6CM7PXz/TwsidIG02ReXRqAajkKayWf7pRAx40dgaXw8euLJjyvB9Z n/A6k2Fkl+bhlxMR8BVWHL2hkinv+58W3dVRJQ7jJPTVF+/2ti2mxCszFD53v9adu5KS xrqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-transfer-encoding :mime-version:references:in-reply-to:subject:cc:to:from; bh=XdezUHtnjEPl34SNV/OG/wiZxI5dHtj/gxxjDGommaM=; b=ZU01doQHSusqT5fGAJ5BUTQ9i8gd/3NEwX9hRusMHj9/GBWZwGqE7kS3BBDustTa00 uvqJfZNAkjyt9i/Y3Xx74MnsdKmVb/pY843USp6c2J8Bb0g7FiDGMynm2BAW21qn8H7R 5DKjDVg0wciTr/uV/ljwqYK6dKKzs5VrlyTCtaKy4nUJZaCfhXuVZ009uiIbmfxURKtZ HntdG1ulFJfsAYBEujAtxbYX8KFRocR16V2l/loc6+IVLSsPuDIJr7zBHmZ1OpPkI/2i ETIRTditplAB4rKvS9kwOaf4ZpOUKfcnlxXVEe2cbR/eLprlrHNvb+tw3azwkVvKt2q8 4DyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vt.edu Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y18si7867251ejf.113.2020.05.19.04.19.51; Tue, 19 May 2020 04:20:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vt.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728830AbgESLRw (ORCPT + 99 others); Tue, 19 May 2020 07:17:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728579AbgESLRv (ORCPT ); Tue, 19 May 2020 07:17:51 -0400 Received: from omr1.cc.vt.edu (omr1.cc.ipv6.vt.edu [IPv6:2607:b400:92:8300:0:c6:2117:b0e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16632C05BD0A for ; Tue, 19 May 2020 04:17:51 -0700 (PDT) Received: from mr3.cc.vt.edu (mr3.cc.ipv6.vt.edu [IPv6:2607:b400:92:8500:0:7f:b804:6b0a]) by omr1.cc.vt.edu (8.14.4/8.14.4) with ESMTP id 04JBHn3V031217 for ; Tue, 19 May 2020 07:17:49 -0400 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mr3.cc.vt.edu (8.14.7/8.14.7) with ESMTP id 04JBHiZg026974 for ; Tue, 19 May 2020 07:17:49 -0400 Received: by mail-qk1-f199.google.com with SMTP id p15so14392775qkk.15 for ; Tue, 19 May 2020 04:17:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :mime-version:content-transfer-encoding:date:message-id; bh=XdezUHtnjEPl34SNV/OG/wiZxI5dHtj/gxxjDGommaM=; b=hRx3Yfes+C/y6yOvjQ3CXQlbMChike4ihTTu8f1aGzXTOTNpetkCFcxnKUipCkLRIl Ij7UoXBaHqKdEe+SsuTOOQk5/DGfJdU/daQxnG4XdkRG3a4N7exaVsdtTUAyxdkCaAWS viyZuX5sKA0tmLc3nhu4Mulz/oCSJpWf+yjk3NcnCddbR9CuZs/tjBAren7eBYpFmW5p 3o5ajRXpJMN9fiQSCdocWv+8ywhXtdhmPrixkWu+6s9kHF27GFSy25veOC1U0tNKzdyd utsHzITPtB7pLtbe687tifRuGHTCqhCpCxebZCCNoZP5rvDgRJcFcdG5lGyZ+1knqbvW DGfg== X-Gm-Message-State: AOAM533pPjWa4bB/N3YIMkUeD5yj00lPITVu/d7xqusizeoA9jt4Kanp 8qNkO32VoqZ0c3/+LxIH3bIE31MU4j4u952eckK1JzGePMod535DtDy11w8g8wttNGAMYlsXb0M 5MFs8M8wP+vzP536/zvoGCiQoWT8AhnWY6wg= X-Received: by 2002:a0c:aec5:: with SMTP id n5mr20903695qvd.0.1589887064029; Tue, 19 May 2020 04:17:44 -0700 (PDT) X-Received: by 2002:a0c:aec5:: with SMTP id n5mr20903663qvd.0.1589887063744; Tue, 19 May 2020 04:17:43 -0700 (PDT) Received: from turing-police ([2601:5c0:c001:c9e1::359]) by smtp.gmail.com with ESMTPSA id z65sm10191073qkc.91.2020.05.19.04.17.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 04:17:42 -0700 (PDT) From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Google-Original-From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev To: Qii Wang Cc: Joe Perches , Geert Uytterhoeven , Wolfram Sang , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , srv_heupstream@mediatek.com, leilk.liu@mediatek.com, "Linux Kernel Mailing List" , linux-mediatek@lists.infradead.org, Linux I2C , Linux ARM Subject: Re: [PATCH v2 2/2] i2c: mediatek: Add i2c ac-timing adjust support In-Reply-To: <1589857073.25512.34.camel@mhfsdcap03> References: <1589461844-15614-1-git-send-email-qii.wang@mediatek.com> <1589461844-15614-3-git-send-email-qii.wang@mediatek.com> <1589857073.25512.34.camel@mhfsdcap03> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1589887060_31675P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Tue, 19 May 2020 07:17:41 -0400 Message-ID: <116825.1589887061@turing-police> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --==_Exmh_1589887060_31675P Content-Type: text/plain; charset=us-ascii On Tue, 19 May 2020 10:57:53 +0800, Qii Wang said: > (1000000000 * (sample_cnt + 1)) / clk_src value is a 32-bit, (1000000000 > * (sample_cnt + 1)) will over 32-bit if sample_cnt is 7. > > I think 1000000000 and clk_src is too big, maybe I can reduce then with > be divided all by 1000. Yes, it's definitely too big, the 3 DIV_ROUND_UP calls in mtk_i2c_check_ac_timing() end up causing a build issue during modpost on a 32-bit RPi4: ERROR: modpost: "__aeabi_uldivmod" [drivers/i2c/busses/i2c-mt65xx.ko] undefined! ERROR: modpost: "__aeabi_ldivmod" [drivers/i2c/busses/i2c-mt65xx.ko] undefined! --==_Exmh_1589887060_31675P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Comment: Exmh version 2.9.0 11/07/2018 iQIVAwUBXsPAVAdmEQWDXROgAQLPGg/9GGQpzw7XKYxr/tvBAg5sc8H1rTqhNMQF FGBWDl46QaKwfWatNNq0L6HGC2X9FDlG7hdzIi0HJFJjTDVGlN9C/QNH5zeCmMCF zDcbsj8tnLoNMW4v2Dl3Q2ZxFWihnepXqfzg8KG5fDDiEHSaP38hDe8GK/MXb5X/ KjGRXMF1qQnbDh2q1trjaJExQqbJ2D2wyngaUS0vDqJOaXm3TaY91NbNUQUVlOmd wQl05fDL7ziCbcrxn5HdNSxaBiSTNtQwcBrsV8JF7YImeyDx+/I974qRSxZB8zKF +RPabakMPOZFBgHrikYKplTogjXN5fCCF8F/muITK1/EPpI9PgeMDZNCGU07xRux v8/UkqwLqAuAnqG3vm5F9I1q+0qbEyyCaU4Mm2DWMGyYzCHXAkfQAJQF/MkQhE54 JxyZKSv7Y4x+nMgL4tlD37DFGCVTXlk9nUyKcNqr08nlu2nDiszlTScHtuHnSqEo uk3mbh7mKYwpbMJIa/j0n5zLVabSB09IDZ5Jk/+ZlTPh143zTqqFXKfB5akC6Ve5 6pGPcsXJl6ubOdaLT8LcxRVkyaKa/3tYXLBFjxsu6NkfNhytddnVzPAw6/5qRcos M4R7h0mvQLLRPDLrTkNq1ur6V/3xgup/M8qAunQyKWPNZXYPvNc93Vgh1b6274o0 aL8PqtTCnss= =SvGK -----END PGP SIGNATURE----- --==_Exmh_1589887060_31675P--