Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Tue, 23 Oct 2001 06:55:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Tue, 23 Oct 2001 06:54:50 -0400 Received: from s1.relay.oleane.net ([195.25.12.48]:9891 "HELO s1.relay.oleane.net") by vger.kernel.org with SMTP id ; Tue, 23 Oct 2001 06:54:38 -0400 From: Benjamin Herrenschmidt To: Alan Cox Cc: , Patrick Mochel Subject: Re: [RFC] New Driver Model for 2.5 Date: Tue, 23 Oct 2001 12:54:49 +0200 Message-Id: <20011023105449.8455@smtp.adsl.oleane.com> In-Reply-To: In-Reply-To: X-Mailer: CTM PowerMail 3.0.8 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org >I'd very much like this one to be two pass, with the second pass occuring >after interrupts are disabled. There are some horrible cases to try and >handle otherwise (like devices that like to jam the irq line high). > >Ditto on return from suspend where some devices also like to float the irq >high as you take them over (eg USB on my Palmax). From comments Ben made >ages back I believe ppc has similar issues if not worse Well, the idea here was to disable them between the second and third pass. Device that can completely suspend with interrupts enabled can do it at the end of step 2, while more broken devices can do it at step 3. It might be semantically more clear to actually consider step 2 as exclusively "block io & save state", in which case, breaking up the "suspend" state into 2 separate states with and without interrupt makes sense. We just didn't fell that was necessary. Ben. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/