Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp3445200ybk; Tue, 19 May 2020 05:00:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJww64J0gmuZR5rYl8luiwjGQBIcVph6ttTRvD/s0m0jXdUcRehiB9VmMb7jN/goEmg2LkO5 X-Received: by 2002:a17:906:7016:: with SMTP id n22mr310319ejj.389.1589889643929; Tue, 19 May 2020 05:00:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589889643; cv=none; d=google.com; s=arc-20160816; b=PIW/l6Zffl34gAmkojcAf/ICkUgC2f4xQwn/fXOPmbkNvW74IwlQ/M7s+Bkdtj+YUV q6GqE+YQayewwr/JG22bLHUVNpxko+KwHpvSZaoIA0h6qkD7DEav9yth3VFFrJuXFICw oQr/Cb9X6kx7kc6lhnYhW/liZ4gj2hqpclS0FJfbDAs3iCd/DzxPLHHf6rzhczu7gdhs fpYyf61b4FHxcUosIzsDQTr8sBoquB/xXVgQqqdq7QXohl/osW5KuISODEzY3PcyfUrU AUGOJqtwqRx0a4lTebRA2XP/+y914q+wpQuucropVp22rwB5S2MAAXEMzSb2xR1kV+2C o1+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=/WU4ZDYa+kxxKgZ4GTYrAjmqMg3Ba4/s+yeleIxEo2c=; b=zSD23p6DDkRJwKt8bEdXa97dCnkhQL6C7WV9DwhhFp5/o8AYycXtoj+UObZONs/BE6 K4h4N98ScvwVy7S1ZmGPWNwzY11rG4goDKJezPnRB9gQqSQo0+RaSoxt6KPWr/bcQ6/T lxX7JHZ289U+DrNUbDcKL87TYfJqIcmQH6uACKxTbQPR0zxsIMRp0bguHreQ62Yqp/vS 1lcudkqIm/11IMWYM4O7LWaFmjY3vVHEatskmLYHfksujrVBftf4pvfGHalNB4Vptb8k GeKBa/dNlS0J6k7UzxfQCrCeGPX+mxHlNOkyj4tTjb3j7AhSpbqv63KT3lPgB2U0crg6 v1sg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p9si803698ejo.380.2020.05.19.05.00.18; Tue, 19 May 2020 05:00:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728795AbgESL5m (ORCPT + 99 others); Tue, 19 May 2020 07:57:42 -0400 Received: from mga12.intel.com ([192.55.52.136]:18100 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726949AbgESL5m (ORCPT ); Tue, 19 May 2020 07:57:42 -0400 IronPort-SDR: F5YMKoU+qMHz1kUB8YfHDcjFhoLUYYLyGBP/VUD3srrqJfDKukutqK2Es39oaWn9Gi0u18cHo0 wOx2S9xuUhgA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2020 04:57:42 -0700 IronPort-SDR: YBmlirqP1mfDY2/shxRL2nz01uQVfsC6fFTTtPR/n2bkG/ZnhNOR6vu9dTc262VIJWmiUccltJ OFYuh7X3uZnQ== X-IronPort-AV: E=Sophos;i="5.73,410,1583222400"; d="scan'208";a="439594040" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2020 04:57:37 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id BBB2920CEF; Tue, 19 May 2020 14:57:35 +0300 (EEST) Date: Tue, 19 May 2020 14:57:35 +0300 From: Sakari Ailus To: Roman Kovalivskyi Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Luis Oliveira , Niklas =?iso-8859-1?Q?S=F6derlund?= , Jacopo Mondi , Michael Rodin , Mauro Carvalho Chehab , Hugues Fruchet , Maxime Ripard , Adam Ford , Todor Tomov , Suresh Udipi , Andrew Gabbasov , Eugeniu Rosca , Dave Stevenson Subject: Re: [PATCH v2 4/6] media: ov5647: Use gpiod_set_value_cansleep Message-ID: <20200519115735.GL20066@paasikivi.fi.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 19, 2020 at 04:16:19AM +0300, Roman Kovalivskyi wrote: > From: Dave Stevenson > > All calls to the gpio library are in contexts that can sleep, > therefore there is no issue with having those GPIOs controlled > by controllers which require sleeping (eg I2C GPIO expanders). > > Switch to using gpiod_set_value_cansleep instead of gpiod_set_value > to avoid triggering the warning in gpiolib should the GPIO > controller need to sleep. > > Signed-off-by: Dave Stevenson > Signed-off-by: Roman Kovalivskyi This needs to be merged with the 2nd patch. -- Sakari Ailus