Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp3553980ybk; Tue, 19 May 2020 07:29:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/TJdRYnLMGK17am0ldxpCOQ8hHxoS+WVXWE2vxEBMlzAmr6fde1xJhhfZzPSch2qX8ZoD X-Received: by 2002:a17:906:924a:: with SMTP id c10mr14443636ejx.360.1589898545514; Tue, 19 May 2020 07:29:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589898545; cv=none; d=google.com; s=arc-20160816; b=XVRS97Whz0H8xW7fHC0Gk0mwQCxYsnz2b6h4fNzOsLYazJWKpzPHD5I+9WKK8UpPn4 uVHPt/Y+XvSfMH4Th1IAA5GlOaZbHJ0TUiR69OOKBZ6hn4bRTGAbNn7ZZpiKU2tCFGqV lNe8iOPWRz0yp9DrEAIuPcN1hklsq+vI4XLBImnY9MKjGp12iloSpAWFjw7GaKceDzaD fs+MQPUybJEzCUrqamzlSodxZFHuEuJdlndcR7UYoljJzobslX6W4DDO0B9vnMEpW00B qPk0wN39IIqVO2jo3wnVkBsKnrBoRiQUWDTjZ2LsAnDFoQvdY2dpyNiMtVDVCvKA3wjT gltQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=nld47umMctPIIViH8mIfnth8wdpODIMC9+0TGQ4md1M=; b=TdloO67HZemx0LdcGMAA5hsJ/JfitEiYDuwc08IwryNQQ9Ss3QUwSvzFy+bU1t1kfH Ji9HcjfLQhVAEf0x9K6RqUSsi4kJ4jBKq74CcfTO+ERyaPcDAFmlD8jHFXQ5AUbOU+K5 kfHMmBJLLp3CFtiZLMDoNS5TlZGNAm4NfuSz7FMVs8VZgNEYinQ9Iw27pNLb6BaaBRUx JxoKT8xb5PSyxz4mypHqBqyRaediGzu7bvI+PSzIf5+Q8XID9qBOVz1JcwZJSpKor2C7 3x42NgryAzSI20ZY1/kFKoySHjv5ApsUvJgU8Gk26PBmENnpGRUDAC0FUR21PIJ5F2Gq e56Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=ZNCWrQCv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i12si8687391ejx.447.2020.05.19.07.28.41; Tue, 19 May 2020 07:29:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=ZNCWrQCv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728995AbgESO1S (ORCPT + 99 others); Tue, 19 May 2020 10:27:18 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:36756 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728737AbgESO1R (ORCPT ); Tue, 19 May 2020 10:27:17 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 04JEQmtp062554; Tue, 19 May 2020 09:26:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1589898408; bh=nld47umMctPIIViH8mIfnth8wdpODIMC9+0TGQ4md1M=; h=From:To:CC:Subject:Date; b=ZNCWrQCv+q6Y5YUcXLVKCwR5rC4wfjTfqnddHYZkggBuEQ2A34ONiTwxZCI70pUox q9Pnf/b2GQ5oE0hRbmR0vQy2Pqb8Nw32uUunfAHXLZAScCpB6FLcrIbSiTgJlID1Uq U9oZpXG4DGWVzpL68rjDFAzFKTkTGLTp2KUzbQR0= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 04JEQmwI068401 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 19 May 2020 09:26:48 -0500 Received: from DFLE103.ent.ti.com (10.64.6.24) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 19 May 2020 09:26:48 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 19 May 2020 09:26:47 -0500 Received: from pratyush-OptiPlex-790.dhcp.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 04JEQgjI008313; Tue, 19 May 2020 09:26:43 -0500 From: Pratyush Yadav To: Tudor Ambarus , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Mark Brown , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Matthias Brugger , , , , , CC: Pratyush Yadav , Sekhar Nori , Boris Brezillon , Mason Yang Subject: [PATCH v5 00/19] mtd: spi-nor: add xSPI Octal DTR support Date: Tue, 19 May 2020 19:56:22 +0530 Message-ID: <20200519142642.24131-1-p.yadav@ti.com> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, This series adds support for octal DTR flashes in the spi-nor framework, and then adds hooks for the Cypress Semper and Mircom Xcella flashes to allow running them in octal DTR mode. This series assumes that the flash is handed to the kernel in Legacy SPI mode. Tested on TI J721e EVM with 1-bit ECC on the Cypress flash. Changes in v5: - Do not enable stateful X-X-X modes if the reset line is broken. - Instead of setting SNOR_READ_HWCAPS_8_8_8_DTR from Profile 1.0 table parsing, do it in spi_nor_info_init_params() instead based on the SPI_NOR_OCTAL_DTR_READ flag instead. - Set SNOR_HWCAPS_PP_8_8_8_DTR in s28hs post_sfdp hook since this capability is no longer set in Profile 1.0 parsing. - Instead of just checking for spi_nor_get_protocol_width() in spi_nor_octal_dtr_enable(), make sure the protocol is SNOR_PROTO_8_8_8_DTR since get_protocol_width() only cares about data width. - Drop flag SPI_NOR_SOFT_RESET. Instead, discover soft reset capability via BFPT. - Do not make an invalid Quad Enable BFPT field a fatal error. Silently ignore it by assuming no quad enable bit is present. - Set dummy cycles for Cypress Semper flash to 24 instead of 20. This allows for 200MHz operation in 8D mode compared to the 166MHz with 20. - Rename spi_nor_cypress_octal_enable() to spi_nor_cypress_octal_dtr_enable(). - Update spi-mtk-nor.c to reject DTR ops since it doesn't call spi_mem_default_supports_op(). Changes in v4: - Refactor the series to use the new spi-nor framework with the manufacturer-specific bits separated from the core. - Add support for Micron MT35XU512ABA. - Use cmd.nbytes as the criteria of whether the data phase exists or not instead of cmd.buf.in || cmd.buf.out in spi_nor_spimem_setup_op(). - Update Read FSR to use the same dummy cycles and address width as Read SR. - Fix BFPT parsing stopping too early for JESD216 rev B flashes. - Use 2 byte reads for Read SR and FSR commands in DTR mode. Changes in v3: - Drop the DT properties "spi-rx-dtr" and "spi-tx-dtr". Instead, if later a need is felt to disable DTR in case someone has a board with Octal DTR capable flash but does not support DTR transactions for some reason, a property like "spi-no-dtr" can be added. - Remove mode bits SPI_RX_DTR and SPI_TX_DTR. - Remove the Cadence Quadspi controller patch to un-block this series. I will submit it as a separate patch. - Rebase on latest 'master' and fix merge conflicts. - Update read and write dirmap templates to use DTR. - Rename 'is_dtr' to 'dtr'. - Make 'dtr' a bitfield. - Reject DTR ops in spi_mem_default_supports_op(). - Update atmel-quadspi to reject DTR ops. All other controller drivers call spi_mem_default_supports_op() so they will automatically reject DTR ops. - Add support for both enabling and disabling DTR modes. - Perform a Software Reset on flashes that support it when shutting down. - Disable Octal DTR mode on suspend, and re-enable it on resume. - Drop enum 'spi_mem_cmd_ext' and make command opcode u16 instead. Update spi-nor to use the 2-byte command instead of the command extension. Since we still need a "extension type", mode that enum to spi-nor and name it 'spi_nor_cmd_ext'. - Default variable address width to 3 to fix SMPT parsing. - Drop non-volatile change to uniform sector mode and rely on parsing SMPT. Changes in v2: - Add DT properties "spi-rx-dtr" and "spi-tx-dtr" to allow expressing DTR capabilities. - Set the mode bits SPI_RX_DTR and SPI_TX_DTR when we discover the DT properties "spi-rx-dtr" and spi-tx-dtr". - spi_nor_cypress_octal_enable() was updating nor->params.read[] with the intention of setting the correct number of dummy cycles. But this function is called _after_ selecting the read so setting nor->params.read[] will have no effect. So, update nor->read_dummy directly. - Fix spi_nor_spimem_check_readop() and spi_nor_spimem_check_pp() passing nor->read_proto and nor->write_proto to spi_nor_spimem_setup_op() instead of read->proto and pp->proto respectively. - Move the call to cqspi_setup_opcode_ext() inside cqspi_enable_dtr(). This avoids repeating the 'if (f_pdata->is_dtr) cqspi_setup_opcode_ext()...` snippet multiple times. - Call the default 'supports_op()' from cqspi_supports_mem_op(). This makes sure the buswidth requirements are also enforced along with the DTR requirements. - Drop the 'is_dtr' argument from spi_check_dtr_req(). We only call it when a phase is DTR so it is redundant. Pratyush Yadav (19): spi: spi-mem: allow specifying whether an op is DTR or not spi: atmel-quadspi: reject DTR ops spi: spi-mtk-nor: reject DTR ops spi: spi-mem: allow specifying a command's extension mtd: spi-nor: add support for DTR protocol mtd: spi-nor: sfdp: default to addr_width of 3 for configurable widths mtd: spi-nor: sfdp: prepare BFPT parsing for JESD216 rev D mtd: spi-nor: sfdp: get command opcode extension type from BFPT mtd: spi-nor: sfdp: parse xSPI Profile 1.0 table mtd: spi-nor: core: use dummy cycle and address width info from SFDP mtd: spi-nor: core: do 2 byte reads for SR and FSR in DTR mode mtd: spi-nor: core: enable octal DTR mode when possible mtd: spi-nor: sfdp: do not make invalid quad enable fatal mtd: spi-nor: sfdp: detect Soft Reset sequence support from BFPT mtd: spi-nor: core: perform a Soft Reset on shutdown mtd: spi-nor: core: disable Octal DTR mode on suspend. mtd: spi-nor: core: expose spi_nor_default_setup() in core.h mtd: spi-nor: spansion: add support for Cypress Semper flash mtd: spi-nor: micron-st: allow using MT35XU512ABA in Octal DTR mode drivers/mtd/spi-nor/core.c | 446 +++++++++++++++++++++++++++----- drivers/mtd/spi-nor/core.h | 22 ++ drivers/mtd/spi-nor/micron-st.c | 112 +++++++- drivers/mtd/spi-nor/sfdp.c | 117 ++++++++- drivers/mtd/spi-nor/sfdp.h | 13 +- drivers/mtd/spi-nor/spansion.c | 167 ++++++++++++ drivers/spi/atmel-quadspi.c | 4 + drivers/spi/spi-mem.c | 3 + drivers/spi/spi-mtk-nor.c | 4 + include/linux/mtd/spi-nor.h | 53 +++- include/linux/spi/spi-mem.h | 13 +- 11 files changed, 862 insertions(+), 92 deletions(-) -- 2.26.2