Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp3554415ybk; Tue, 19 May 2020 07:29:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxj1OcOTGkpFjsdK19OBDjDefHrwS42KZ2yzRb4RsJAQSp+dhePIpxMuakgHk4mrr5rWU7K X-Received: by 2002:a50:f385:: with SMTP id g5mr17246957edm.2.1589898582313; Tue, 19 May 2020 07:29:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589898582; cv=none; d=google.com; s=arc-20160816; b=jqmxgLQ3jDStDZTcCbDZn9FZSul77ZBeayA2RZpOI5Xaf0VkITA2yYbd+qC1ztW0Vf 4eyordj2jB8lj9Slz+f3VpmZbRh+1rq+0aGntxLXOlDOxvj0BRuZkmI5kMCrEu5K9muB caRhz4JoWgaX/QErXmc4Xs2zZGVWQlG03mYPczFl7VTm/Dm/Ra6E28fCJdT+xah08t3t xdLFUhgCNicc7YIbI9KFeWPssTu0gE4+QPd63k+tQREH3ajXVekbT1wI12+jm8NCz36N Uex9DKU8kCpPbwBXI89z0HkKU3qdKGtFEuOdcqjVthe7uVXbeVFO0W6dcqJVfrTH3HLR ytYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8wsmxHh8Fj6nnuOv4RqixX/76ikZXmO9s3dBnceWxdw=; b=MDM5RtgU0yOlfvF0Mam31xnRFedms1tY3jT0New7BCdgM8IppJBVM344LXsrWrEl0b uh+YsB8s2TXmFeU3Fk5lrnqoevPJSnCsRLH73UuPFWdSk6jPEW5n9P+d6XqQDFRM+QKB f+iORiOKCQjSZRz2pEDowWOgzqPAw7SJFjuEZpewC450GA+EURhaJYOk8yakch6q3VmC TbAFWatUW+cD3xGRQECXYzWoC7ocI7Iq/Hwa7bLOrm12DrA/bYR6Jk2IIv2AEvi83xGz ypzl4aK1bDDOCaOiDVWZxMoQ4akmQbB0WJ/MLJ7sbODH9OGqBRLvLJPYb/lhUiczU51U 7gFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=sTNGSLoH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id re2si249151ejb.644.2020.05.19.07.29.18; Tue, 19 May 2020 07:29:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=sTNGSLoH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729173AbgESO1i (ORCPT + 99 others); Tue, 19 May 2020 10:27:38 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:43582 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729159AbgESO1f (ORCPT ); Tue, 19 May 2020 10:27:35 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 04JER3Mp005249; Tue, 19 May 2020 09:27:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1589898423; bh=8wsmxHh8Fj6nnuOv4RqixX/76ikZXmO9s3dBnceWxdw=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=sTNGSLoHgIbZldl7H5+uVC20Pf2pG9ekXgjXgkNBY8SbtsRpdN09a9leXDHl+9ybt Q6/Tj/OZRDWK/4tqj2lW31Yk57bicxoQCbDo8UZnu+ATbfq37ijMXewSV9/TaNb5k4 bReo/wFDviBlwRrvG+OjEOiwfea/X/dz3qELbXgE= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 04JER3Hr037848; Tue, 19 May 2020 09:27:03 -0500 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 19 May 2020 09:27:03 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 19 May 2020 09:27:03 -0500 Received: from pratyush-OptiPlex-790.dhcp.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 04JEQgjL008313; Tue, 19 May 2020 09:26:58 -0500 From: Pratyush Yadav To: Tudor Ambarus , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Mark Brown , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Matthias Brugger , , , , , CC: Pratyush Yadav , Sekhar Nori , Boris Brezillon , Mason Yang Subject: [PATCH v5 03/19] spi: spi-mtk-nor: reject DTR ops Date: Tue, 19 May 2020 19:56:25 +0530 Message-ID: <20200519142642.24131-4-p.yadav@ti.com> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200519142642.24131-1-p.yadav@ti.com> References: <20200519142642.24131-1-p.yadav@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Double Transfer Rate (DTR) ops are added in spi-mem. But this controller doesn't support DTR transactions. Since we don't use the default supports_op(), which rejects all DTR ops, do that explicitly in our supports_op(). Signed-off-by: Pratyush Yadav --- drivers/spi/spi-mtk-nor.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/spi/spi-mtk-nor.c b/drivers/spi/spi-mtk-nor.c index 7bc302b50396..7015dccedf00 100644 --- a/drivers/spi/spi-mtk-nor.c +++ b/drivers/spi/spi-mtk-nor.c @@ -211,6 +211,10 @@ static bool mtk_nor_supports_op(struct spi_mem *mem, if (op->cmd.buswidth != 1) return false; + /* DTR ops not supported. */ + if (op->cmd.dtr || op->addr.dtr || op->dummy.dtr || op->data.dtr) + return false; + if ((op->addr.nbytes == 3) || (op->addr.nbytes == 4)) { if ((op->data.dir == SPI_MEM_DATA_IN) && mtk_nor_match_read(op)) return true; -- 2.26.2