Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp3629825ybk; Tue, 19 May 2020 09:11:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzpNKkLWPHRmDuZJ9tM8AeU/68JL1ihlIEoOJdqECf5vM84aF3Q9YVkedppSpStN/j+kefF X-Received: by 2002:a17:906:a44f:: with SMTP id cb15mr1947374ejb.219.1589904690721; Tue, 19 May 2020 09:11:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589904690; cv=none; d=google.com; s=arc-20160816; b=QO6R6Qos62kFTEqIwN/MY6ff/45rL0zu+KsbNG6A++HPFo6rrn1BhpaWe7Frb5ByWF smIVm4y1s7pns5Yk60gN0ycNKRiQ0qnE0ibdmXQ6SuTjxixfOW/NwanCMJSRuEavUhKP tQ/vyOQYHxTrB12amMwInrp3MPeaSTmbpDbhelvSLVhP+txjxbNvuRxK0krUCagylnKw BPLZzo3p2ItiTIZ+feEkeiWpHS0sdJYDFkdQCnIby2qa0M6AQs8dil43k2E/AyIDRJC1 B9zxJOHXrLf4dehFc3ZHUf6ZlCuTHC+rrvL4Jo4m37O42Mq2M7GO8V5zHNdembe7oPZL OMCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature; bh=zRT2cWRe/iSsAPIM4DFZJ1nWKegbc66LySB3xrfzh7I=; b=EZ7YRDvgdnW5cBMwg4S+Nhqs8YFL363klz/12Z6ZRhx/AcXFZFjxisWZ66UmQtImns u4p826qLMA4bgHVoe4VOljPyQkV+V42GSkskpxNLB1//gv9Zi4Ww6pXc329MWGweVqK1 4FeUjoZp7nQ348tNPkNsOKv8VBf2CXwQnWgDyGdM7cgWo1zWL757Aso/KGAeJ3K3UDcx 5yUEPl2qKaVClTHC4XSrJDN4kz/Fo8Ca7naoCfspWe22r/6M1VrSh61V6isH/ZViZTBE QOa3aFn5QR9BQIhITiek1qalC9HWgUKNIVxm/qEMnGtewyt5qr/FWpGxSlQLDS3RrJb9 Pwjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NV4cKwwu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b25si7928569edt.290.2020.05.19.09.11.05; Tue, 19 May 2020 09:11:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NV4cKwwu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729357AbgESQJB (ORCPT + 99 others); Tue, 19 May 2020 12:09:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:34206 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729055AbgESQI7 (ORCPT ); Tue, 19 May 2020 12:08:59 -0400 Received: from embeddedor (unknown [189.207.59.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9C4302075F; Tue, 19 May 2020 16:08:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589904539; bh=u3+jsia5NAW/8Ph5G2JpnG6etn7OX8oeTKdDlKnd0Sc=; h=Date:From:To:Cc:Subject:From; b=NV4cKwwuBLLyXVatnObrm47KAEk5WfJ8UQC8c3xRc7mAEJpUQF7O+uI0gdsdZq381 f7BJ3B3WbVujfd3EA2AW0zQN2qdrSxoQ8Yi8dE9iCneCp41e8b4sxb8DwOCwLqgU+L 6lmnZZOTUAc/Qm7XxCtWaOWhQIzS9A/fzMTzJPEk= Date: Tue, 19 May 2020 11:13:45 -0500 From: "Gustavo A. R. Silva" To: Danil Kipnis , Jack Wang , Doug Ledford , Jason Gunthorpe Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] RDMA/rtrs: client: Fix function return on success Message-ID: <20200519161345.GA3910@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function should return 0 on success, instead of err. Addresses-Coverity-ID: 1493753 ("Identical code for different branches") Fixes: 6a98d71daea1 ("RDMA/rtrs: client: main functionality") Signed-off-by: Gustavo A. R. Silva --- drivers/infiniband/ulp/rtrs/rtrs-clt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c index 468fdd0d8713c..465515e46bb1a 100644 --- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c @@ -1594,7 +1594,8 @@ static int create_con_cq_qp(struct rtrs_clt_con *con) if (err) return err; - return err; + + return 0; } static void destroy_con_cq_qp(struct rtrs_clt_con *con) -- 2.26.2