Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp3663314ybk; Tue, 19 May 2020 09:58:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwb6IBzVKx1Xju3Vdk9eBN2kXUMC0YzwcdInFo3V/Akq2dZPlLmaJ7G0tymwSCQCXc6QZUo X-Received: by 2002:a17:906:ff54:: with SMTP id zo20mr189478ejb.124.1589907522254; Tue, 19 May 2020 09:58:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589907522; cv=none; d=google.com; s=arc-20160816; b=kTZRc5Rr/EKK4Mf/b4Wpeu1MQos/WOgMe6ByXaRWZcJXAzFQmAWgxSe2esoAO+Ba8b ru4rQXPt9GDklLwMD3dgMJKiOnqoDlJ+eGuCUq/gC9ggrTN0VHRpXqWYXE7uTh74vPaM DV7VCyM3tR8fC0Y+2JRgFYUMxLOVY5P0apJmbYDSSyVrE/zqpEB3UIZRQ8Pok6Wa1nuk I3bMAUKjQNtleoGU+unJBhlgzPd6bB5RVbLJUyyD0nVrzjkIvkAwIRA1lfEnICMk/QCa XaKQaN2oh2hrROsSqbOxyozEf758hPG6e7cQUjlc245JYZyGDH25/5tt8Xky3Ky+JRsc 1jIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=2+x8kj8VTopid2kMbQRyJPA7l/D1PmCvfzdX6Lu7H80=; b=yj0u+/WHneNt6QS0IX4/v1OYap67uP0YB+0/2eww71n0VJJKzCO69VUj4QnRy/QoJM trEhx/3o5Gx84uuvhVt83xJKWgEfAUD4jmM2WWDNh7bq0yy4PJS0OaIE5SXAYJIVAPwh put1lJHC5WFIXSpCJZk1RMaifSzpCc+wwbJAg/poPKNfQPXKBkkLa3UXodkMxmDwFOh7 Tw6odmbC5zxrGhTdGoFdG1G5N7IwKLDgaum3RwkNJfLOE4LeMuPPadTXdtiT7Su8MWtk roidv9Rt/T8DQuavHmC+dzDDMkV5RibYKbk7G7xPAxFV9zxRVL6VcYZi/QXkjcEyw/Wk 4AkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Wpq3faH0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h1si7089edn.474.2020.05.19.09.58.17; Tue, 19 May 2020 09:58:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Wpq3faH0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729402AbgESQ4h (ORCPT + 99 others); Tue, 19 May 2020 12:56:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:60720 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728689AbgESQ4h (ORCPT ); Tue, 19 May 2020 12:56:37 -0400 Received: from localhost (unknown [122.182.207.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DB4C5204EA; Tue, 19 May 2020 16:56:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589907396; bh=IupW7XaMJkYsAayJCAozFvTTvpKJWQQBm6o5U94IMBI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Wpq3faH0UEduYmM5h1fBDkA1ZA33Iw8GA1bwkOTlaDqWlOFKRjHIf/6rQ48aDkK1I +Dxj/G8unzQ6VJFUkh67Ufvbwuha8uSsHCPutEYuiMgAP+uCT/C2s/VRCUr5lCEpjx EOaHnn7jg/+WwcL8rnnHQ2sQThRvMPaFB1uj4QJk= Date: Tue, 19 May 2020 22:26:32 +0530 From: Vinod Koul To: Christophe JAILLET Cc: ldewangan@nvidia.com, jonathanh@nvidia.com, dan.j.williams@intel.com, thierry.reding@gmail.com, dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] dmaengine: tegra210-adma: Fix an error handling path in 'tegra_adma_probe()' Message-ID: <20200519165632.GQ374218@vkoul-mobl.Dlink> References: <20200516214205.276266-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200516214205.276266-1-christophe.jaillet@wanadoo.fr> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16-05-20, 23:42, Christophe JAILLET wrote: > Commit b53611fb1ce9 ("dmaengine: tegra210-adma: Fix crash during probe") > has moved some code in the probe function and reordered the error handling > path accordingly. > However, a goto has been missed. > > Fix it and goto the right label if 'dma_async_device_register()' fails, so > that all resources are released. Applied for fixes, thanks -- ~Vinod