Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 19 May 2020 18:44:52 +0100
From:   Mark Brown <broonie@kernel.org>
To:     shuah <shuah@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 3/3] selftests: vdso: Add a selftest for vDSO getcpu()
Message-ID: <20200519174452.GR4611@sirena.org.uk>
References: <20200505174728.46594-1-broonie@kernel.org>
 <20200505174728.46594-4-broonie@kernel.org>
 <dff4dfbd-f3f1-d683-5dac-4404e9023b2e@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="zj18g9eElA7rRQh+"
Content-Disposition: inline
In-Reply-To: <dff4dfbd-f3f1-d683-5dac-4404e9023b2e@kernel.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--zj18g9eElA7rRQh+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, May 19, 2020 at 11:11:28AM -0600, shuah wrote:
> On 5/5/20 11:47 AM, Mark Brown wrote:

> > +int main(int argc, char **argv)
> > +{
> > +	unsigned long sysinfo_ehdr =3D getauxval(AT_SYSINFO_EHDR);
>=20
> WARNING: Missing a blank line after declarations
> WARNING: Missing a blank line after declarations
> #135: FILE: tools/testing/selftests/vDSO/vdso_test_getcpu.c:27:
> +	unsigned long sysinfo_ehdr =3D getauxval(AT_SYSINFO_EHDR);
> +	if (!sysinfo_ehdr) {

This is the idiom in use by the existing gettimeofday test:

WARNING: Missing a blank line after declarations
#38: FILE: tools/testing/selftests/vDSO/vdso_test_gettimeofday.c:38:
+	unsigned long sysinfo_ehdr =3D getauxval(AT_SYSINFO_EHDR);
+	if (!sysinfo_ehdr) {

so I don't know how you want the code to look here?

--zj18g9eElA7rRQh+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7EGxMACgkQJNaLcl1U
h9Dtrgf9EvPl6k4mQxLhof/GI9tdCjeQvG/Mnv+3PVimZt6YlWwQj/GFbMTzhRKS
TnWRtySrFArKtJJZT+cmsWR97PIH84sdlc6CJrxnsWUltZhuqxqocTMrDAQB9blU
0qjMzXi6cfIIDeF8NC9LSvQoZOM7PznXZ28meiv0cqqX1hPegI7ihg1woGRlRkPn
FXw6awO+1qKNTjPJsSwTjrqUTX5r4Jsf1r9ccrAVJuh/D+T5+Szjyqy/OLCuHJEp
soHSdEfFRrfh6NE0pl57MiYpB0mXRnQcKnBQNsgnirF4QXr7dMFQEvEiLIdvkTnD
llBPb6z1WnlinXHtHkNE/qBaDNMFOw==
=OVk4
-----END PGP SIGNATURE-----

--zj18g9eElA7rRQh+--