Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp3750553ybk; Tue, 19 May 2020 12:03:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwA6BZoaIjCZVSsSra2jeUSjmEEM/vC5OscUfYXrQ3BifITSdGLCM25vRtrITkQEDY+hpF/ X-Received: by 2002:a17:906:9a1:: with SMTP id q1mr601124eje.296.1589915007620; Tue, 19 May 2020 12:03:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589915007; cv=none; d=google.com; s=arc-20160816; b=ubuQC9P5s5baJEA9QKg5INaoQA/CeRUFDjxt9EodHNuT7RuaBk0qv6BRFQexaLU2lN YYhRdK9wzB0QM1pcNeQZpKBeekvWN+vwBhKT08bFpqe849kWbNRSeNTgaQVgXnixPg5Q SlN/SApbVppdZXP27e+Q8I5qfFLkYTAy5X6CqfryOHruaY6jzkK2EUSD8SX7A/5Ifjw0 GOVHiBvBsSb+3NwvZH5WzF/jaWUAXm75mwQEnXOYuElsBUgdBj31nEkTBjVnM0bcmDa2 fMJTCXkXwwu7A2cHvh4yQI0ObmAmTjcJQrTObgGdUZscL+Ou5ziq8xGKywV8MSdEua/R lzrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=4++wg06Cok2ofHdP62DhzfCcT/qPf8o39XntsQLdYLQ=; b=kDq4YASq/MOZ5pyHTai1BZdxT796LuYQQz5vnzYx5OTCK0Rug3ECy0A4Wjt6qFO4AJ 0QFWNis7nkj6On4RIuGFpb9p4gpQsvl9JFxioajg24kFmbsCtLoHYpM4nCqwIileDM0+ eKgvIz/KhBm9g6Ua8IwznLJQAPszfGmONX0dxwFumX3V9loV7bGDC2Q+NiwTytD9VLdN meEXf1qIkJlt9/PJQ4UVq0qcaZ9C4JSFUjNI9IBsCwO/iVrHdjWONNonQ7WWwgEfUyBj XjkjD24qQI/kWuTgnlwBBU3JsKl4WWAmcl1Eoio7f+edwXL3ZnQVcoC/7lh4x5nNa18K qcmA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id be3si174562edb.12.2020.05.19.12.03.00; Tue, 19 May 2020 12:03:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727035AbgESTAp (ORCPT + 99 others); Tue, 19 May 2020 15:00:45 -0400 Received: from mga06.intel.com ([134.134.136.31]:62691 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726352AbgESTAp (ORCPT ); Tue, 19 May 2020 15:00:45 -0400 IronPort-SDR: vwky50IiyfCMFHsyjHNDpyQF6ffQBzJJo3cGzp8HGLJAQqSg8h/cNVvxzd85wObH2EjGclJMeB Y/XGOHHkqB+g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2020 12:00:44 -0700 IronPort-SDR: DPcoO8JWQyzvNdTE+i+NjsSRehFDDEuS8LYC9YUWq1IQeAtof4lmJM2bG07+MnU58PZIh1qInD p/nEVByMNVFQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,410,1583222400"; d="scan'208";a="264407484" Received: from joelin3-mobl.gar.corp.intel.com (HELO localhost) ([10.249.42.57]) by orsmga003.jf.intel.com with ESMTP; 19 May 2020 12:00:40 -0700 Date: Tue, 19 May 2020 22:00:36 +0300 From: Jarkko Sakkinen To: Nikita Sobolev Cc: Shuah Khan , linux-kselftest@vger.kernel.org, Tadeusz Struk , Joey Pabalinas , Petr Vorel , linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, Jason Gunthorpe , Peter Huewe , Alexey Brodkin , Eugeniy Paltsev , linux-snps-arc@lists.infradead.org Subject: Re: [PATCH v2] Kernel selftests: Add check if tpm devices are supported Message-ID: <20200519190023.GA22852@linux.intel.com> References: <20200519120743.41358-1-Nikita.Sobolev@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200519120743.41358-1-Nikita.Sobolev@synopsys.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 19, 2020 at 03:07:43PM +0300, Nikita Sobolev wrote: > tpm2 tests set uses /dev/tpm0 and /dev/tpmrm0 without check if they > are available. In case, when these devices are not available test > fails, but expected behaviour is skipped test. > > Signed-off-by: Nikita Sobolev See https://lore.kernel.org/linux-kselftest/20200519134838.GA17129@linux.intel.com/T/#mf762512a67f0b23db5663d6d67746cb94b812931 The comments about the fixes tag and acronym spelling were not addressed. The code change looks great tho now, thanks. /Jarkko