Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp3779733ybk; Tue, 19 May 2020 12:46:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJziGVOS4k86dJmkmUSuCyDyFYpHdByFAhriC+mNEtMaK81c73OirWDivd3FsQYS8Qtd5Imi X-Received: by 2002:a17:906:14cb:: with SMTP id y11mr714450ejc.131.1589917596357; Tue, 19 May 2020 12:46:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589917596; cv=none; d=google.com; s=arc-20160816; b=Nw3Fd1J23jCbCa84tn7eTiGhSOxqZHc7q17//+SksUNJxyu3QofQu2XPJiqfiZKffV A67TQBPF6uc7Gtxvx56DtPzBr7n8IUrl0DnjVuG3Pj0kz7fTB79qyfDaBqQkJcTtTIHQ v4rlUYMX7/iPSFMeQskdokHRXWEcSk6+WalbIvKYY/afg+3umm6JufCd2+ckimbfbsay 5dMH+PEHErIK1sqREEeR2STife2frGdk3F5iZcJ9StH3WrRWIvF9IHh59J1XctJoncpP mxg1SQBZYM5+Wf6xkBOLEt623Y+DBu7bAyV6ke43aKEsx6aVyNsylOhHt+xG6Olz6fAf gPpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=1PbPu9MDpsX7CWlzIANvDidpxlS/QMPqApRlwiiHNw8=; b=UwSr+qnYkf7FEMwNM8GUm4O71KIT/sbQxeua0mjB1wNaWZqi/30xWnUfu9Zv+nDthd O4DJNYMd/FelWjfZUKZ9Cm+ZfpHMNBQc3wm7yz+qn9sSdP1QMD4DoazEymvVxJKDHyWd 2JNKQRV4613WCUK1/zuAZ/Y4hHB3ZYfpZoHTM1uC0OC1lr7sXOClneSu7ezsvjOFdND7 IfBAa0f/jkXjjn2b0cgnW0+4+c9k6Z85Rzl0rL7A6xz+2oghegCLxaNv1SEyKGZaAt/l mumTgcY4DFW7JIqZBnbsmJUyJ/tS4uv/unsRwEhhVQ5yo8A/H1+T+FjzRJaOaNQDEoRl JuiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Azzo19mx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i29si211520edj.93.2020.05.19.12.46.13; Tue, 19 May 2020 12:46:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Azzo19mx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726870AbgESTmU (ORCPT + 99 others); Tue, 19 May 2020 15:42:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726059AbgESTmT (ORCPT ); Tue, 19 May 2020 15:42:19 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C72EC08C5C0; Tue, 19 May 2020 12:42:18 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id t7so322568plr.0; Tue, 19 May 2020 12:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1PbPu9MDpsX7CWlzIANvDidpxlS/QMPqApRlwiiHNw8=; b=Azzo19mxTglIY2DWsdeqvJCJvbRFWfMvCqe910K+bLoZcz9A0rEclUKyMtzUQpeHzC onlWdkJh3IcWILK4c2hRtOtl7mRzAbiyLlEcJdxmOebPU1v944BfCUyeskdH4MaSANGB mG1De8kuL8xqrOY6I9z2/irGnDdt+dXuW+nblD5+Bi7nB5W52s0/6ICGfZDepT9Noian auesxCt7/j2cCzmSLOIHL82Wa50HphpyDMpe82o3c9PeVBitNH+3VinlNYT9yXfWiYMK CoPZr98AYh6qGXAhrwf3fwANeJXKXy93GRy48lcmGQT0TIdmPLv0mxuhYKT+dVSO6mfx T51Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=1PbPu9MDpsX7CWlzIANvDidpxlS/QMPqApRlwiiHNw8=; b=muQgYRs8PWFmw+0Q6zo9YE+N4fpk8xc2fojL7wA7X1hgYOeeIAvhVdb/eT8P9Xyci+ mAib5D42bW08+zF3cWsU5GvG/9kkf0BiU3ouZQQuv5GS5/TZmncYnEAorXo0LMmNxw1+ GG7kmDGE9fEABTWzI6Ljo38Z6yO2JFmGNn6scls6fjCEH35Md/UI7Vv1Bx5YId7or8bc Rj7x+cHMooknGwvjX78/eAaIPlWzg9RBhvIIBf+BxIHfDMNKlidplTsWg5o+gHqxA5n7 YsfvIcw8yYAJzn/EH3JWW411lPQfeWxK9CS8gpMEZMIV8Wm11cfOG/q46At9t5Sbq5nU OLqA== X-Gm-Message-State: AOAM531JoJhSFEwRJv9NnJz741pbTd/XZMK6SmJlVeDjt0YlN/iFxY3L p9GlTG79r8itb6mg0+LQvPU= X-Received: by 2002:a17:90a:4811:: with SMTP id a17mr1198137pjh.130.1589917337613; Tue, 19 May 2020 12:42:17 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id x5sm234038pfq.196.2020.05.19.12.42.16 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 May 2020 12:42:16 -0700 (PDT) Date: Tue, 19 May 2020 12:42:15 -0700 From: Guenter Roeck To: Ira Weiny Cc: linux-kernel@vger.kernel.org, Andrew Morton , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Chris Zankel , Max Filippov , Dan Williams , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, dri-devel@lists.freedesktop.org, Christian Koenig , Al Viro , Christoph Hellwig Subject: Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice Message-ID: <20200519194215.GA71941@roeck-us.net> References: <20200507150004.1423069-8-ira.weiny@intel.com> <20200518184843.3029640-1-ira.weiny@intel.com> <20200519165422.GA5838@roeck-us.net> <20200519184031.GB3356843@iweiny-DESK2.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200519184031.GB3356843@iweiny-DESK2.sc.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 19, 2020 at 11:40:32AM -0700, Ira Weiny wrote: > On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: > > On Mon, May 18, 2020 at 11:48:43AM -0700, ira.weiny@intel.com wrote: > > > From: Ira Weiny > > > > > > The kunmap_atomic clean up failed to remove one set of pagefault/preempt > > > enables when vaddr is not in the fixmap. > > > > > > Fixes: bee2128a09e6 ("arch/kunmap_atomic: consolidate duplicate code") > > > Signed-off-by: Ira Weiny > > > > microblazeel works with this patch, > > Awesome... Andrew in my rush yesterday I should have put a reported by on the > patch for Guenter as well. > > Sorry about that Guenter, No worries. > Ira > > > as do the nosmp sparc32 boot tests, > > but sparc32 boot tests with SMP enabled still fail with lots of messages > > such as: > > > > BUG: Bad page state in process swapper/0 pfn:006a1 > > page:f0933420 refcount:0 mapcount:1 mapping:(ptrval) index:0x1 > > flags: 0x0() > > raw: 00000000 00000100 00000122 00000000 00000001 00000000 00000000 00000000 > > page dumped because: nonzero mapcount > > Modules linked in: > > CPU: 0 PID: 1 Comm: swapper/0 Tainted: G B 5.7.0-rc6-next-20200518-00002-gb178d2d56f29 #1 > > [f00e7ab8 : > > bad_page+0xa8/0x108 ] > > [f00e8b54 : > > free_pcppages_bulk+0x154/0x52c ] > > [f00ea024 : > > free_unref_page+0x54/0x6c ] > > [f00ed864 : > > free_reserved_area+0x58/0xec ] > > [f0527104 : > > kernel_init+0x14/0x110 ] > > [f000b77c : > > ret_from_kernel_thread+0xc/0x38 ] > > [00000000 : > > 0x0 ] > > > > Code path leading to that message is different but always the same > > from free_unref_page(). > > > > Still testing ppc images. > > ppc image tests are passing with this patch. Guenter