Received: by 2002:a17:90a:bc8d:0:0:0:0 with SMTP id x13csp2406494pjr; Tue, 19 May 2020 14:33:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwkyGzZmtjH/SuF0Lsw6k/UEPiOrbRgauyTjaqcUgku9oVHTGihSMX60WVZGjAJz6dlaUu/ X-Received: by 2002:a05:6402:b0b:: with SMTP id bm11mr762648edb.92.1589924002471; Tue, 19 May 2020 14:33:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589924002; cv=none; d=google.com; s=arc-20160816; b=fRFtknVXvH5jWnT/YuvW0P/HksgUDOG0WDkZ5juYCwShp8Yd1UhespXq/yHuwNoHxL A8XTPteyqh0u7Ix+Ab9ksT/99jG2zG3cni79zcOSiwjrTZWEShim9mMY1w+gGNJ6p2h2 g/dJ7/E/L4IIGctE4sClFNQKUDVSyE1/LRs1+/Q7vArnkzdzGT3JwintnbBi8qa/w/Ho Or1hEtQui/KsfevLYmmEu3Td5iFAvsDszoMgntsf3b+NGX88JcS/ZW5mEUvR4ZOTrzjL 8k1jbFdNKU5k7oJ+6J4qh18KrnX7rdrys6fTXHwBHyVP+MejNSaOuQYr236w998alWF6 pRtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=SIFdEg6GcNVZI8m+o4nVBjfAN7p3vODxjCvJqV3wrjs=; b=bUJMgBawTNR2h/O38TT4ktZFOx9OQq4TLQESYAI5WVXEbgSU822Ih/vCuCcK3fVkbt wjBuUlZNnF1iKatqLXJGCFDA45j0oOIHuF6NU/q99W9+k3QPPmAHmYgivfhPauylSPTy RpCf6IQ8voPNRi7cABoTKDjCZVfvPNgfC8U4ttzyZgMcRq1owM+XqqrqdyOA2mDFhHP+ qv5Ew8YSlsx8APEPkucJhiAyH819Y9+XzE4EFbIILe+4ttPrW7X6SrAuIdHc8p7qszbn eMmJs6NBs7+0r9rQSfuPrgDLThpYn9sWNNcIVGnhvcEsYBkmaCp4AS5zv5ekoTwrVPZ7 tTRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=elpzgzYG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id do5si785861ejc.105.2020.05.19.14.32.41; Tue, 19 May 2020 14:33:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=elpzgzYG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726944AbgESVa5 (ORCPT + 99 others); Tue, 19 May 2020 17:30:57 -0400 Received: from mail.skyhub.de ([5.9.137.197]:59356 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725998AbgESVa5 (ORCPT ); Tue, 19 May 2020 17:30:57 -0400 Received: from zn.tnic (p200300ec2f0b87001461a870af27ee92.dip0.t-ipconnect.de [IPv6:2003:ec:2f0b:8700:1461:a870:af27:ee92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id BB1E71EC0116; Tue, 19 May 2020 23:30:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1589923855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=SIFdEg6GcNVZI8m+o4nVBjfAN7p3vODxjCvJqV3wrjs=; b=elpzgzYGuUqgOZ3iYwPwU0vO4iNdx7ImGZaBt7EQOXNb+jjkafEqyQpW7/epigIv/Spf0K HPcTyH+9mfJ2d7vnUPk4cNe0LV9L1OU/87vuRpdk0aS+5+kFWhYU6Qs855zaKvaYwie5HC cAlV/DSXMwn0XqpSZmoKfGrJLjeeLGo= Date: Tue, 19 May 2020 23:30:50 +0200 From: Borislav Petkov To: Robert Richter Cc: Mauro Carvalho Chehab , Tony Luck , James Morse , Aristeu Rozanski , Matthias Brugger , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] EDAC/ghes: Setup DIMM label from DMI and use it in error reports Message-ID: <20200519213050.GE444@zn.tnic> References: <20200518095852.28010-1-rrichter@marvell.com> <20200519202535.GC444@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200519202535.GC444@zn.tnic> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 19, 2020 at 10:25:35PM +0200, Borislav Petkov wrote: > but I'm guessing that dmi_memdev_name() doesn't give on my machine what > it gives on yours. IOW, this ontop: diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c index c7d404629863..f84c117c4310 100644 --- a/drivers/edac/ghes_edac.c +++ b/drivers/edac/ghes_edac.c @@ -109,9 +109,9 @@ static void dimm_setup_label(struct dimm_info *dimm, u16 handle) if (bank && *bank && device && *device) snprintf(dimm->label, sizeof(dimm->label), "%s %s", bank, device); - else - snprintf(dimm->label, sizeof(dimm->label), - "unknown memory (handle: 0x%.4x)", handle); + /* + * else fallback to the EDAC default name. + */ } static void ghes_edac_dmidecode(const struct dmi_header *dh, void *arg) -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette