Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 19 May 2020 14:46:37 -0700
From:   Matt Helsley <mhelsley@vmware.com>
To:     Josh Poimboeuf <jpoimboe@redhat.com>
CC:     <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Julien Thierry <jthierry@redhat.com>,
        Miroslav Benes <mbenes@suse.cz>,
        Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 3/3] objtool: Enable compilation of objtool for all
 architectures
Message-ID: <20200519214637.GS9040@rlwimi.vmware.com>
Mail-Followup-To: Matt Helsley <mhelsley@vmware.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>, linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Julien Thierry <jthierry@redhat.com>,
        Miroslav Benes <mbenes@suse.cz>,
        Steven Rostedt <rostedt@goodmis.org>
References: <cover.1589913349.git.mhelsley@vmware.com>
 <96252a8eee50710f4fe115ca516f0e6058b9f66b.1589913349.git.mhelsley@vmware.com>
 <20200519211829.p2d454nz3h3mdxsa@treble>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20200519211829.p2d454nz3h3mdxsa@treble>
Received-SPF: None (EX13-EDG-OU-001.vmware.com: mhelsley@vmware.com does not
 designate permitted sender hosts)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, May 19, 2020 at 04:18:29PM -0500, Josh Poimboeuf wrote:
> On Tue, May 19, 2020 at 01:55:33PM -0700, Matt Helsley wrote:
> > +const char __attribute__ ((weak)) *objname;
> > +
> > +int missing_check(const char *_objname, bool orc)
> > +{
> > +	return 127;
> > +}
> > +
> > +int __attribute__ ((weak, alias("missing_check"))) check(const char *_objname, bool orc);
> > +
> > +int missing_orc_dump(const char *_objname)
> > +{
> > +	return 127;
> > +}
> > +
> > +int __attribute__ ((weak, alias("missing_orc_dump"))) orc_dump(const char *_objname);
> > +
> > +int __attribute__ ((weak)) create_orc(struct objtool_file *file)
> > +{
> > +	return 127;
> > +}
> > +
> > +int __attribute__ ((weak)) create_orc_sections(struct objtool_file *file)
> > +{
> > +	return 127;
> > +}
> 
> I think the aliased "missing_" functions are no longer needed, right?
> i.e. can we just have weak versions of check() and orc_dump()?

Oops, Yeah, we can remove those aliases. I can fix and resend this one if you
like. 

> Otherwise everything looks good to me.

Excellent. I'm thinking I'll get the relocs patches posted as an RFC next...

Cheers,
	-Matt