Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp62861ybk; Tue, 19 May 2020 15:34:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwf+gTl9VG0I6KreCwxYG8x6sJTHAWjSbVijpRfUyCMN7HlIaLU4rbCrOSiY9hgX1WMOrfP X-Received: by 2002:a50:a7e3:: with SMTP id i90mr921276edc.6.1589927677896; Tue, 19 May 2020 15:34:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589927677; cv=none; d=google.com; s=arc-20160816; b=eDNjrcUx1CZUv5DU43/BNqWFPlFxBx7xIR9OiAVqtq+K4QgxP4pGk7CbHjRBo5OZ7a cRknxoHUHdMc/E7yubWOyBbFg+Nz1GtNe3qR79Y2WL+0BGMC7xYkZ+rts6XAKGFPkf3K H5oiotqYpL3twcUMlMAUCp5p2YJr2kpZbTBQV16OrHYav63wuKtG2HSn9PdjUYyGHC4t qn6pi1HkEPebHThcickS7tflzjfLLU/YrRuLHOEgZkJm8AlGmKWqFbn4PPl4LTMWuXB2 EfpnL9VPcdZkWU4NieRXw5si28nF4yU5svok+XnTlsgvSDbEp2GRaNyR/mvxHYgv6Jo3 X50Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=jxXL0WdlpTaBoGwkGfHym50yfgoALKhNYzEYBq+gcoM=; b=gkl/F4pLV/MwIcsm1kvlOvNEgaYuQgD6oNgJRpaYsBphBA1Z5YUtcUyVC9WSFFnXWA 4qVyL6Km6tbSgswptiiWAbpak0lMlgcIJD24eNJRvv3XDRSjzQrxbqqD6aAJoInw5uRN oIm8BZ5bGgbacoexlZBTDsBiSsSDs94zKKub8DevqjWa3qTjQnLCHoDUTgzFtSEh/PmA R4aj6BsoceFcz/+gojYQ2W839NU0gsjRHjbUtTB7pY0bh/JI+aEQuOGiEndTYIjp2nCB KvRk9MbXJC2Lcywt/u0XmkIfuc6tLWnfrbFwpP8sxCfj5qlW5yAQjtLAU44IKCUPb8AI KgYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c3si721495eja.251.2020.05.19.15.34.10; Tue, 19 May 2020 15:34:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726999AbgESWcn (ORCPT + 99 others); Tue, 19 May 2020 18:32:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726064AbgESWcm (ORCPT ); Tue, 19 May 2020 18:32:42 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D91A5C061A0E; Tue, 19 May 2020 15:32:42 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 3A188128EDAAA; Tue, 19 May 2020 15:32:41 -0700 (PDT) Date: Tue, 19 May 2020 15:32:39 -0700 (PDT) Message-Id: <20200519.153239.1577517664546707472.davem@davemloft.net> To: vaibhavgupta40@gmail.com Cc: hkallweit1@gmail.com, vaibhav.varodek@gmail.com, netdev@vger.kernel.org, helgaas@kernel.org, bhelgaas@google.com, bjorn@helgaas.com, linux-kernel-mentees@lists.linuxfoundation.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, skhan@linuxfoundation.org Subject: Re: [PATCH net-next v3 0/2] realtek ethernet : use generic power management. From: David Miller In-Reply-To: <20200518150214.100491-1-vaibhavgupta40@gmail.com> References: <20200518150214.100491-1-vaibhavgupta40@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 19 May 2020 15:32:41 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vaibhav Gupta Date: Mon, 18 May 2020 20:32:12 +0530 > The purpose of this patch series is to remove legacy power management callbacks > from realtek ethernet drivers. > > The callbacks performing suspend() and resume() operations are still calling > pci_save_state(), pci_set_power_state(), etc. and handling the powermanagement > themselves, which is not recommended. > > The conversion requires the removal of the those function calls and change the > callback definition accordingly. > > All Changes are compile-tested only. Series applied, thanks.