Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751137AbWCOU2N (ORCPT ); Wed, 15 Mar 2006 15:28:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751169AbWCOU2N (ORCPT ); Wed, 15 Mar 2006 15:28:13 -0500 Received: from nommos.sslcatacombnetworking.com ([67.18.224.114]:37268 "EHLO nommos.sslcatacombnetworking.com") by vger.kernel.org with ESMTP id S1751137AbWCOU2L (ORCPT ); Wed, 15 Mar 2006 15:28:11 -0500 In-Reply-To: References: <20060315193114.GA7465@in.ibm.com> <1142452665.3021.43.camel@laptopd505.fenrus.org> Mime-Version: 1.0 (Apple Message framework v746.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <006E591F-5F82-4B79-8D1A-581B6AF00185@kernel.crashing.org> Cc: Arjan van de Ven , vgoyal@in.ibm.com, linux kernel mailing list , Fastboot mailing list , Morton Andrew Morton , gregkh@suse.de Content-Transfer-Encoding: 7bit From: Kumar Gala Subject: Re: [RFC][PATCH] Expanding the size of "start" and "end" field in "struct resource" Date: Wed, 15 Mar 2006 14:28:42 -0600 To: ebiederm@xmission.com (Eric W. Biederman) X-Mailer: Apple Mail (2.746.3) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - nommos.sslcatacombnetworking.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - kernel.crashing.org X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1318 Lines: 42 On Mar 15, 2006, at 2:13 PM, Eric W. Biederman wrote: > Kumar Gala writes: > >> On Mar 15, 2006, at 1:57 PM, Arjan van de Ven wrote: >> >>> >>>> One of the possible solutions to this problem is that expand the >>>> size >>>> of "start" and "end" to "unsigned long long". But whole of the >>>> PCI and >>>> driver code has been written assuming start and end to be >>>> unsigned long >>>> and compiler starts throwing warnings. >>> >>> >>> please use dma_addr_t then instead of unsigned long long >>> >>> this is the right size on all platforms afaik (could a ppc64 person >>> verify this?> ;) >> >> Actually we really just want "start" and "end" to be u64 on all >> platforms. >> Linus was ok with this change but no one has gone through and >> fixed everything >> that would be required for it. > > Since it is faster to ask :) > > How is it that other pieces of code have problems? > Warnings or something nasty? Warnings primarily, however I think some places have assumptions about size that have to be looked at. - kumar - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/