Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp202249ybk; Tue, 19 May 2020 19:59:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHoM2kbE9tNxYSvxIQq1tB7TVoQ0I+1VYTnx4tucavIT2MU54x8E8GopQIO6H2L4P5ciRs X-Received: by 2002:a50:f057:: with SMTP id u23mr1421330edl.238.1589943568735; Tue, 19 May 2020 19:59:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589943568; cv=none; d=google.com; s=arc-20160816; b=KhkfOgGJouPuXi78xg5ZoBIr1Yw39PXa4sb3HhaBpbLpe+bElMGTt6ZCPDgP+RJAbS 8u5VrfBfY9b4YgGNCtfJCRgLnvRGr186X+B0PZnfXj8wI+PMDmX8vmw69cqJyoaE4h+Y tjCjVNH0CCdZIKhdT0mgZcrwstOfhPgG89puc+gqUPFJmR2vfdsxG7FbznKQkcQJI9H5 EeiAnUV1fh/aW+7wtQ3i0oIeO/qH2eaHkcOb2qpmW6rTfYGcWQkaN1T1eq3WJw/Rnnm+ H0ycqc6ZzP8hY/SmXrFjuMTvOCrzVnqGMDzjjwhWH5850bqXlGBEgjHUPxAoZqlQefKC dBgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=MSV/ggafhJ4wR2Z9eAQZCD9tFbdFHTOr5J632MAabxY=; b=Tn/15KK6pgz0HBxpKdwxdUKVrrgk4mrJLBayLDwvpeBD/SNmJ/YJjw954hBjf7HInB 98GQnAZcHDwnf4jdkovSo+QJRiNiLi1rGGEnE64Ru8k6JE+qV2LfQklMQztCme/HTeX9 ognJKPYmiMq825x9ci+224KhRhOcvNJy+r0CTUI8QPLvW2TLht4XLu7GxcivfDHBvlM+ VZKfVooT1G5rwvOJtdxqRJ8Okx8Kt6ULTrvSJeKsduhb8L61PF4WWW7WvyZ0t0gAconD qwBljGbi/FFv40q1sgv/voMGF2k5CZX+giT8fmde16/7N6l3GrrpeyOqj2v/WHlNzaWH iuTg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id pg8si1031532ejb.607.2020.05.19.19.59.06; Tue, 19 May 2020 19:59:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728631AbgETC5Y (ORCPT + 99 others); Tue, 19 May 2020 22:57:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726318AbgETC5Y (ORCPT ); Tue, 19 May 2020 22:57:24 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32449C061A0E; Tue, 19 May 2020 19:57:24 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 4069512942617; Tue, 19 May 2020 19:57:23 -0700 (PDT) Date: Tue, 19 May 2020 19:57:22 -0700 (PDT) Message-Id: <20200519.195722.1091264300612213554.davem@davemloft.net> To: tglx@linutronix.de Cc: stephen@networkplumber.org, a.darwish@linutronix.de, peterz@infradead.org, mingo@redhat.com, will@kernel.org, paulmck@kernel.org, bigeasy@linutronix.de, rostedt@goodmis.org, linux-kernel@vger.kernel.org, kuba@kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v1 01/25] net: core: device_rename: Use rwsem instead of a seqcount From: David Miller In-Reply-To: <87lfln5w61.fsf@nanos.tec.linutronix.de> References: <87v9kr5zt7.fsf@nanos.tec.linutronix.de> <20200519161141.5fbab730@hermes.lan> <87lfln5w61.fsf@nanos.tec.linutronix.de> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 19 May 2020 19:57:23 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thomas Gleixner Date: Wed, 20 May 2020 01:42:30 +0200 > Stephen Hemminger writes: >> On Wed, 20 May 2020 00:23:48 +0200 >> Thomas Gleixner wrote: >>> No. We did not. -ENOTESTCASE >> >> Please try, it isn't that hard.. >> >> # time for ((i=0;i<1000;i++)); do ip li add dev dummy$i type dummy; done >> >> real 0m17.002s >> user 0m1.064s >> sys 0m0.375s > > And that solves the incorrectness of the current code in which way? You mentioned that there wasn't a test case, he gave you one to try.