Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peng Fan <peng.fan@nxp.com>
To:     Fabio Estevam <festevam@gmail.com>,
        "jassisinghbrar@gmail.com" <jassisinghbrar@gmail.com>
CC:     "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "o.rempel@pengutronix.de" <o.rempel@pengutronix.de>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] mailbox: imx: Disable the clock on
 devm_mbox_controller_register() failure
Thread-Topic: [PATCH] mailbox: imx: Disable the clock on
 devm_mbox_controller_register() failure
Thread-Index: AQHWLlXFx6d57+barUeOxi2c3HgBpaiwUHEg
Date:   Wed, 20 May 2020 03:27:50 +0000
Message-ID: <DB6PR0402MB2760C33F17B6234DBDB560C188B60@DB6PR0402MB2760.eurprd04.prod.outlook.com>
References: <20200520032246.12482-1-festevam@gmail.com>
In-Reply-To: <20200520032246.12482-1-festevam@gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 24fdc845-60f1-454e-93c8-08d7fc6dc688
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2020 03:27:50.7689
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0thifexUU2DOLrVJi5bU6oeONybxAa8BbFPSWUuEEf7nRThD3WXtuenSItqYgNSYFlnLRxI7fZqImYU2OWf0Jw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2726
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH] mailbox: imx: Disable the clock on
> devm_mbox_controller_register() failure
>=20
> devm_mbox_controller_register() may fail, and in the case of failure the
> priv->clk clock that was previously enabled, should be disabled.
>=20
> Fixes: 2bb7005696e2 ("mailbox: Add support for i.MX messaging unit")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> ---
>  drivers/mailbox/imx-mailbox.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.=
c
> index 7906624a731c..3f7c4548c18f 100644
> --- a/drivers/mailbox/imx-mailbox.c
> +++ b/drivers/mailbox/imx-mailbox.c
> @@ -508,7 +508,13 @@ static int imx_mu_probe(struct platform_device
> *pdev)
>=20
>  	platform_set_drvdata(pdev, priv);
>=20
> -	return devm_mbox_controller_register(dev, &priv->mbox);
> +	ret =3D devm_mbox_controller_register(dev, &priv->mbox);
> +	if (ret) {
> +		clk_disable_unprepare(priv->clk);
> +		return ret;
> +	}
> +
> +	return 0;
>  }
>=20
>  static int imx_mu_remove(struct platform_device *pdev)
> --
> 2.17.1