Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 20 May 2020 06:52:05 +0200
From:   Oleksij Rempel <o.rempel@pengutronix.de>
To:     Fabio Estevam <festevam@gmail.com>
Cc:     jassisinghbrar@gmail.com, kernel@pengutronix.de, linux-imx@nxp.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mailbox: imx: Disable the clock on
 devm_mbox_controller_register() failure
Message-ID: <20200520045205.ag6i7z2xmeenmqpg@pengutronix.de>
References: <20200520032246.12482-1-festevam@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="7bmp72cg7y2mwspo"
Content-Disposition: inline
In-Reply-To: <20200520032246.12482-1-festevam@gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--7bmp72cg7y2mwspo
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 20, 2020 at 12:22:46AM -0300, Fabio Estevam wrote:
> devm_mbox_controller_register() may fail, and in the case of failure the
> priv->clk clock that was previously enabled, should be disabled.
>=20
> Fixes: 2bb7005696e2 ("mailbox: Add support for i.MX messaging unit")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>

> ---
>  drivers/mailbox/imx-mailbox.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
> index 7906624a731c..3f7c4548c18f 100644
> --- a/drivers/mailbox/imx-mailbox.c
> +++ b/drivers/mailbox/imx-mailbox.c
> @@ -508,7 +508,13 @@ static int imx_mu_probe(struct platform_device *pdev)
> =20
>  	platform_set_drvdata(pdev, priv);
> =20
> -	return devm_mbox_controller_register(dev, &priv->mbox);
> +	ret =3D devm_mbox_controller_register(dev, &priv->mbox);
> +	if (ret) {
> +		clk_disable_unprepare(priv->clk);
> +		return ret;
> +	}
> +
> +	return 0;
>  }
> =20
>  static int imx_mu_remove(struct platform_device *pdev)
> --=20
> 2.17.1
>=20
>=20

--=20
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

--7bmp72cg7y2mwspo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEERBNZvwSgvmcMY/T74omh9DUaUbMFAl7Et3QACgkQ4omh9DUa
UbPjEA//QgEWw4m0bNgKXh2n+zSBOgCnjZFToTsq9sSFbM9hszMEF2qZv/Ju2H2D
ntWUnL8j66M6A33GfGQlPJKf1ZJIgVAP7In//Xk0/TBDi+qakmYTTnm54b44HjW8
N6RBOUExlFiiJAxuzlvidOy01HctuAMC2WRzyIqrMv//WubrbrmalllYnysJAEE9
R5SjJqYxuV8RBl7nZHsMd0CFC4fUS3LYfCd6nNGYyvEfBbuLxJgRQgp+FohQapkT
g25wH8RKk82Rqf+nlFtnen2l76NYwMxzZVx+x5Bci6qumFUYKmL4aVNFqZYQBATO
9TLAFyVN4FqFQormzZuNfXDrjsmhf9AfNuSTcfDVXpWuT5zpLwPihtu8Iq91lUsC
tNFH5W2zAvBWhrRHkT4M5oY6zPigjeagrMpUmzBmCG2ptCRTbHzYTKKhmdSFLQXE
PcdQfMdsh7R2COkGiRQQJmB0n9BrON6ybVDTb+U4a8clOJIvmRH2+0jkoO3TfoAu
T1KP08ACcV4BbbsfNyvpSLwDy5etVydDbyVFDwPOxB+UIAoH8b8I2WuLeEVkOxQQ
0nFTc8upPqCqk5QcFNl6LtpMloltfqLj0i3C2iuHA09f5M8D3XV+5b/HO2lI0+e6
6d1//OLVj6SolMzqQ40o5lkuQ29KSt1l6LI0RyL0F1vDGzGzU3s=
=d9Sl
-----END PGP SIGNATURE-----

--7bmp72cg7y2mwspo--