Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp457351ybk; Wed, 20 May 2020 04:05:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGlcDkSewbsqEi5aplVzQpCJZdTO3EomNn3vhE4dhipSTE0XbzubhrDZod2tWourabx2qT X-Received: by 2002:a05:6402:3076:: with SMTP id bs22mr2945262edb.161.1589972720323; Wed, 20 May 2020 04:05:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589972720; cv=none; d=google.com; s=arc-20160816; b=w7Fhzm4+KMqp0JTMbcaWjvZmEq6mW8kg2145i5TfdfttBs3n2Y0z0eHhYu20bebL2l cLwGvQFRu4+PFlm/LxAFNmRc45XdPP+EUcIX1ihnVnIUJ0RoOGxl9uPS98lCdAdIeXit 35I1Xo7XwQ5PuEvb9c883jDceRru5UNVDIkQQAWZ0yee7O9D0ocXl5UroM3UMBvJ9R+l WqawF6GeXQeldAFJyDkySKwbC00jbYaJM9ypxC4Sy2K7tGN4rDEsW/KVpHl9Vny60/62 IVG0OZg/2eJ194ltubpPKPTT3sCeFuJ1vL7nm3GuiOhN+wkGGwMkU4kyHXUIF93ScEuu +sOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=VNz0a2EJj80b4yeRQXHVRRn3nEHHKr03ijj9QvQzWgw=; b=uvwjcuwUChgLg4uqIny57O628c0mXFXxhKyqB7zvfdzU99GMl9Wd0/F9WlyrZhxKao jVPjSWDS0KZacsLNdJb9HSRl6ZpeU49iVAZHaBTnA9Nfuc9hOE6Ssy7vmc9ZCacbTWfn N631SGzob65dE9QeoR1Cud7cJovNbOObhoQlT3ZKxVS/RCyhaCjOfsY8c6lqSi5BKGGF JqmgHRad910/WE5+UjzUxQia0frneJesy/xSIECnvMh4wx3kaBssDGscEKUym5O/ggPt KH4JgD07XaYz7Z4sTAStyrLZCX/U1rNIFuPHG0lZIaOY1/8hEOgHpKGR+lBBnoeURq/W ktpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=HACMClLg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m22si1548984eja.636.2020.05.20.04.04.57; Wed, 20 May 2020 04:05:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=HACMClLg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726810AbgETLDY (ORCPT + 99 others); Wed, 20 May 2020 07:03:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726403AbgETLDY (ORCPT ); Wed, 20 May 2020 07:03:24 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52835C061A0E; Wed, 20 May 2020 04:03:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VNz0a2EJj80b4yeRQXHVRRn3nEHHKr03ijj9QvQzWgw=; b=HACMClLgVKLQEUF7EKFXvEb1cy 1Lk9V8pnMfXwLY407L0lnny9mSZtKC8kQ7gw1b+b+D8D0SBJWuLPqCm8Pr5cuCVy6Brer5QF5bUx6 8rGK+97dKCunJglGFg6pLAP66awTkvWhqgMKUxv/EYi4YdTN19YiUGU9E3MhxA8IsvpO7nEzI+8nn dbQGU9XfqCPcjfN8EUHXFQlRUGVL1UWH8VvFBUuZfZLkdZTwK4l1VASFU9VPPsFZm+IPvmPJbAKyt fa/tK6UrAQyhCU09gXfUrmNcRbVwYKn5rihAXcnAY3OQf3bMS/DwlXg2/E4w8P+gm+Iysk6XWZqRc voQxD5jg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbMVI-0004qO-T0; Wed, 20 May 2020 11:03:17 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 152FD306089; Wed, 20 May 2020 13:03:15 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id F1A6629D896D8; Wed, 20 May 2020 13:03:14 +0200 (CEST) Date: Wed, 20 May 2020 13:03:14 +0200 From: Peter Zijlstra To: Sebastian Andrzej Siewior Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Steven Rostedt , Will Deacon , Thomas Gleixner , "Paul E . McKenney" , Linus Torvalds , Mike Galbraith , Evgeniy Polyakov , netdev@vger.kernel.org Subject: Re: [PATCH 6/8] connector/cn_proc: Protect send_msg() with a local lock Message-ID: <20200520110314.GI317569@hirez.programming.kicks-ass.net> References: <20200519201912.1564477-1-bigeasy@linutronix.de> <20200519201912.1564477-7-bigeasy@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200519201912.1564477-7-bigeasy@linutronix.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 19, 2020 at 10:19:10PM +0200, Sebastian Andrzej Siewior wrote: > @@ -40,10 +41,11 @@ static struct cb_id cn_proc_event_id = { CN_IDX_PROC, CN_VAL_PROC }; > > /* proc_event_counts is used as the sequence number of the netlink message */ > static DEFINE_PER_CPU(__u32, proc_event_counts) = { 0 }; > +static DEFINE_LOCAL_LOCK(send_msg_lock); Put it in a struct ?