Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: qzy7/cdMpUZ8dyCUFDUz2huK80ibYlYixSSNuwN1rRqgrLVTBhA5rFgQI8Fq8CX8LTK28RflbU
 XTmEe/AJY95g==
IronPort-SDR: YxqroxTKwIzxY6ucUpAnsBTI86ASQQd6VG2HGha0NGmWLHK5WVOwbOqYDto+t9MKbXk4o3xVNm
 sBH+BSYuEiVw==
Date:   Wed, 20 May 2020 17:00:44 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To:     Borislav Petkov <bp@alien8.de>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        linux-sgx@vger.kernel.org, akpm@linux-foundation.org,
        dave.hansen@intel.com, sean.j.christopherson@intel.com,
        nhorman@redhat.com, npmccallum@redhat.com, haitao.huang@intel.com,
        andriy.shevchenko@linux.intel.com, tglx@linutronix.de,
        kai.svahn@intel.com, josh@joshtriplett.org, luto@kernel.org,
        kai.huang@intel.com, rientjes@google.com, cedric.xing@intel.com,
        puiterwijk@redhat.com, Jethro Beekman <jethro@fortanix.com>
Subject: Re: [PATCH v30 01/20] x86/cpufeatures: x86/msr: Add Intel SGX
 hardware bits
Message-ID: <20200520140044.GA34750@linux.intel.com>
References: <20200515004410.723949-1-jarkko.sakkinen@linux.intel.com>
 <20200515004410.723949-2-jarkko.sakkinen@linux.intel.com>
 <20200520121604.GF1457@zn.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200520121604.GF1457@zn.tnic>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, May 20, 2020 at 02:16:21PM +0200, Borislav Petkov wrote:
> On Fri, May 15, 2020 at 03:43:51AM +0300, Jarkko Sakkinen wrote:
> > From: Sean Christopherson <sean.j.christopherson@intel.com>
> > 
> > Add X86_FEATURE_SGX from CPUID.(EAX=7, ECX=1), which informs whether the
> > CPU has SGX.
> > 
> > Add X86_FEATURE_SGX1 and X86_FEATURE_SGX2 from CPUID.(EAX=12H, ECX=0),
> > which describe the level of SGX support available [1].
> > 
> > Remap CPUID.(EAX=12H, ECX=0) bits to the Linux fake CPUID 8 in order to
> > conserve some space. Keep the bit positions intact because KVM requires
> > this. Reserve bits 0-7 for SGX in order to maintain this invariant also
> > when new SGX specific feature bits get added.
> 
> That paragraph needs dropping now.

I dropped it (in my tree).

> -- 
> Regards/Gruss,
>     Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette

/Jarkko