Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp649644ybk; Wed, 20 May 2020 08:33:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzWIpQUTgBxMhyZg0NZeIZWkkPSQLnws1BfaeJp1h0ZO89RHNJBaf/gTxNN8MPBFwMtgbp6 X-Received: by 2002:a17:906:310e:: with SMTP id 14mr4325643ejx.177.1589988830837; Wed, 20 May 2020 08:33:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589988830; cv=none; d=google.com; s=arc-20160816; b=o+DhHl8G8OJobTtO6IXRL0Ou/ggXmSMGQh14Jnx1PhW/7H3EwqX3Hzh9+GYSyn7Nn2 cyty009OkTSvl1TwzC9/WQbZ/2ENPZYPrKl9ZBluqt9Y4qpl9V2xjK0hVhXfv7VHcpSr cYG26hfgeE6uXzXxNKdB/WfdMYTcATviFRAlj7mexkOVI8O8L1/psTMBTUzF84HmX43e qJl2mGinjqoSl5OSNZpP5g/uxT8ta0tFPD7HZWSoO1XQfic96oiHeRq2dUNDP5oQL4Qc ITbCxtKsd6LwMTDYM8IdEw9/NCqwk7TGnXL6vYiabReGeE950sW81TlvWONIf/kKM2KS DUTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :dlp-reaction:dlp-version:dlp-product:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=0MjFLctcSugzSb8OacPGd+aATzdSmHt0WQDL94gKM9c=; b=bZy+5X5XVzO7JKG0kNFwiv/ARKahwxIHiof+l/zJpYJDPzRlZLnBsKkDcVni+OjpJT Weq4wGNUA267wyo9pWI90nxmegA2QUUDSsGLvptvxsc21YWIpz5hNQl+tWZAhEfcWMKL LFD/jTnkmXYFmjkL7exJyF68d4szztF4EtkOQOG2W6KaLH2R48arM1KVBAYGysGKPByE FipaaUXANKmV3w5XKjPdnaG5nooZat/juFlC+3WWiNGvD66xn97yqP4Tet8PkfT9IwoI zZfdAFoJO2nXfbwuKrB6as6+fpvWfbNIFudPQgFVTtClANE/84iJsQurEp4CdZ8745ry x7hA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p21si1794482ejw.285.2020.05.20.08.33.24; Wed, 20 May 2020 08:33:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726830AbgETPb0 (ORCPT + 99 others); Wed, 20 May 2020 11:31:26 -0400 Received: from mga06.intel.com ([134.134.136.31]:51247 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726436AbgETPbZ (ORCPT ); Wed, 20 May 2020 11:31:25 -0400 IronPort-SDR: 09MqKA3k4+t+CZ5Gbl0aYDw8f6gxM+k96GoKFHsAkWZYrAcpSGF33dWcvop4pIQHpUEc5Izkre Ohe1kGLj+RxA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2020 08:31:12 -0700 IronPort-SDR: f0Zx2QUrUJxCeU2y5dYw8Py/FVL9nmBPEftqXgmIZrpOjhDhSrm66NX0gdENPJhNtysPNSNOts D08i7IpSG0Jg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,414,1583222400"; d="scan'208";a="440070660" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 20 May 2020 08:31:11 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 May 2020 08:31:11 -0700 Received: from fmsmsx108.amr.corp.intel.com ([169.254.9.97]) by FMSMSX154.amr.corp.intel.com ([169.254.6.79]) with mapi id 14.03.0439.000; Wed, 20 May 2020 08:31:11 -0700 From: "Ruhl, Michael J" To: Dan Carpenter , Alex Deucher , Kevin Wang CC: =?utf-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= , "David Airlie" , Daniel Vetter , Evan Quan , Rui Huang , Kenneth Feng , Yintian Tao , Hawking Zhang , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: RE: [PATCH v3] drm/amdgpu: off by one in amdgpu_device_attr_create_groups() error handling Thread-Topic: [PATCH v3] drm/amdgpu: off by one in amdgpu_device_attr_create_groups() error handling Thread-Index: AQHWLrsALezMNhBda0yqAwmq9Jl02KixGQgQ Date: Wed, 20 May 2020 15:31:11 +0000 Message-ID: <14063C7AD467DE4B82DEDB5C278E8663010E230378@FMSMSX108.amr.corp.intel.com> References: <14063C7AD467DE4B82DEDB5C278E8663010E2302FA@FMSMSX108.amr.corp.intel.com> <20200520152556.GQ3041@kadam> In-Reply-To: <20200520152556.GQ3041@kadam> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+RnJvbTogRGFuIENhcnBlbnRlciA8ZGFuLmNh cnBlbnRlckBvcmFjbGUuY29tPg0KPlNlbnQ6IFdlZG5lc2RheSwgTWF5IDIwLCAyMDIwIDExOjI2 IEFNDQo+VG86IEFsZXggRGV1Y2hlciA8YWxleGFuZGVyLmRldWNoZXJAYW1kLmNvbT47IEtldmlu IFdhbmcNCj48a2V2aW4xLndhbmdAYW1kLmNvbT47IFJ1aGwsIE1pY2hhZWwgSiA8bWljaGFlbC5q LnJ1aGxAaW50ZWwuY29tPg0KPkNjOiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmln QGFtZC5jb20+OyBEYXZpZCBBaXJsaWUNCj48YWlybGllZEBsaW51eC5pZT47IERhbmllbCBWZXR0 ZXIgPGRhbmllbEBmZndsbC5jaD47IEV2YW4gUXVhbg0KPjxldmFuLnF1YW5AYW1kLmNvbT47IFJ1 aSBIdWFuZyA8cmF5Lmh1YW5nQGFtZC5jb20+OyBLZW5uZXRoIEZlbmcNCj48a2VubmV0aC5mZW5n QGFtZC5jb20+OyBZaW50aWFuIFRhbyA8eXR0YW9AYW1kLmNvbT47IEhhd2tpbmcgWmhhbmcNCj48 SGF3a2luZy5aaGFuZ0BhbWQuY29tPjsgYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmc7IGRy aS0NCj5kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5l bC5vcmc7IGtlcm5lbC0NCj5qYW5pdG9yc0B2Z2VyLmtlcm5lbC5vcmcNCj5TdWJqZWN0OiBbUEFU Q0ggdjNdIGRybS9hbWRncHU6IG9mZiBieSBvbmUgaW4NCj5hbWRncHVfZGV2aWNlX2F0dHJfY3Jl YXRlX2dyb3VwcygpIGVycm9yIGhhbmRsaW5nDQo+DQo+VGhpcyBsb29wIGluIHRoZSBlcnJvciBo YW5kbGluZyBjb2RlIHNob3VsZCBzdGFydCBhICJpIC0gMSIgYW5kIGVuZCBhdA0KPiJpID09IDAi LiAgQ3VycmVudGx5IGl0IHN0YXJ0cyBhICJpIiBhbmQgZW5kcyBhdCAiaSA9PSAxIi4gIFRoZSBy ZXN1bHQNCj5pcyB0aGF0IGl0IHJlbW92ZXMgb25lIGF0dHJpYnV0ZSB0aGF0IHdhc24ndCBjcmVh dGVkIHlldCwgYW5kIGxlYWtzIHRoZQ0KPnplcm9ldGggYXR0cmlidXRlLg0KPg0KPkZpeGVzOiA0 ZTAxODQ3YzM4ZjcgKCJkcm0vYW1kZ3B1OiBvcHRpbWl6ZSBhbWRncHUgZGV2aWNlIGF0dHJpYnV0 ZSBjb2RlIikNCj5TaWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVyIDxkYW4uY2FycGVudGVyQG9y YWNsZS5jb20+DQo+LS0tDQo+djI6IHN0eWxlIGNoYW5nZQ0KPnYzOiBGaXggZW1iYXJyYXNzaW5n IHR5cG8gaW4gdGhlIHN1YmplY3QNCg0K8J+Yig0KDQpBY2tlZC1ieTogTWljaGFlbCBKLiBSdWhs IDxtaWNoYWVsLmoucnVobEBpbnRlbC5jb20+DQoNCm0NCj4gZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1X3BtLmMgICAgICAgICAgIHwgMyArLS0NCj4gMSBmaWxlcyBjaGFuZ2VkLCAx IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pDQo+DQo+ZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9wbS5jDQo+Yi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9hbWRncHVfcG0uYw0KPmluZGV4IGI3NTM2MmJmMDc0Mi4uZTgwOTUzNGZhYmQ0IDEwMDY0 NA0KPi0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9wbS5jDQo+KysrIGIv ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3BtLmMNCj5AQCAtMTk0Miw5ICsxOTQy LDggQEAgc3RhdGljIGludCBhbWRncHVfZGV2aWNlX2F0dHJfY3JlYXRlX2dyb3VwcyhzdHJ1Y3QN Cj5hbWRncHVfZGV2aWNlICphZGV2LA0KPiAJcmV0dXJuIDA7DQo+DQo+IGZhaWxlZDoNCj4tCWZv ciAoOyBpID4gMDsgaS0tKSB7DQo+Kwl3aGlsZSAoaS0tKQ0KPiAJCWFtZGdwdV9kZXZpY2VfYXR0 cl9yZW1vdmUoYWRldiwgJmF0dHJzW2ldKTsNCj4tCX0NCj4NCj4gCXJldHVybiByZXQ7DQo+IH0N Cg==