Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp698575ybk; Wed, 20 May 2020 09:43:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzS0HuFmZuJOh6alSe+X0EnNv4jHPObTkXeSx1qhIWzatO91kp2PzDqf0QUUxstUyBcR2J1 X-Received: by 2002:a50:d619:: with SMTP id x25mr4342510edi.200.1589993022958; Wed, 20 May 2020 09:43:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589993022; cv=none; d=google.com; s=arc-20160816; b=VZ3Pxq9zF8THROMdyi287q0XWxjMBQ3zaUoHpTh+AfyO/PkjmRSj13cUEawPgGuGCw wlw+11ojXjQYs/paqzMRfwwpfO9RRW3Kb3K3Oh3FVYmLpzjthpYHCfmx/dOZ8PO/e4DT uDn+T5tUejkC/zUrDT2ZgGNgpcC9G++IAnAbkLK628n///xbxONj5SLP/vPF1plDyqgs ILmg/GuW+jloEAis2oWOGyJB3rWbjCruOFtaC/0A9gry67SgGfoKAv9h64kbCdVarAyc 3zBNbUy7bQykpNWkLQ44hhxvKX1uHdJoXMAQUd6yno45k7nsCcPub5w69AggIQWs9DiI PJsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=TXSIEH/K35q5Co2T+bqe9j3Xh1ob1VTaX9xa8da1qBI=; b=mSpBtHFbjyJBKC5rKY6nUpnBBORDApnTbwAgEZaYKxDicjJKTj1NcgImioq01ImoGg SKTIyWDCxQZxM3BhaRw56P81Q804BfWIxN3n+QnYigoyqesrJEYMPMciLhWBJ4fGcRq7 69LEk77WrFhYvV/4AdGLezZNUQIs/TgjTFMVo7LIPI+4PMUi77YFpUsByCfB9na5m7/T GWNa5yG5J1mrG+qihnYWDxURttEKWoiYgTiNBqM8lmUkuqCD7vVRBl3PtuepP0gDZtc4 oGKbnRZDzRpuLCXF5eYg2EqRdAR3rgJ1Rbm4vVKNf7Q0M17l7UF/rPuJG+u5sWln8ytq jvQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ar7si2094920ejc.449.2020.05.20.09.43.19; Wed, 20 May 2020 09:43:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726748AbgETQl6 (ORCPT + 99 others); Wed, 20 May 2020 12:41:58 -0400 Received: from mga07.intel.com ([134.134.136.100]:20746 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726486AbgETQl6 (ORCPT ); Wed, 20 May 2020 12:41:58 -0400 IronPort-SDR: ol1UaiOOuLMQ7bmRx6lf0teG/nyvA+v58rwnDRdF9ZexH+DNm9SfYq0NoF7Rqqo0OqMY3TLoYC RvSn0egEdqow== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2020 09:41:57 -0700 IronPort-SDR: i1rACb6lLbJf4eWBCXQ8spmHyZDQlF5BDIYFWF52Olgd8g5WBgYTRM06z4toktPZqLnOUSdlWP 92f2PYNOImsw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,414,1583222400"; d="scan'208";a="253663606" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga007.jf.intel.com with ESMTP; 20 May 2020 09:41:53 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jbRn2-007sEw-9k; Wed, 20 May 2020 19:41:56 +0300 Date: Wed, 20 May 2020 19:41:56 +0300 From: Andy Shevchenko To: Petr Mladek Cc: Brendan Higgins , gregkh@linuxfoundation.org, rafael@kernel.org, linux-kernel@vger.kernel.org, davidgow@google.com, Heidi Fahim , Heikki Krogerus , Hans de Goede , "Rafael J . Wysocki" , Sakari Ailus , Rob Herring Subject: Re: [PATCH v1] Revert "software node: Simplify software_node_release() function" Message-ID: <20200520164156.GA1634618@smile.fi.intel.com> References: <20200228000001.240428-1-brendanhiggins@google.com> <20200520150227.GA8397@linux-b0ei> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200520150227.GA8397@linux-b0ei> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 20, 2020 at 05:02:27PM +0200, Petr Mladek wrote: > On Thu 2020-02-27 16:00:01, Brendan Higgins wrote: > I have found similar report from a test robot, see > https://lore.kernel.org/lkml/20200303002816.GW6548@shao2-debian/ > > > I was staring into it for a while and do not understand it. The revert > makes sense. I wonder if it somehow changes the order in which > the release methods are called. > > Anyway, reverting the revert makes test_printf working. There is a proper fix IIRC from Heikki in driver core (no link at hand, sorry). -- With Best Regards, Andy Shevchenko