Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp741619ybk; Wed, 20 May 2020 10:47:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJylwgJTv2g8dsKR93D+p064yGbpIzCDB/5RJAhLAEMk7E5Kg8cUpLLtv8dHOuNe32Z522x/ X-Received: by 2002:a17:906:69a:: with SMTP id u26mr214428ejb.2.1589996877482; Wed, 20 May 2020 10:47:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589996877; cv=none; d=google.com; s=arc-20160816; b=QSdKUkl/CcTMmTapNfSebp3dV3DG2DTaPg61dv55rOA3NSFwWnKaQSx7WumQMRerCA FZx+0cawBLUk3KSzUmF0QitV05zvBFERWUyAoUVjOq9b4wwBdTlz2OtmCt0qxmbjJI/r 5hRIPO6ua7yCMV0Nj4MDFX8G+DsIQIR1qbtoUcqaCxKu4ahzMF22aDMC7gT+mVaPz0R/ Vm1IJCA0vQD9LzP62WvmW7QXLepGF1ArA7qktdDJLBw0YHGzCBgfktMGJBsHX320zHJC sDQoTQgjQsTjPkhhkgrwldTvv6EkoMaUwGTwpbPlcuqB4TN0j4c24Y1PwJhAuyrsTcuJ asOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=G2BoO3OibwMqV99BPb+OQZqB3kLcX0jnZiP4YtVlK6o=; b=nzBEZJUcNppgFMrypVMuJqS+FjZtiPsDVe8wKDN9BxtGh0EDXCV+E1Gt3OxhAmKeV9 tRrFHjNuSPh1MtG1yI4UWYDcgUsD6t9siVoI0wIEWjcmQS7Xj2SfPLjIkqqLLA+0IXUC 09qXkc80Bur0BY5xCkuWk9iMb3F+mzEf64xg3I7IFU75YaF7hMZuvEo4ESCBqXQhhNgp 4XaFeIatP7c26dWLSzoI9d/2zGZZgTdMmn1ulTasTZiY3fTIQ5/5rBYy+y5I1LBoIKrr DuLyim5+4oS5AcY43VoGOAVw/eJxWyg3/9wbgkJ+pv8i2A9LbpKqr+k6qw7iEZu8xoUN haaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LJ5Q3o7l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r6si1743983edq.553.2020.05.20.10.47.34; Wed, 20 May 2020 10:47:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LJ5Q3o7l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726936AbgETRoC (ORCPT + 99 others); Wed, 20 May 2020 13:44:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:54062 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726619AbgETRoB (ORCPT ); Wed, 20 May 2020 13:44:01 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 427C82075F; Wed, 20 May 2020 17:43:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589996641; bh=P2aat+TlaI2N+/z7SW3hph4BEYfuA7FSbseNufQGe4k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LJ5Q3o7lmeUADmYQ2lB29DmpSJq9CwNkr/C8uOM21tMpkAFWObarU+Bu1OsPfq9FG 4F6Ql4BWleoI4gCPqUB936+6/WYnqm5xYt5ZI5xAF0uY3EHOr74j831yY9jHzVpFEC at7VFnF549jrYb1WBdZlx226K8TrOTtmFi+2M4UA= Date: Wed, 20 May 2020 18:43:56 +0100 From: Will Deacon To: Lorenzo Pieralisi Cc: Tuan Phan , patches@amperecomputing.com, Hanjun Guo , Sudeep Holla , "Rafael J. Wysocki" , Len Brown , Robin Murphy , Shameer Kolothum , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] ACPI/IORT: Fix PMCG node single ID mapping handling Message-ID: <20200520174355.GC27629@willie-the-truck> References: <1589994787-28637-1-git-send-email-tuanphan@os.amperecomputing.com> <20200520172736.GA10693@e121166-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200520172736.GA10693@e121166-lin.cambridge.arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 20, 2020 at 06:27:36PM +0100, Lorenzo Pieralisi wrote: > On Wed, May 20, 2020 at 10:13:07AM -0700, Tuan Phan wrote: > > An IORT PMCG node can have no ID mapping if its overflow interrupt is > > wire based therefore the code that parses the PMCG node can not assume > > the node will always have a single mapping present at index 0. > > > > Fix iort_get_id_mapping_index() by checking for an overflow interrupt > > and mapping count. > > > > Fixes: 24e516049360 ("ACPI/IORT: Add support for PMCG") > > > > Acked-by: Lorenzo Pieralisi > > Reviewed-by: Hanjun Guo > > Signed-off-by: Tuan Phan > > --- > > v1 -> v2: > > - Use pmcg node to detect wired base overflow interrupt. > > > > v2 -> v3: > > - Address Hanjun and Robin's comments. > > > > v3 -> v4: > > - Update the title and description as mentioned by Lorenzo. > > > > v4 -> v5: > > - Remove period in the title and commit references. > > > > drivers/acpi/arm64/iort.c | 5 +++++ > > Hi Will, > > is there a chance we can get this patch into v5.8 ? I understand > we are very late in the cycle but I wanted to ask (it applies cleanly > to for-next/acpi). Sorry, Lorenzo -- I didn't notice that this had been Acked already. I was waiting for somebody to chime in! I'll queue it ASAP for 5.8. Will