Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200228000001.240428-1-brendanhiggins@google.com>
 <20200520150227.GA8397@linux-b0ei> <20200520164156.GA1634618@smile.fi.intel.com>
In-Reply-To: <20200520164156.GA1634618@smile.fi.intel.com>
From:   Brendan Higgins <brendanhiggins@google.com>
Date:   Wed, 20 May 2020 11:21:49 -0700
Message-ID: <CAFd5g47Xj6pR=CqXMtYxL6iacqxoZ9PvHxsiG8dfUML24yN1gQ@mail.gmail.com>
Subject: Re: [PATCH v1] Revert "software node: Simplify software_node_release()
 function"
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Petr Mladek <pmladek@suse.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        David Gow <davidgow@google.com>,
        Heidi Fahim <heidifahim@google.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Hans de Goede <hdegoede@redhat.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Rob Herring <robh@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, May 20, 2020 at 9:42 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Wed, May 20, 2020 at 05:02:27PM +0200, Petr Mladek wrote:
> > On Thu 2020-02-27 16:00:01, Brendan Higgins wrote:
>
> > I have found similar report from a test robot, see
> > https://lore.kernel.org/lkml/20200303002816.GW6548@shao2-debian/
> >
> >
> > I was staring into it for a while and do not understand it. The revert
> > makes sense. I wonder if it somehow changes the order in which
> > the release methods are called.
> >
> > Anyway, reverting the revert makes test_printf working.
>
> There is a proper fix IIRC from Heikki in driver core (no link at hand, sorry).

The fix for this patch can be found here: https://lkml.org/lkml/2020/5/13/1070

Cheers