Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 20 May 2020 13:57:45 -0700
From:   Roman Gushchin <guro@fb.com>
To:     Vlastimil Babka <vbabka@suse.cz>
CC:     Christopher Lameter <cl@linux.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>, <linux-mm@kvack.org>,
        <kernel-team@fb.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 04/19] mm: slub: implement SLUB version of
 obj_to_index()
Message-ID: <20200520205745.GB278395@carbon.dhcp.thefacebook.com>
References: <20200425024625.GA107755@carbon.lan>
 <alpine.DEB.2.21.2004271618340.27701@www.lameter.com>
 <20200427164638.GC114719@carbon.DHCP.thefacebook.com>
 <alpine.DEB.2.21.2004301625490.1693@www.lameter.com>
 <20200430171558.GA339283@carbon.dhcp.thefacebook.com>
 <alpine.DEB.2.22.394.2005022353330.1987@www.lameter.com>
 <20200504182922.GA20009@carbon.dhcp.thefacebook.com>
 <alpine.DEB.2.22.394.2005082130570.65713@www.lameter.com>
 <20200513005741.GA67541@carbon.dhcp.thefacebook.com>
 <88972cc2-2120-4257-ae8d-141e014c54e4@suse.cz>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <88972cc2-2120-4257-ae8d-141e014c54e4@suse.cz>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from carbon.dhcp.thefacebook.com (2620:10d:c090:400::5:e80) by BY5PR16CA0018.namprd16.prod.outlook.com (2603:10b6:a03:1a0::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.24 via Frontend Transport; Wed, 20 May 2020 20:57:47 +0000
X-Originating-IP: [2620:10d:c090:400::5:e80]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b14a174c-0e8a-4e8d-e0f3-08d7fd0073e1
X-MS-TrafficTypeDiagnostic: BYAPR15MB2263:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BYAPR15MB2263DE1959921EF7A264069BBEB60@BYAPR15MB2263.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-Forefront-PRVS: 04097B7F7F
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: OC6dFo1NoKgzctZQK+bdBayeYrDb15av88WtthSKtY+qZtZUUTDrhvs8RzunAQXoTLbXIbY5zX6m9dS/mPf5pnaPHa4oUmj/xEUw1jXE7o1GlJ1iygIQ2yYZIRRB85AJWXTqYZUAFJ09W0ZGjlr3ym6XwpVABdN17oiYCwlyRUrLk1yVglpUOhBa07XI+rfnsz1FFOL57n1WdJ1CQsZvfwC/1tqFGy+yinXF3HxduuB4zjKKblDu8KOtOaBf0nZ6z5+YQAesrFG2ECEi0ttUXf7v3emTwkTJMXiQeiceoa251OKlhgO449W0dmgvj5bk0RgXOMTZGi4UFsmEYHTB4w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR15MB4136.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(136003)(396003)(39860400002)(376002)(346002)(366004)(86362001)(5660300002)(8676002)(316002)(2906002)(478600001)(8936002)(6916009)(54906003)(6506007)(7696005)(52116002)(55016002)(9686003)(53546011)(33656002)(4326008)(66476007)(66946007)(1076003)(16526019)(186003)(66556008);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: afD53kIS4c6BIhskzPb1Tf+US8wBMI9Tp4w4dYQyOCxRaUmTEPmfBCK+pgB0CqSsGqzaYrevRcxCb3aJIkah1gjWst9EAkOHppwYN/nOLIMSaEqvTf5IHkc0oMYoVD4MqEEALPz4SqUdt1JtOOKi9V77PI2tt+m+z1Z8rf7VOiP9YrOCMbnQy0H6/9CwVOVltBPZ5TXqOsVM3sJU7Gu+/h5UQtTTMcPE/4jVDFeCWppwBQtCcm5HdjfqlG1wJ1Iff2Sxt4u8rwddBGkftQaVew9kveMSMgv9VzKnNh6uPIm6ttEvPseejC3jyyWbXPxR4InyKh3CljS0Yy7c6OWY714j9AOA7fGzs0dgXirLrau66Xnfzfbspjw+AzGm296EyAaRaSaZ+MW7LpNHnMK4m4O2FTx+n0/Fx4Gx/gpYe8hRDSeytoFWat4tzQVmRzX2dZ4ctKZLC1OwXiw0doSNRilJ6PP8v4OLdN8jJ/UPyqR8dwr7wb8mFUKC9Bdqg5TQ7SKQPvfTK9IazOquXvmG1Q==
X-MS-Exchange-CrossTenant-Network-Message-Id: b14a174c-0e8a-4e8d-e0f3-08d7fd0073e1
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2020 20:57:48.4083
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C2lcqz8gyyq3leCWWixc/GbziA+OWHasPOBDTsDixU3GxHCfUTGHeOD5SN5VGYOg
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2263
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.676
 definitions=2020-05-20_16:2020-05-20,2020-05-20 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 mlxscore=0
 lowpriorityscore=0 suspectscore=1 spamscore=0 cotscore=-2147483648
 malwarescore=0 bulkscore=0 impostorscore=0 priorityscore=1501 phishscore=0
 adultscore=0 clxscore=1015 mlxlogscore=999 classifier=spam adjust=0
 reason=mlx scancount=1 engine=8.12.0-2004280000
 definitions=main-2005200167
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 20, 2020 at 11:51:51AM +0200, Vlastimil Babka wrote:
> On 5/13/20 2:57 AM, Roman Gushchin wrote:
> > 
> > Btw, I'm trying to build up a prototype with an embedded memcg pointer,
> > but it seems to be way more tricky than I thought. It requires changes to
> > shrinkers (as they rely on getting the memcg pointer by an arbitrary
> > kernel address, not necessarily aligned to the head of slab allocation),
> > figuring out cache merging, adding SLAB support, natural alignment of
> > kmallocs etc.
> 
> Is the natural alignment of kmallocs a problem right now? As kmalloc()
> allocations are AFAIK not kmemcg-accounted? Or does your implementation add
> memcg awareness to everything, even if non-__GFP_ACCOUNT allocations just get a
> root memcg pointer?

There is at least a dozen of accounted kmallocs as now, please search for kmalloc
with GFP_KERNEL_ACCOUNT.

Natural alignment is not an issue with the proposed implementation, but it becomes
a problem as soon as we try to embed the memcg pointer into the object
(as Christopher is suggesting). I'm actually not opposing his suggestion, just
want to settle down the memcg part first, and then discuss the best way
to store the memcg metadata information. As I shown, the required changes to switch
between different ways of storing the data are minimal and do not affect
the rest of the patchset.

Thanks!