Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp868336ybk; Wed, 20 May 2020 14:12:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyJWmyGxsZZzCZ7OhOodiErsKpozLVwbr7GvDBSjnP0/n7nqtjJb54pzLTFX0bIi9DfPylR X-Received: by 2002:a17:906:d215:: with SMTP id w21mr856453ejz.383.1590009167139; Wed, 20 May 2020 14:12:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590009167; cv=none; d=google.com; s=arc-20160816; b=av3NpfvSbR+h87/bcz5kGFCEUkQdbl8ypZsotRZv7zofwzfg3Il9MbN9pCUKqjT8X+ R03tq6JiYPPclzVKA5dSHpxzsDcKgciVpT7rFajb0Dk7yTXjy4EcwdoprXFFVCeXbzob aexedEzrpfrFRtgVafQfo+edDXYMNBxjo+qhhtEARM1TMwonsPrz4d5NjV+i9Yd4fRob W+GFMOzy2Rvzzbq/eek9Di60YQphrWskO7SmTaaLO0HzQe895eHzey2NL/A3KVjJkifu 8ByyOlLfSOmMYpEtLnUG2c4L2djulv7ukaJ7DJYL/9ZTdZjhGE0pidCqH6k7bsCBdDVr ssLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=za7nlXiLfBl+tNLWvFwJ7etEnq4cdkWD/k8DOAXDLgo=; b=s323DfnADTe7qty1fjNpzeJDG+sXUpndJAJXNY+4NwSw5fxiMrFMNwQBjZ8K9ksjTl 6JcEjiNaqHAXfrYI74DG5mWRIFTRofpeLNkCK5t5UmusCNr6IuXHBANNCLUt1gJX3mMB 4c+340r/iiAeGc+KMO/SwVsjy9+85/onQ4/H8HFxnvJNHjnHgwUXrXviC5Nxtvqac1gF bpb4503OQS/WUqGLdUMv/J2q/KtukkpZYihGWyOlRi056y02X6enoS7HlV7I00t9Rlub sYX29vzIKEVb8IhaX/PH3L5oe/Q/giEhwLkrAK4QWPpXtEVGsu021RDuEXyBwB6sp1u+ I+lw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r3si2149918edo.395.2020.05.20.14.12.24; Wed, 20 May 2020 14:12:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728321AbgETVIt (ORCPT + 99 others); Wed, 20 May 2020 17:08:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728046AbgETVIs (ORCPT ); Wed, 20 May 2020 17:08:48 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5684C061A0E; Wed, 20 May 2020 14:08:48 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1EB0F1210A409; Wed, 20 May 2020 14:08:45 -0700 (PDT) Date: Wed, 20 May 2020 14:08:42 -0700 (PDT) Message-Id: <20200520.140842.1711606625827492143.davem@davemloft.net> To: jhubbard@nvidia.com Cc: syzbot+118ac0af4ac7f785a45b@syzkaller.appspotmail.com, akpm@linux-foundation.org, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, rds-devel@oss.oracle.com, santosh.shilimkar@oracle.com, syzkaller-bugs@googlegroups.com Subject: Re: [PATCH] rds: fix crash in rds_info_getsockopt() From: David Miller In-Reply-To: <20200520194147.127137-1-jhubbard@nvidia.com> References: <00000000000000d71e05a6185662@google.com> <20200520194147.127137-1-jhubbard@nvidia.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 20 May 2020 14:08:46 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: John Hubbard Date: Wed, 20 May 2020 12:41:47 -0700 > The conversion to pin_user_pages() had a bug: it overlooked > the case of allocation of pages failing. Fix that by restoring > an equivalent check. > > Reported-by: syzbot+118ac0af4ac7f785a45b@syzkaller.appspotmail.com > Fixes: dbfe7d74376e ("rds: convert get_user_pages() --> pin_user_pages()") > Signed-off-by: John Hubbard Applied to net-next, thanks.