Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp893892ybk; Wed, 20 May 2020 15:01:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw23Dh++RYDiOAUUxo1hSoN2StJBWPaRj8m6ntT8IbY+qczBNDFQA4BvNQX1GGP56eZ1/hB X-Received: by 2002:a17:906:14cb:: with SMTP id y11mr962321ejc.131.1590012091296; Wed, 20 May 2020 15:01:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590012091; cv=none; d=google.com; s=arc-20160816; b=S3kxs2iKIeCqbLxAlQ5Ju0m2mcY0/oju3pT3jIcO7fD+DYMnEgwOc/J5iOmEOv5iF/ zevaIBu4O1Vux7ZbblH3RoEE2CPrdhFk5vE5n6VkpTaQon3t6R9YaKQo4z6OFxewEYSD vDL4mPriNIaKiC5G+++JYSViBnaRw72V/Ppv5gRItQA3jup7lT+4gcqHyu+rM+jKznHa eFOYUeQ4W6p07cy1OzrWO05jAimdtEXdCXDkLsqz0a7MkBsZkflyubb5ExmU1n7DiGfx MSqnERtuWxjcC5B+dA6iCOtdZd5nnlrQNwXPda60DzlmTIhXeC6YRCUph7tcRiXrW9ni ZihA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature; bh=3uYuYChDUZSVg5PdvAhch35HzgAV57/WwZiYWni9v5A=; b=lLPuXsvMsAGE/mjTT1fblz0OWw4ytez5/Q+UwjFD8OVAv4ZbkHliIKJ/5evaQjSOYw dvdzmYJoBTotz6XNr62ynP2FmH/8AddMKzgitN332ZgAqLA7GubyMyge8Xr2EUSlmvXD 6h5GuzOVkG1xZMzwPbF/AqFysvnrNzv3w8sPWQpPLKYwe71l1UBuPWj9m0veZfM7gyOC wfLcI47TTD52GUiCq5+nNgEfppMEn91tU5Rfpf3oDYcpSIOe6Uxo5IWcHDR9sqMCXCMc QPLh652cp+RqL8CKTvh4g2KwbCtPrs1f5+Pxr1QLVGOPDCLydS3XqhoIJP4TKHr4t9O4 AEaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=ZHLnycp6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v26si1998518eda.549.2020.05.20.15.01.08; Wed, 20 May 2020 15:01:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=ZHLnycp6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728345AbgETV7j (ORCPT + 99 others); Wed, 20 May 2020 17:59:39 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:60362 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728046AbgETV7j (ORCPT ); Wed, 20 May 2020 17:59:39 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1590011978; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=3uYuYChDUZSVg5PdvAhch35HzgAV57/WwZiYWni9v5A=; b=ZHLnycp6/vtcEthhS177y4hrEwK081QbvsALTnAFDYIpNNoICorhIWT6/OlpDgu8fEGwA1cv vm9v46yTmTXvIH0XkhEOSfHtHBc0ubl41hs1p1wb5of6JVMipCLQRQJRt7+Vei2xoitpHhg4 uEjW9ihBkDmYuWTA58vXfuXYMVw= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-east-1.postgun.com with SMTP id 5ec5a83eeb073d5691184cf7 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 20 May 2020 21:59:26 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 10257C433CB; Wed, 20 May 2020 21:59:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.0 Received: from [192.168.8.150] (cpe-70-95-149-85.san.res.rr.com [70.95.149.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: asutoshd) by smtp.codeaurora.org (Postfix) with ESMTPSA id C3099C433C8; Wed, 20 May 2020 21:59:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C3099C433C8 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=asutoshd@codeaurora.org Subject: Re: [PATCH v4 2/2] scsi: ufs-qcom: enter and exit hibern8 during clock scaling To: Avri Altman , "cang@codeaurora.org" , "martin.petersen@oracle.com" , "PedroM.Sousa@synopsys.com" , "linux-scsi@vger.kernel.org" Cc: "linux-arm-msm@vger.kernel.org" , Andy Gross , Bjorn Andersson , Alim Akhtar , "James E.J. Bottomley" , open list References: <186237103353b5a79c3496e619fca894dbc78600.1589997078.git.asutoshd@codeaurora.org> <9b67c25eb7c0bf80075b36660aebdb3788207353.1589997078.git.asutoshd@codeaurora.org> From: "Asutosh Das (asd)" Message-ID: Date: Wed, 20 May 2020 14:59:23 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Avri, On 5/20/2020 2:33 PM, Avri Altman wrote: > Hi, > >> >> >> Qualcomm controller needs to be in hibern8 before scaling clocks. >> This change puts the controller in hibern8 state before scaling >> and brings it out after scaling of clocks. >> >> Signed-off-by: Asutosh Das > > I guess that your previous versions are pretty far back - , > I noticed a comment by Pedro, so you might want to resend this series. > Ok. > What happens if the pre-change is successful, > but you are not getting to the post change because, e.g. ufshcd_set_clk_freq failed? > I agree. Let me check this. > Also, this piece of code is ~5 years old, so you might want to elaborate on how come hibernation is now needed. > > Thanks, > Avri > Thanks for the review. Hibernation was needed since long actually. I guess it was never pushed upstream. Thanks, -asd -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, Linux Foundation Collaborative Project