Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 20 May 2020 17:37:16 -0700
From:   Roman Gushchin <guro@fb.com>
To:     <js1304@gmail.com>
CC:     Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>, <kernel-team@lge.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Christoph Hellwig <hch@infradead.org>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
        Michal Hocko <mhocko@suse.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH 01/11] mm/page_isolation: prefer the node of the source
 page
Message-ID: <20200521003716.GA317575@carbon.dhcp.thefacebook.com>
References: <1589764857-6800-1-git-send-email-iamjoonsoo.kim@lge.com>
 <1589764857-6800-2-git-send-email-iamjoonsoo.kim@lge.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1589764857-6800-2-git-send-email-iamjoonsoo.kim@lge.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from carbon.dhcp.thefacebook.com (2620:10d:c090:400::5:bc17) by BY5PR13CA0008.namprd13.prod.outlook.com (2603:10b6:a03:180::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.8 via Frontend Transport; Thu, 21 May 2020 00:37:19 +0000
X-Originating-IP: [2620:10d:c090:400::5:bc17]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8d54dcf3-eaa5-4ecb-e837-08d7fd1f1ed1
X-MS-TrafficTypeDiagnostic: BYAPR15MB3478:
X-Microsoft-Antispam-PRVS: <BYAPR15MB34781103C99F536DF45C8406BEB70@BYAPR15MB3478.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:983;
X-Forefront-PRVS: 041032FF37
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: e4NmW5ajeMzdP+c80zyZG9ERHCELP8o/Xnxy/asBoM3dz0dEA0UZNHL+/8/7pcshtzWbHAwfQLPsT/+5FGbRLGblCBWuz7+wVsccf1fQmfa7N6cpy7M/m9eSXoCpLNQFBQ+SEkN4sx/3rz/gM9UQU9E7eJLLr4pEh7SEGtAgNxBAEjxCvdP5Y/XANrfB57SKD1j3tN0yKEVwN4Ntw759nBYJn0073nT1uxe4u9OXtUdRoiBzZexmsHYqMLGfpe39sMuE7fW20ZTMPggIYOCkGIHxh1HN6caf5NC687Fl9SA+us7zzRc+NY05E0N2FuCH2MQfnUX+Pl76LbbanrEaMQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR15MB4136.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(136003)(366004)(39860400002)(376002)(346002)(8936002)(316002)(54906003)(6506007)(6666004)(1076003)(66476007)(8676002)(2906002)(55016002)(86362001)(66556008)(66946007)(9686003)(186003)(16526019)(7416002)(4326008)(52116002)(5660300002)(478600001)(33656002)(7696005)(6916009);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: uOCSi+dlFpIsQc7zX+ceqQeqom7M1WO6TZZJ3/CqCe/dqILZdqg6dVpKSKG3j7brD7GL/DS/qj9O7uv1EYH2t1zTjHe2LQ0oEphGp0yMiL3733eVeagQE9QFwLS5ASufi/w9wl7hVWvJ6j06EHagryOnsGhOF2ETj5RNlVkVPjL0uQLo1NvPNxRq8AE39Q3yU2k5KWSrN87XHCCExs7MwQ/L+Lz+F+aePTQLo6wRnsmQ2wgUccLK4ASTluzBtOK1D74nE5TtGANJvgKCYmyLJ/35AsleTpeFpRs+vwG4SRzZbX68Act594/VhiG4j2s8gk4bRqENVTST7Vrwl1NAXdV7x6IfML77oJNc+goBq2/PGD3+9kw17sTbwqioJSwDW6pTbDd84oNF0JqJvGR4waZq14mzSNBctv8YOodevZ7B09CyqqNR6ucPmkY5T68iTdKMPQvkBRFlBEinVJBzVVVa72Wkh2HT3HHCNMOTFlaW4s6xcNHMu1oFbdCPm2V46OEOdbE+/gpoHQn6Y3NyQw==
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d54dcf3-eaa5-4ecb-e837-08d7fd1f1ed1
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2020 00:37:20.1229
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SJ3GbUkMpYyLtPEv5dR9JcDlxyPPc+ETDvLTFAd1RcMAfVcN0ttpNydiN2TIL4MO
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3478
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.676
 definitions=2020-05-20_18:2020-05-20,2020-05-20 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 suspectscore=3
 cotscore=-2147483648 priorityscore=1501 mlxscore=0 malwarescore=0
 adultscore=0 mlxlogscore=669 lowpriorityscore=0 phishscore=0 clxscore=1011
 bulkscore=0 spamscore=0 impostorscore=0 classifier=spam adjust=0
 reason=mlx scancount=1 engine=8.12.0-2004280000
 definitions=main-2005210000
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 18, 2020 at 10:20:47AM +0900, js1304@gmail.com wrote:
> From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> 
> For locality, it's better to migrate the page to the same node
> rather than the node of the current caller's cpu.
> 
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>

Acked-by: Roman Gushchin <guro@fb.com>

> ---
>  mm/page_isolation.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/page_isolation.c b/mm/page_isolation.c
> index 2c11a38..7df89bd 100644
> --- a/mm/page_isolation.c
> +++ b/mm/page_isolation.c
> @@ -300,5 +300,7 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn,
>  
>  struct page *alloc_migrate_target(struct page *page, unsigned long private)
>  {
> -	return new_page_nodemask(page, numa_node_id(), &node_states[N_MEMORY]);
> +	int nid = page_to_nid(page);
> +
> +	return new_page_nodemask(page, nid, &node_states[N_MEMORY]);

Why not new_page_nodemask(page, page_to_nid(page), &node_states[N_MEMORY]) ?
Still fits into 80 characters.