Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752191AbWCPGnI (ORCPT ); Thu, 16 Mar 2006 01:43:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752189AbWCPGnI (ORCPT ); Thu, 16 Mar 2006 01:43:08 -0500 Received: from kbsmtao2.starhub.net.sg ([203.116.2.167]:48854 "EHLO kbsmtao2.starhub.net.sg") by vger.kernel.org with ESMTP id S1752194AbWCPGnH (ORCPT ); Thu, 16 Mar 2006 01:43:07 -0500 Date: Thu, 16 Mar 2006 14:42:11 +0800 From: Eugene Teo Subject: [PATCH] Hamradio: Fix a NULL pointer dereference in net/hamradio/mkiss.c To: linux-kernel@vger.kernel.org Cc: Thomas Osterried DL9SAU , Ralf Baechle DL5RB , Hans Alblas PE1AYX Reply-to: Eugene Teo Message-id: <20060316064211.GA22681@eugeneteo.net> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT Content-disposition: inline X-PGP-Key: http://www.honeynet.org/misc/pgp/eugene-teo.pgp X-Operating-System: Debian GNU/Linux 2.6.16-rc6 User-Agent: Mutt/1.5.11+cvs20060126 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1151 Lines: 37 Pointer ax is dereferenced before NULL check. Coverity bug #817 Signed-off-by: Eugene Teo --- linux-2.6/drivers/net/hamradio/mkiss.c~ 2006-03-15 10:05:35.000000000 +0800 +++ linux-2.6/drivers/net/hamradio/mkiss.c 2006-03-16 14:31:35.000000000 +0800 @@ -844,13 +844,16 @@ static void mkiss_close(struct tty_struc static int mkiss_ioctl(struct tty_struct *tty, struct file *file, unsigned int cmd, unsigned long arg) { - struct mkiss *ax = mkiss_get(tty); - struct net_device *dev = ax->dev; + struct mkiss *ax; + struct net_device *dev; unsigned int tmp, err; /* First make sure we're connected. */ if (ax == NULL) return -ENXIO; + + ax = mkiss_get(tty); + dev = ax->dev; switch (cmd) { case SIOCGIFNAME: -- 1024D/A6D12F80 print D51D 2633 8DAC 04DB 7265 9BB8 5883 6DAA A6D1 2F80 main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/