Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 20 May 2020 21:40:07 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc:     Joe Perches <joe@perches.com>,
        Chenggang Wang <wangchenggang@vivo.com>,
        linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.com>,
        Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [RFC PATCH 2/2] init: Allow multi-line output of kernel command
 line
Message-Id: <20200520214007.86f36f61e1fc0329b66758ed@linux-foundation.org>
In-Reply-To: <20200521043628.GB755@jagdpanzerIV.localdomain>
References: <cover.1589916689.git.joe@perches.com>
        <2b3832fed9370f0f8dfd1ea33dddb1d05a36e265.1589916689.git.joe@perches.com>
        <20200520044127.GB938@jagdpanzerIV.localdomain>
        <ae3aff79301c130aa15b3fe0ff801804bb019384.camel@perches.com>
        <20200520121000.GF520@jagdpanzerIV.localdomain>
        <19a8c717f8d9dc76f2b09e6dd19f3fbb71bf29c5.camel@perches.com>
        <20200520180028.8fc1b7890774c6f92a6c2623@linux-foundation.org>
        <20200521043628.GB755@jagdpanzerIV.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 21 May 2020 13:36:28 +0900 Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote:

> On (20/05/20 18:00), Andrew Morton wrote:
> [..]
> > I'm wondering if we shold add a kernel puts() (putsk()?  yuk) which can
> > puts() a string of any length.
> > 
> > I'm counting around 150 instances of printk("%s", ...) and pr_foo("%s",
> > ...) which could perhaps be converted, thus saving an argument.
> 
> Can you point me at some examples?
> 

./arch/powerpc/kernel/udbg.c:           printk("%s", s);
./arch/powerpc/xmon/nonstdio.c:         printk("%s", xmon_outbuf);
./arch/um/os-Linux/drivers/ethertap_user.c:             printk("%s", output);
./arch/um/os-Linux/drivers/ethertap_user.c:             printk("%s", output);
./arch/um/os-Linux/drivers/tuntap_user.c:                       printk("%s", out

etc.

My point is, if we created a length-unlimited puts() function for printing the
kernel command line, it could be reused in such places, resulting in a
smaller kernel.