Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 7EIqXKvs99vNQHGP5/ZsO5MMS9xbFPjf9TnHYslla6/JccOC3OTUsgUyIjPaggg+0EsllJN56Q
 PgwoiJtoSxmQ==
IronPort-SDR: Ifqt7oWD28CU73Jplv1Hghgc8Gm+dCNQR8HOy0So5tRO7Ep/EUlkghn5pUieCRH+VqxwEXXz0N
 IkWda0b1W/wA==
From:   "Brown, Aaron F" <aaron.f.brown@intel.com>
To:     Punit Agrawal <punit1.agrawal@toshiba.co.jp>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>
CC:     "daniel.sangorrin@toshiba.co.jp" <daniel.sangorrin@toshiba.co.jp>,
        Alexander Duyck <alexander.h.duyck@linux.intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] e1000e: Relax condition to trigger reset for ME
 workaround
Thread-Topic: [PATCH] e1000e: Relax condition to trigger reset for ME
 workaround
Thread-Index: AQHWKnHhYXgap9bbtEq5AHkc4XiRdaiyNRoQ
Date:   Thu, 21 May 2020 07:56:12 +0000
Message-ID: <DM6PR11MB2890F48ACD9A4ECF9181A819BCB70@DM6PR11MB2890.namprd11.prod.outlook.com>
References: <20200515043127.3882162-1-punit1.agrawal@toshiba.co.jp>
In-Reply-To: <20200515043127.3882162-1-punit1.agrawal@toshiba.co.jp>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.2.0.6
dlp-product: dlpe-windows
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 636f7f95-98e2-4c3c-cd4d-08d7fd5c6e68
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 May 2020 07:56:12.6495
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Pqst+UwYZgfP+xkpCk6eTL4/kWBjMAoNvBsNeqLM9yeYYv04VKMY7fF8wf7nZ0mJ1/Kmwh0b8KGsNhAdfpytXg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3545
X-OriginatorOrg: intel.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: netdev-owner@vger.kernel.org <netdev-owner@vger.kernel.org> On
> Behalf Of Punit Agrawal
> Sent: Thursday, May 14, 2020 9:31 PM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>
> Cc: daniel.sangorrin@toshiba.co.jp; Punit Agrawal
> <punit1.agrawal@toshiba.co.jp>; Alexander Duyck
> <alexander.h.duyck@linux.intel.com>; David S. Miller <davem@davemloft.net=
>;
> intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH] e1000e: Relax condition to trigger reset for ME workarou=
nd
>=20
> It's an error if the value of the RX/TX tail descriptor does not match
> what was written. The error condition is true regardless the duration
> of the interference from ME. But the driver only performs the reset if
> E1000_ICH_FWSM_PCIM2PCI_COUNT (2000) iterations of 50us delay have
> transpired. The extra condition can lead to inconsistency between the
> state of hardware as expected by the driver.
>=20
> Fix this by dropping the check for number of delay iterations.
>=20
> While at it, also make __ew32_prepare() static as it's not used
> anywhere else.
>=20
> Signed-off-by: Punit Agrawal <punit1.agrawal@toshiba.co.jp>
> Reviewed-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> Hi Jeff,
>=20
> If there are no further comments please consider merging the patch.
>=20
> Also, should it be marked for backport to stable?
>=20
> Thanks,
> Punit
>=20
> RFC[0] -> v1:
> * Dropped return value for __ew32_prepare() as it's not used
> * Made __ew32_prepare() static
> * Added tags
>=20
> [0] https://lkml.org/lkml/2020/5/12/20
>=20
>  drivers/net/ethernet/intel/e1000e/e1000.h  |  1 -
>  drivers/net/ethernet/intel/e1000e/netdev.c | 12 +++++-------
>  2 files changed, 5 insertions(+), 8 deletions(-)
>=20
Tested-by: Aaron Brown <aaron.f.brown@intel.com>