Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1228778ybk;
        Thu, 21 May 2020 01:42:07 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxkSgo1Upiu9iCChkRtmCQ1641KVYcQpccWRdixtpM81sAV/UL6t+YIgX3fOqy/VY+TGU9a
X-Received: by 2002:a17:906:355b:: with SMTP id s27mr2493416eja.492.1590050527769;
        Thu, 21 May 2020 01:42:07 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1590050527; cv=none;
        d=google.com; s=arc-20160816;
        b=tBWahv+XJWTAHRiu/i4crqVrnHzkHdIahhbWkSVoXO9xaIuoqNbq6HFlsq4W4+IPkx
         D7PZ5DZVKqf9blF7Lzz42qK+jcKGWWpNnY7fHIVkCP+6Rct6ZC48auroBbYBMFAk1NLe
         ygpwlOPDMVASsy3MGDuo8JCEYybtQzZDAfCweA9VbBhdLgKN0PkD++tUpjMryPUsovKj
         HySA5fIWEb7nvD41/DoENakLSkm1FsRU+NaxYzk1ZggtV9PHNTfaTBnsaawVPrlkiv+q
         beDzgnt8s1n+aZiP4qh0LxwPiRcurK2+2NjG+tpNAOo+3nWspQxAf7UjqPSIcERCsfv7
         MaBQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=9uLtQsPxoNaJRi8sxPLkhckPw0g+X+KrcTIUZx4NfZk=;
        b=OM+mOJDlqhmho56OlyKAQUk4J2PRkgwGy6vHywKEoMcRA/6Tbfpz/JsXkTCLkomeRh
         tIq/QdMgHq6Dl29NnWte09aegTItrmQIAe5y1sCB712wz673duTHqmt3He87z69+w19V
         50iFTIAlQBWU30yIyV/kPaZU7LNRKJevVfsQVm2z0gMekZnkhLh9tb+cjqq0qman/DQX
         rRnDp/cm3VUJXXfNv+Rt/e79fFjz90Xwo5wlTs6s9zLXPtnyJLN9fSEyPDSC8mOzrLk2
         ruJkVOKGF2gN8ntkk1+I0tF903FY4P9xFnvW2hO8WXmpB/Ir+RzqCYFv2MxrpR+/TgtO
         z4qg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=AttJ7FDh;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id r19si2628969edm.596.2020.05.21.01.41.44;
        Thu, 21 May 2020 01:42:07 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=AttJ7FDh;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728670AbgEUIjX (ORCPT <rfc822;ostrlinux@gmail.com> + 99 others);
        Thu, 21 May 2020 04:39:23 -0400
Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:13339 "EHLO
        hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728374AbgEUIjW (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 21 May 2020 04:39:22 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5ec63deb0000>; Thu, 21 May 2020 01:38:03 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Thu, 21 May 2020 01:39:22 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Thu, 21 May 2020 01:39:22 -0700
Received: from [10.26.75.55] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 21 May
 2020 08:39:20 +0000
Subject: Re: [PATCH] spi: tegra20-slink: Fix runtime PM imbalance on error
To:     Andy Shevchenko <andy.shevchenko@gmail.com>,
        Dinghao Liu <dinghao.liu@zju.edu.cn>
CC:     Kangjie Lu <kjlu@umn.edu>, Laxman Dewangan <ldewangan@nvidia.com>,
        "Mark Brown" <broonie@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        linux-spi <linux-spi@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
References: <20200521074946.21799-1-dinghao.liu@zju.edu.cn>
 <CAHp75VfOeUaqRW2vRwyWaz3JJw41hX5jTgE+kZ8pB8E_HtHwqw@mail.gmail.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <af91d97e-6367-996b-a925-a5c81f6fb182@nvidia.com>
Date:   Thu, 21 May 2020 09:38:52 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <CAHp75VfOeUaqRW2vRwyWaz3JJw41hX5jTgE+kZ8pB8E_HtHwqw@mail.gmail.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1590050283; bh=9uLtQsPxoNaJRi8sxPLkhckPw0g+X+KrcTIUZx4NfZk=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=AttJ7FDh44xMD7mI+iREGssNXw5zU2RVPvmo4Jo4ltPG/DR1bVvMQSflel+JQtEB3
         9ouUrhSJcQTZivK8eciplgY5/OBeSp/QwmICHQkJGCcWudtezMyCZZIGrhxtDzXj0o
         cvPyfBpqR3uYqEn2+u5lB+jfxZ5MqDMgoRkSKaD0p1xpLifRAXpGDLHOPlkrodSqCU
         DXgmf9ZIOjyKrRYzU8bvC2SdD2WS4lPDV37oqxBvpLJtTPFSq71EVYzALjRka2F09b
         vx4J5CQqlFQ9kCQDQValw/tGeTORLnoftuZB0KQ4yEFTyx8a0aGL7xMgNVzXIPDvE/
         32dORs7OSfnVg==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 21/05/2020 09:04, Andy Shevchenko wrote:
> On Thu, May 21, 2020 at 10:50 AM Dinghao Liu <dinghao.liu@zju.edu.cn> wrote:
>>
>> pm_runtime_get_sync() increments the runtime PM usage counter even
>> when it returns an error code. Thus a pairing decrement is needed on
>> the error handling path to keep the counter balanced.
> 
> ...
> 
>>         ret = pm_runtime_get_sync(&pdev->dev);
>>         if (ret < 0) {
>>                 dev_err(&pdev->dev, "pm runtime get failed, e = %d\n", ret);
> 
>> +               pm_runtime_put(&pdev->dev);
> 
> For all your patches, please, double check what you are proposing.
> 
> Here, I believe, the correct one will be _put_noidle().
> 
> AFAIU you are not supposed to actually suspend the device in case of error.
> But I might be mistaken, thus see above.
> 
>>                 goto exit_pm_disable;
>>         }


Is there any reason why this is not handled in pm_runtime_get itself?
Jon

-- 
nvpublic